aljaz/python-teos
1
0
Fork 0
mirror of https://github.com/aljazceru/python-teos.git synced 2025-12-17 22:24:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

plugin - repurpose invalid_appointments and adds misbehaving_proof

Browse Source 
invalid_appointments in TowerInfo was used to stored invalid appointment responses from the tower when it was misbehaving (i.e. wrong or missing signature). However, a single item was stored since the tower is abandoned after misbehaving. data reported as invalid by the tower was not backed up.

invalid_appointments now stores the appointment rejected by the tower and reported as invalid.
misbehaving_proof stores the proof of misbehaviour by the tower (single item)
This commit is contained in:
Sergi Delgado Segura
2020-05-05 17:03:31 +02:00
parent b650ba3c26
commit f5c634ed14
4 changed files with 39 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
watchtower-plugin/net/http.py
View File

@@ -42,9 +42,8 @@ def add_appointment(plugin, tower_id, tower, appointment_dict, signature):
raise TowerResponseError(message, status="subscription error")
elif data.get("error_code") >= errors.INVALID_REQUEST_FORMAT:
# DISCUSS: It may be worth backing up the data since otherwise the update is dropped
message = f"Appointment sent to {tower_id} is invalid"
raise TowerResponseError(message, status="reachable")
raise TowerResponseError(message, status="reachable", invalid_appointment=True)
elif status_code == constants.HTTP_SERVICE_UNAVAILABLE:
# Flag appointment for retry
@@ -68,9 +67,13 @@ def send_appointment(tower_id, tower, appointment_dict, signature):
raise SignatureError("The response does not contain the signature of the appointment", signature=None)
rpk = Cryptographer.recover_pk(Appointment.from_dict(appointment_dict).serialize(), tower_signature)
if tower_id != Cryptographer.get_compressed_pk(rpk):
recovered_id = Cryptographer.get_compressed_pk(rpk)
if tower_id != recovered_id:
raise SignatureError(
"The returned appointment's signature is invalid", tower_id=tower_id, rpk=rpk, signature=tower_signature
"The returned appointment's signature is invalid",
tower_id=tower_id,
recovered_id=recovered_id,
signature=tower_signature,
)
return response