aljaz/python-teos
1
0
Fork 0
mirror of https://github.com/aljazceru/python-teos.git synced 2025-12-17 22:24:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Flags methods not covered by unit tests

Browse Source
This commit is contained in:
Sergi Delgado Segura
2019-10-21 19:53:34 +01:00
parent 94156a67cc
commit 3afcf9e708
3 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pisa/block_processor.py
View File

@@ -65,6 +65,7 @@ class BlockProcessor:
return potential_matches return potential_matches
@staticmethod @staticmethod
# NOTCOVERED
def get_matches(potential_matches, locator_uuid_map, appointments): def get_matches(potential_matches, locator_uuid_map, appointments):
matches = [] matches = []
@@ -89,6 +90,7 @@ class BlockProcessor:
# DISCUSS: This method comes from the Responder and seems like it could go back there. # DISCUSS: This method comes from the Responder and seems like it could go back there.
@staticmethod @staticmethod
# NOTCOVERED
def check_confirmations(txs, unconfirmed_txs, tx_job_map, missed_confirmations): def check_confirmations(txs, unconfirmed_txs, tx_job_map, missed_confirmations):
for tx in txs: for tx in txs:

3
pisa/carrier.py
View File

@@ -17,6 +17,7 @@ class Receipt:
class Carrier: class Carrier:
# NOTCOVERED
def send_transaction(self, rawtx, txid): def send_transaction(self, rawtx, txid):
try: try:
logger.info("Pushing transaction to the network", txid=txid, rawtx=rawtx) logger.info("Pushing transaction to the network", txid=txid, rawtx=rawtx)
@@ -49,6 +50,8 @@ class Carrier:
receipt = Receipt(delivered=True, confirmations=confirmations, reason=RPC_VERIFY_ALREADY_IN_CHAIN) receipt = Receipt(delivered=True, confirmations=confirmations, reason=RPC_VERIFY_ALREADY_IN_CHAIN)
else: else:
# WIP: It would be better to return and let the caller call again if necessary
# There's a really unlikely edge case where a transaction can be reorged between receiving the # There's a really unlikely edge case where a transaction can be reorged between receiving the
# notification and querying the data. In such a case we just resend # notification and querying the data. In such a case we just resend
self.send_transaction(rawtx, txid) self.send_transaction(rawtx, txid)

3
pisa/tools.py
View File

@@ -7,12 +7,14 @@ from pisa.rpc_errors import RPC_INVALID_ADDRESS_OR_KEY
from pisa.utils.auth_proxy import AuthServiceProxy, JSONRPCException from pisa.utils.auth_proxy import AuthServiceProxy, JSONRPCException
# NOTCOVERED
def bitcoin_cli(): def bitcoin_cli():
return AuthServiceProxy("http://%s:%s@%s:%d" % (conf.BTC_RPC_USER, conf.BTC_RPC_PASSWD, conf.BTC_RPC_HOST, return AuthServiceProxy("http://%s:%s@%s:%d" % (conf.BTC_RPC_USER, conf.BTC_RPC_PASSWD, conf.BTC_RPC_HOST,
conf.BTC_RPC_PORT)) conf.BTC_RPC_PORT))
# TODO: currently only used in the Responder; might move there or in the BlockProcessor # TODO: currently only used in the Responder; might move there or in the BlockProcessor
# NOTCOVERED
def check_tx_in_chain(tx_id, logger=Logger(), tx_label='Transaction'): def check_tx_in_chain(tx_id, logger=Logger(), tx_label='Transaction'):
tx_in_chain = False tx_in_chain = False
confirmations = 0 confirmations = 0
@@ -39,6 +41,7 @@ def check_tx_in_chain(tx_id, logger=Logger(), tx_label='Transaction'):
return tx_in_chain, confirmations return tx_in_chain, confirmations
# NOTCOVERED
def can_connect_to_bitcoind(): def can_connect_to_bitcoind():
can_connect = True can_connect = True