aljaz/python-teos
1
0
Fork 0
mirror of https://github.com/aljazceru/python-teos.git synced 2025-12-17 22:24:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Simplifies the Cleaner and adds docstrings

Browse Source 
We were passing some unnecessary parameters to the Cleaner (locator) that could be derived from other data (uuid and appointments). Also standarises the order of the  parameters to match the rest of the methods
This commit is contained in:
Sergi Delgado Segura
2019-12-10 13:31:42 +01:00
parent b0bf653ba4
commit 2cdd78b8e6
4 changed files with 49 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/unit/test_cleaner.py
View File

@@ -96,9 +96,7 @@ def test_delete_completed_appointments(db_manager):
uuids = list(appointments.keys())
for uuid in uuids:
Cleaner.delete_completed_appointment(
appointments[uuid].locator, uuid, appointments, locator_uuid_map, db_manager
)
Cleaner.delete_completed_appointment(uuid, appointments, locator_uuid_map, db_manager)
# All appointments should have been deleted
assert len(appointments) == 0
@@ -118,7 +116,7 @@ def test_delete_completed_jobs_db_match(db_manager):
completed_jobs = [(job, 6) for job in selected_jobs]
Cleaner.delete_completed_jobs(jobs, tx_job_map, completed_jobs, height, db_manager)
Cleaner.delete_completed_jobs(completed_jobs, height, jobs, tx_job_map, db_manager)
assert not set(completed_jobs).issubset(jobs.keys())
@@ -156,5 +154,5 @@ def test_delete_completed_jobs_no_db_match(db_manager):
completed_jobs = [(job, 6) for job in selected_jobs]
# We should be able to delete the correct ones and not fail in the others
Cleaner.delete_completed_jobs(jobs, tx_job_map, completed_jobs, height, db_manager)
Cleaner.delete_completed_jobs(completed_jobs, height, jobs, tx_job_map, db_manager)
assert not set(completed_jobs).issubset(jobs.keys())