aljaz/python-teos
1
0
Fork 0
mirror of https://github.com/aljazceru/python-teos.git synced 2025-12-17 14:14:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adds missing try/catch when casting data from config file in ConfigLoader

Browse Source
This commit is contained in:
Sergi Delgado Segura
2020-03-22 19:09:48 +01:00
parent e9f442d419
commit 27e249e665
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
common/config_loader.py
View File

@@ -58,7 +58,11 @@ class ConfigLoader:
k_upper = k.upper() k_upper = k.upper()
if k_upper in self.conf_fields: if k_upper in self.conf_fields:
if self.conf_fields[k_upper]["type"] == int: if self.conf_fields[k_upper]["type"] == int:
self.conf_fields[k_upper]["value"] = int(v) try:
self.conf_fields[k_upper]["value"] = int(v)
except ValueError:
err_msg = "{} is not an integer ({}).".format(k, v)
raise ValueError(err_msg)
else: else:
self.conf_fields[k_upper]["value"] = v self.conf_fields[k_upper]["value"] = v
@@ -92,7 +96,7 @@ class ConfigLoader:
value = self.conf_fields[field]["value"] value = self.conf_fields[field]["value"]
correct_type = self.conf_fields[field]["type"] correct_type = self.conf_fields[field]["type"]
if (value is not None) and isinstance(value, correct_type): if isinstance(value, correct_type):
conf_dict[field] = value conf_dict[field] = value
else: else:
err_msg = "{} variable in config is of the wrong type".format(field) err_msg = "{} variable in config is of the wrong type".format(field)