Adds a bunch of comments related to the open issues. Clear old comments.

This commit is contained in:
Sergi Delgado Segura
2019-08-12 14:02:41 +01:00
parent 1cde4a2a11
commit 0978d0bf9e
5 changed files with 16 additions and 13 deletions

View File

@@ -24,9 +24,6 @@ class Blob:
# Transaction to be encrypted
# FIXME: The blob data should contain more things that just the transaction. Leaving like this for now.
tx = unhexlify(self.data)
# FIXME: tx_id should not be necessary (can be derived from tx SegWit-like). Passing it for now
# Extend the key using HKDF
tx_id = unhexlify(tx_id)
# master_key = H(tx_id | tx_id)

View File

@@ -131,8 +131,6 @@ def build_appointment(tx, tx_id, start_block, end_block, dispute_delta, debug, l
# FIXME: The blob data should contain more things that just the transaction. Leaving like this for now.
blob = Blob(tx, cipher, hash_function)
# FIXME: tx_id should not be necessary (can be derived from tx SegWit-like). Passing it for now
encrypted_blob = blob.encrypt(tx_id, debug, logging)
appointment = {"locator": locator, "start_time": start_block, "end_time": end_block,
@@ -146,7 +144,7 @@ def check_txid_format(txid):
if len(txid) != 64:
sys.exit("locator does not matches the expected size (32-byte / 64 hex chars).")
# TODO: Check this regexp
# TODO: #12-check-txid-regexp
return re.search(r'^[0-9A-Fa-f]+$', txid) is not None