From c8a728cdd7aad61aac5022b69ba607e3c8b5d69b Mon Sep 17 00:00:00 2001 From: Michael Schmoock Date: Mon, 6 Feb 2023 22:15:40 +0100 Subject: [PATCH] donations: fix the stop method --- donations/donations.py | 4 ++-- donations/test_donations.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/donations/donations.py b/donations/donations.py index 27e43ba..9fa4274 100755 --- a/donations/donations.py +++ b/donations/donations.py @@ -139,7 +139,7 @@ def stop_server(port): @plugin.method('donationserver') -def donationserver(request, command="start", port=8088): +def donationserver(command="start", port=8088): """Starts a donationserver with {start/stop/restart} on {port}. A Simple HTTP Server is created that can serve a donation webpage and @@ -177,7 +177,7 @@ def donationserver(request, command="start", port=8088): if stop_server(port): return "stopped server on port {}".format(port) else: - return "could not stop the server" + return "could not stop the server on port {}".format(port) if command == "restart": stop_server(port) diff --git a/donations/test_donations.py b/donations/test_donations.py index 45e399f..2f822fa 100644 --- a/donations/test_donations.py +++ b/donations/test_donations.py @@ -25,5 +25,5 @@ def test_donation_server(node_factory): port = reserve() l1.rpc.donationserver('start', port) l1.daemon.wait_for_logs('plugin-donations.py: Process server on port') - msg = l1.rpc.donationserver("stop") + msg = l1.rpc.donationserver("stop", port) assert msg.startswith(f'stopped server on port')