aljaz/plugins
1
0
Fork 0
mirror of https://github.com/aljazceru/plugins.git synced 2025-12-20 22:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

backup: fix deadlock by removing the sqlite3 check

Browse Source 
I commented out that check and placed a NOTE that future developers
to see upfront putting in RPC stuff in init is potentially bad.
This commit is contained in:
Michael Schmoock
2021-02-01 14:02:11 +01:00
committed by Christian Decker
parent abbdeabec6
commit 4a9df896ad
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
backup/backup.py
View File

@@ -443,9 +443,12 @@ def on_init(options, **kwargs):
level="warn"
)
configs = plugin.rpc.listconfigs()
if not configs['wallet'].startswith('sqlite3'):
kill("The backup plugin only works with the sqlite3 database.")
# IMPORTANT NOTE
# Putting RPC stuff in init() like the following can cause deadlocks!
# See: https://github.com/lightningd/plugins/issues/209
#configs = plugin.rpc.listconfigs()
#if not configs['wallet'].startswith('sqlite3'):
# kill("The backup plugin only works with the sqlite3 database.")
def kill(message: str):