aljaz/plugins
1
0
Fork 0
mirror of https://github.com/aljazceru/plugins.git synced 2025-12-22 23:54:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

noise: fix #331

Browse Source 
fixes an off by one error
This commit is contained in:
Michael Schmoock
2022-02-21 11:02:28 +01:00
parent f472484acd
commit 23a8f09b4d
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
noise/noise.py
View File

@@ -160,7 +160,7 @@ def recvmsg(plugin, request, last_id=None, **kwargs):
Returns a `concurrent.futures.Future`. Returns a `concurrent.futures.Future`.
Optional parameter `last_id` can be supplied to return an older message. Optional parameter `last_id` can be supplied to return an older message.
""" """
next_id = int(last_id) + 1 if last_id is not None else len(plugin.messages) next_id = int(last_id) if last_id is not None else len(plugin.messages)
if next_id < len(plugin.messages): if next_id < len(plugin.messages):
res = plugin.messages[int(last_id)].to_dict() res = plugin.messages[int(last_id)].to_dict()
res['total_messages'] = len(plugin.messages) res['total_messages'] = len(plugin.messages)

1
noise/test_chat.py
View File

@@ -143,7 +143,6 @@ def test_forward_ok(node_factory, executor):
assert(m2['verified'] is True) assert(m2['verified'] is True)
@pytest.mark.xfail(raises=concurrent.futures._base.TimeoutError)
def test_read_tip(node_factory, executor): def test_read_tip(node_factory, executor):
"""Testcase for issue #331 https://github.com/lightningd/plugins/issues/331 """Testcase for issue #331 https://github.com/lightningd/plugins/issues/331