make plan agent whitelist more conservative (#3424)

This commit is contained in:
Aiden Cline
2025-10-24 14:40:36 -05:00
committed by GitHub
parent 74048ece2d
commit e88b659545
2 changed files with 55 additions and 6 deletions

View File

@@ -0,0 +1,55 @@
import { test, expect } from "bun:test"
import { Wildcard } from "../../src/util/wildcard"
test("match handles glob tokens", () => {
expect(Wildcard.match("file1.txt", "file?.txt")).toBe(true)
expect(Wildcard.match("file12.txt", "file?.txt")).toBe(false)
expect(Wildcard.match("foo+bar", "foo+bar")).toBe(true)
})
test("all picks the most specific pattern", () => {
const rules = {
"*": "deny",
"git *": "ask",
"git status": "allow",
}
expect(Wildcard.all("git status", rules)).toBe("allow")
expect(Wildcard.all("git log", rules)).toBe("ask")
expect(Wildcard.all("echo hi", rules)).toBe("deny")
})
test("allStructured matches command sequences", () => {
const rules = {
"git *": "ask",
"git status*": "allow",
}
expect(Wildcard.allStructured({ head: "git", tail: ["status", "--short"] }, rules)).toBe("allow")
expect(Wildcard.allStructured({ head: "npm", tail: ["run", "build", "--watch"] }, { "npm run *": "allow" })).toBe(
"allow",
)
expect(Wildcard.allStructured({ head: "ls", tail: ["-la"] }, rules)).toBeUndefined()
})
test("allStructured prioritizes flag-specific patterns", () => {
const rules = {
"find *": "allow",
"find * -delete*": "ask",
"sort*": "allow",
"sort -o *": "ask",
}
expect(Wildcard.allStructured({ head: "find", tail: ["src", "-delete"] }, rules)).toBe("ask")
expect(Wildcard.allStructured({ head: "find", tail: ["src", "-print"] }, rules)).toBe("allow")
expect(Wildcard.allStructured({ head: "sort", tail: ["-o", "out.txt"] }, rules)).toBe("ask")
expect(Wildcard.allStructured({ head: "sort", tail: ["--reverse"] }, rules)).toBe("allow")
})
test("allStructured handles sed flags", () => {
const rules = {
"sed * -i*": "ask",
"sed -n*": "allow",
}
expect(Wildcard.allStructured({ head: "sed", tail: ["-i", "file"] }, rules)).toBe("ask")
expect(Wildcard.allStructured({ head: "sed", tail: ["-i.bak", "file"] }, rules)).toBe("ask")
expect(Wildcard.allStructured({ head: "sed", tail: ["-n", "1p", "file"] }, rules)).toBe("allow")
expect(Wildcard.allStructured({ head: "sed", tail: ["-i", "-n", "/./p", "myfile.txt"] }, rules)).toBe("ask")
})