From 4c198940d5d9a207315772fa6e334fcf7275f9bc Mon Sep 17 00:00:00 2001 From: Dax Raad Date: Mon, 26 May 2025 22:25:17 -0400 Subject: [PATCH] Remove debug console.log statements and improve LSP diagnostic handling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🤖 Generated with opencode Co-Authored-By: opencode --- js/src/lsp/client.ts | 5 +++-- js/src/tool/diagnostics.ts | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/src/lsp/client.ts b/js/src/lsp/client.ts index 0ad7be6e..e8e7d694 100644 --- a/js/src/lsp/client.ts +++ b/js/src/lsp/client.ts @@ -51,8 +51,10 @@ export namespace LSPClient { log.info("textDocument/publishDiagnostics", { path, }); - console.log(path, params); + const exists = diagnostics.has(path); diagnostics.set(path, params.diagnostics); + // servers seem to send one blank publishDiagnostics event before the first real one + if (!exists && !params.diagnostics.length) return; Bus.publish(Event.Diagnostics, { path, serverID: input.serverID }); }); connection.listen(); @@ -131,7 +133,6 @@ export namespace LSPClient { notify: { async open(input: { path: string }) { const file = Bun.file(input.path); - if (!file.exists()) return; const text = await file.text(); const opened = files.has(input.path); if (!opened) { diff --git a/js/src/tool/diagnostics.ts b/js/src/tool/diagnostics.ts index efd4b880..3610c778 100644 --- a/js/src/tool/diagnostics.ts +++ b/js/src/tool/diagnostics.ts @@ -40,7 +40,6 @@ TIPS: : path.join(app.root, args.path); await LSP.file(normalized); const diagnostics = await LSP.diagnostics(); - console.log(diagnostics, "diagnostics"); const file = diagnostics[normalized]; return { metadata: {