FEAT: Add flake8 (#267)

* init flake8

* exclude nostr client, and add ds_store to gitignore

* fix flake8 F811 issue, redefinition of unused variables

* add flake8 to workflow

* F401 unused imports

* F541 f-string is missing placeholders

* E501 line too long > 150 characters

* E722 no bare except

* E402 module level import not at top of file

* F405 no star imports

* E712 comparison to False should be 'if cond is False:'

* F841 local variable is assigned to but never used

* E266 too many leading '#' for block comment

* E265, E261

* E713 test for membership should be 'not in'

* E711, E741

E741 ambiguous variable name 'l'
E711 comparison to None should be 'if cond is None:'

* flake config

* isort

* refactor makefile flake8 usage

* reflaking the rebase

* black

* fix tests?

* black

* fix line lenght it test_cli

* sort out makefile

* fix strings

* reintroduce black-check

* reflake and mypy

* isort

* Update cashu/wallet/wallet.py

Co-authored-by: Angus Pearson <angus@toaster.cc>

* Update cashu/mint/ledger.py

Co-authored-by: Angus Pearson <angus@toaster.cc>

---------

Co-authored-by: Angus Pearson <angus@toaster.cc>
This commit is contained in:
dni ⚡
2023-07-28 18:42:16 +02:00
committed by GitHub
parent 4c1ff8b353
commit e3ed00640f
41 changed files with 338 additions and 425 deletions

View File

@@ -34,7 +34,7 @@ class LNbitsWallet(Wallet):
try:
data = r.json()
except:
except Exception:
return StatusResponse(
f"Failed to connect to {self.endpoint}, got: '{r.text[:200]}...'", 0
)
@@ -61,7 +61,7 @@ class LNbitsWallet(Wallet):
url=f"{self.endpoint}/api/v1/payments", json=data
)
r.raise_for_status()
except:
except Exception:
return InvoiceResponse(False, None, None, r.json()["detail"])
ok, checking_id, payment_request, error_message = (
True,
@@ -83,20 +83,13 @@ class LNbitsWallet(Wallet):
timeout=None,
)
r.raise_for_status()
except:
except Exception:
error_message = r.json()["detail"]
return PaymentResponse(None, None, None, None, error_message)
if r.status_code > 299:
return PaymentResponse(None, None, None, None, f"HTTP status: {r.reason}")
if "detail" in r.json():
return PaymentResponse(None, None, None, None, r.json()["detail"])
ok, checking_id, fee_msat, preimage, error_message = (
True,
None,
None,
None,
None,
)
data = r.json()
checking_id = data["payment_hash"]
@@ -104,7 +97,7 @@ class LNbitsWallet(Wallet):
# we do this to get the fee and preimage
payment: PaymentStatus = await self.get_payment_status(checking_id)
return PaymentResponse(ok, checking_id, payment.fee_msat, payment.preimage)
return PaymentResponse(True, checking_id, payment.fee_msat, payment.preimage)
async def get_invoice_status(self, checking_id: str) -> PaymentStatus:
try:
@@ -112,7 +105,7 @@ class LNbitsWallet(Wallet):
url=f"{self.endpoint}/api/v1/payments/{checking_id}"
)
r.raise_for_status()
except:
except Exception:
return PaymentStatus(None)
if r.json().get("detail"):
return PaymentStatus(None)
@@ -124,7 +117,7 @@ class LNbitsWallet(Wallet):
url=f"{self.endpoint}/api/v1/payments/{checking_id}"
)
r.raise_for_status()
except:
except Exception:
return PaymentStatus(None)
data = r.json()
if "paid" not in data and "details" not in data: