Refactor: melt quote unit validation (#489)

* refactor: mint quote validation

* convert amount in Lightning backend for later validation

* fix blink amount return tests

* retry tests

* fix conftest fakewallet

* fix start

tests/conftest.py

@@ -31,7 +31,7 @@ settings.mint_listen_port = SERVER_PORT
 settings.mint_url = SERVER_ENDPOINT
 settings.tor = False
 settings.wallet_unit = "sat"
-settings.mint_lightning_backend = settings.mint_lightning_backend or "FakeWallet"
+settings.mint_backend_bolt11_sat = settings.mint_backend_bolt11_sat or "FakeWallet"
 settings.fakewallet_brr = True
 settings.fakewallet_delay_payment = False
 settings.fakewallet_stochastic_invoice = False
@@ -111,7 +111,7 @@ async def ledger():
             await conn.execute("CREATE SCHEMA public;")
 
     wallets_module = importlib.import_module("cashu.lightning")
-    lightning_backend = getattr(wallets_module, settings.mint_lightning_backend)()
+    lightning_backend = getattr(wallets_module, settings.mint_backend_bolt11_sat)()
     backends = {
         Method.bolt11: {Unit.sat: lightning_backend},
     }

tests/test_mint_lightning_blink.py

@@ -7,7 +7,7 @@ from cashu.core.settings import settings
 from cashu.lightning.blink import MINIMUM_FEE_MSAT, BlinkWallet
 
 settings.mint_blink_key = "123"
-blink = BlinkWallet()
+blink = BlinkWallet(unit=Unit.sat)
 payment_request = (
     "lnbc10u1pjap7phpp50s9lzr3477j0tvacpfy2ucrs4q0q6cvn232ex7nt2zqxxxj8gxrsdpv2phhwetjv4jzqcneypqyc6t8dp6xu6twva2xjuzzda6qcqzzsxqrrsss"
     "p575z0n39w2j7zgnpqtdlrgz9rycner4eptjm3lz363dzylnrm3h4s9qyyssqfz8jglcshnlcf0zkw4qu8fyr564lg59x5al724kms3h6gpuhx9xrfv27tgx3l3u3cyf6"
@@ -194,32 +194,32 @@ async def test_blink_get_payment_quote():
     respx.post(blink.endpoint).mock(return_value=Response(200, json=mock_response))
     quote = await blink.get_payment_quote(payment_request)
     assert quote.checking_id == payment_request
-    assert quote.amount == Amount(Unit.msat, 1000000)  # msat
-    assert quote.fee == Amount(Unit.msat, 5000)  # msat
+    assert quote.amount == Amount(Unit.sat, 1000)  # sat
+    assert quote.fee == Amount(Unit.sat, 5)  # sat
 
     # response says 10 sat fees but invoice (1000 sat) * 0.5% is 5 sat so we expect 10 sat
     mock_response = {"data": {"lnInvoiceFeeProbe": {"amount": 10}}}
     respx.post(blink.endpoint).mock(return_value=Response(200, json=mock_response))
     quote = await blink.get_payment_quote(payment_request)
     assert quote.checking_id == payment_request
-    assert quote.amount == Amount(Unit.msat, 1000000)  # msat
-    assert quote.fee == Amount(Unit.msat, 10000)  # msat
+    assert quote.amount == Amount(Unit.sat, 1000)  # sat
+    assert quote.fee == Amount(Unit.sat, 10)  # sat
 
     # response says 10 sat fees but invoice (4973 sat) * 0.5% is 24.865 sat so we expect 25 sat
     mock_response = {"data": {"lnInvoiceFeeProbe": {"amount": 10}}}
     respx.post(blink.endpoint).mock(return_value=Response(200, json=mock_response))
     quote = await blink.get_payment_quote(payment_request_4973)
     assert quote.checking_id == payment_request_4973
-    assert quote.amount == Amount(Unit.msat, 4973000)  # msat
-    assert quote.fee == Amount(Unit.msat, 25000)  # msat
+    assert quote.amount == Amount(Unit.sat, 4973)  # sat
+    assert quote.fee == Amount(Unit.sat, 25)  # sat
 
     # response says 0 sat fees but invoice (1 sat) * 0.5% is 0.005 sat so we expect MINIMUM_FEE_MSAT/1000 sat
     mock_response = {"data": {"lnInvoiceFeeProbe": {"amount": 0}}}
     respx.post(blink.endpoint).mock(return_value=Response(200, json=mock_response))
     quote = await blink.get_payment_quote(payment_request_1)
     assert quote.checking_id == payment_request_1
-    assert quote.amount == Amount(Unit.msat, 1000)  # msat
-    assert quote.fee == Amount(Unit.msat, MINIMUM_FEE_MSAT)  # msat
+    assert quote.amount == Amount(Unit.sat, 1)  # sat
+    assert quote.fee == Amount(Unit.sat, MINIMUM_FEE_MSAT // 1000)  # msat
 
 
 @respx.mock
@@ -230,5 +230,5 @@ async def test_blink_get_payment_quote_backend_error():
     respx.post(blink.endpoint).mock(return_value=Response(200, json=mock_response))
     quote = await blink.get_payment_quote(payment_request)
     assert quote.checking_id == payment_request
-    assert quote.amount == Amount(Unit.msat, 1000000)  # msat
-    assert quote.fee == Amount(Unit.msat, 5000)  # msat
+    assert quote.amount == Amount(Unit.sat, 1000)  # sat
+    assert quote.fee == Amount(Unit.sat, 5)  # sat

tests/test_mint_operations.py

@@ -118,7 +118,7 @@ async def test_mint_external(wallet1: Wallet, ledger: Ledger):
     quote = await ledger.mint_quote(PostMintQuoteRequest(amount=128, unit="sat"))
 
     mint_quote = await ledger.get_mint_quote(quote.quote)
-    assert not mint_quote.paid, "mint quote not should be paid"
+    assert not mint_quote.paid, "mint quote already paid"
 
     await assert_err(
         wallet1.mint(128, id=quote.quote),