Nutshell cleanup wishlist (#332)

* fix keys

* fix tests

* backwards compatible api upgrade

* upgrade seems to work

* fix tests

* add deprecated api functions

* add more tests of backwards compat

* add test serialization for nut00

* remove a redundant test

* move mint and melt to new api

* mypy works

* CI: mypy --check-untyped-defs

* add deprecated router

* add hints and remove logs

* fix tests

* cleanup

* use new mint and melt endpoints

* tests passing?

* fix mypy

* make format

* make format

* make format

* commit

* errors gone

* save

* adjust the API

* store quotes in db

* make mypy happy

* add fakewallet settings

* remove LIGHTNING=True and pass quote id for melt

* format

* tests passing

* add CoreLightningRestWallet

* add macaroon loader

* add correct config

* preimage -> proof

* move wallet.status() to cli.helpers.print_status()

* remove statuses from tests

* remove

* make format

* Use httpx in deprecated wallet

* fix cln interface

* create invoice before quote

* internal transactions and deprecated api testing

* fix tests

* add deprecated API tests

* fastapi type hints break things

* fix duplicate wallet error

* make format

* update poetry in CI to 1.7.1

* precommit restore

* remove bolt11

* oops

* default poetry

* store fee reserve for melt quotes and refactor melt()

* works?

* make format

* test

* finally

* fix deprecated models

* rename v1 endpoints to bolt11

* raise restore and check to v1, bump version to 0.15.0

* add version byte to keyset id

* remove redundant fields in json

* checks

* generate bip32 keyset wip

* migrate old keysets

* load duplicate keys

* duplicate old keysets

* revert router changes

* add deprecated /check and /restore endpoints

* try except invalidate

* parse unit from derivation path, adjust keyset id calculation with bytes

* remove keyest id from functions again and rely on self.keyset_id

* mosts tests work

* mint loads multiple derivation paths

* make format

* properly print units

* fix tests

* wallet works with multiple units

* add strike wallet and choose backend dynamically

* fix mypy

* add get_payment_quote to lightning backends

* make format

* fix startup

* fix lnbitswallet

* fix tests

* LightningWallet -> LightningBackend

* remove comments

* make format

* remove msat conversion

* add Amount type

* fix regtest

* use melt_quote as argument for pay_invoice

* test old api

* fees in sats

* fix deprecated fees

* fixes

* print balance correctly

* internally index keyset response by int

* add pydantic validation to input models

* add timestamps to mint db

* store timestamps for invoices, promises, proofs_used

* fix wallet migration

* rotate keys correctly for testing

* remove print

* update latest keyset

* fix tests

* fix test

* make format

* make format with correct black version

* remove nsat and cheese

* test against deprecated mint

* fix tests?

* actually use env var

* mint run with env vars

* moar test

* cleanup

* simplify tests, load all keys

* try out testing with internal invoices

* fix internal melt test

* fix test

* deprecated checkfees expects appropriate fees

* adjust comment

* drop lightning table

* split migration for testing for now, remove it later

* remove unused lightning table

* skip_private_key -> skip_db_read

* throw error on migration error

* reorder

* fix migrations

* fix lnbits fee return value negative

* fix typo

* comments

* add type

* make format

* split must use correct amount

* fix tests

* test deprecated api with internal/external melts

* do not split if not necessary

* refactor

* fix test

* make format with new black

* cleanup and add comments

* add quote state check endpoints

* fix deprecated wallet response

* split -> swap endpoint

* make format

* add expiry to quotes, get quote endpoints, and adjust to nut review comments

* allow overpayment of melt

* add lightning wallet tests

* commiting to save

* fix tests a bit

* make format

* remove comments

* get mint info

* check_spendable default False, and return payment quote checking id

* make format

* bump version in pyproject

* update to /v1/checkstate

* make format

* fix mint api checks

* return witness on /v1/checkstate

* no failfast

* try fail-fast: false in ci.yaml

* fix db lookup

* clean up literals

tests/conftest.py

@@ -1,3 +1,4 @@
+import asyncio
 import multiprocessing
 import os
 import shutil
@@ -9,35 +10,50 @@ import pytest_asyncio
 import uvicorn
 from uvicorn import Config, Server
 
+from cashu.core.base import Method, Unit
 from cashu.core.db import Database
 from cashu.core.migrations import migrate_databases
 from cashu.core.settings import settings
-from cashu.lightning.fake import FakeWallet
 from cashu.mint import migrations as migrations_mint
-from cashu.mint.crud import LedgerCrud
+from cashu.mint.crud import LedgerCrudSqlite
 from cashu.mint.ledger import Ledger
 
 SERVER_PORT = 3337
 SERVER_ENDPOINT = f"http://localhost:{SERVER_PORT}"
 
-settings.debug = True
+settings.debug = False
 settings.cashu_dir = "./test_data/"
 settings.mint_host = "localhost"
 settings.mint_port = SERVER_PORT
 settings.mint_host = "0.0.0.0"
 settings.mint_listen_port = SERVER_PORT
 settings.mint_url = SERVER_ENDPOINT
-settings.lightning = True
 settings.tor = False
+settings.wallet_unit = "sat"
 settings.mint_lightning_backend = settings.mint_lightning_backend or "FakeWallet"
+settings.fakewallet_brr = True
+settings.fakewallet_delay_payment = False
+settings.fakewallet_stochastic_invoice = False
 settings.mint_database = "./test_data/test_mint"
-settings.mint_derivation_path = "0/0/0/0"
+settings.mint_derivation_path = "m/0'/0'/0'"
+settings.mint_derivation_path_list = []
 settings.mint_private_key = "TEST_PRIVATE_KEY"
 settings.mint_max_balance = 0
 
+assert "test" in settings.cashu_dir
 shutil.rmtree(settings.cashu_dir, ignore_errors=True)
 Path(settings.cashu_dir).mkdir(parents=True, exist_ok=True)
 
+from cashu.mint.startup import lightning_backend  # noqa
+
+
+@pytest.fixture(scope="session")
+def event_loop():
+    policy = asyncio.get_event_loop_policy()
+    loop = policy.new_event_loop()
+    yield loop
+    loop.close()
+
 
 class UvicornServer(multiprocessing.Process):
     def __init__(self, config: Config):
@@ -52,33 +68,7 @@ class UvicornServer(multiprocessing.Process):
         self.server.run()
 
 
-@pytest_asyncio.fixture(scope="function")
-async def ledger():
-    async def start_mint_init(ledger: Ledger):
-        await migrate_databases(ledger.db, migrations_mint)
-        if settings.mint_cache_secrets:
-            await ledger.load_used_proofs()
-        await ledger.init_keysets()
-
-    database_name = "mint"
-
-    if not settings.mint_database.startswith("postgres"):
-        # clear sqlite database
-        db_file = os.path.join(settings.mint_database, database_name + ".sqlite3")
-        if os.path.exists(db_file):
-            os.remove(db_file)
-
-    ledger = Ledger(
-        db=Database(database_name, settings.mint_database),
-        seed=settings.mint_private_key,
-        derivation_path=settings.mint_derivation_path,
-        lightning=FakeWallet(),
-        crud=LedgerCrud(),
-    )
-    await start_mint_init(ledger)
-    yield ledger
-
-
+# # This fixture is used for tests that require API access to the mint
 @pytest.fixture(autouse=True, scope="session")
 def mint():
     config = uvicorn.Config(
@@ -92,3 +82,33 @@ def mint():
     time.sleep(1)
     yield server
     server.stop()
+
+
+# This fixture is used for all other tests
+@pytest_asyncio.fixture(scope="function")
+async def ledger():
+    async def start_mint_init(ledger: Ledger):
+        await migrate_databases(ledger.db, migrations_mint)
+        if settings.mint_cache_secrets:
+            await ledger.load_used_proofs()
+        await ledger.init_keysets()
+
+    if not settings.mint_database.startswith("postgres"):
+        # clear sqlite database
+        db_file = os.path.join(settings.mint_database, "mint.sqlite3")
+        if os.path.exists(db_file):
+            os.remove(db_file)
+
+    backends = {
+        Method.bolt11: {Unit.sat: lightning_backend},
+    }
+    ledger = Ledger(
+        db=Database("mint", settings.mint_database),
+        seed=settings.mint_private_key,
+        derivation_path=settings.mint_derivation_path,
+        backends=backends,
+        crud=LedgerCrudSqlite(),
+    )
+    await start_mint_init(ledger)
+    yield ledger
+    print("teardown")