aljaz/notedeck
1
0
Fork 0
mirror of https://github.com/aljazceru/notedeck.git synced 2025-12-19 01:24:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

check message length before prefix comparisons

Browse Source
This commit is contained in:
Ken Sedgwick
2025-02-20 16:04:29 -08:00
parent 22f9c32121
commit dfa4b24b7d
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
crates/enostr/src/relay/message.rs
View File

@@ -78,6 +78,11 @@ impl<'a> RelayMessage<'a> {
return Err(Error::Empty);
}
// make sure we can inspect the begning of the message below ...
if msg.len() < 12 {
return Err(Error::DecodeFailed("message too short".into()));
}
// Notice
// Relay response format: ["NOTICE", <message>]
if msg.len() >= 12 && &msg[0..=9] == "[\"NOTICE\"," {
@@ -159,6 +164,16 @@ mod tests {
fn test_handle_various_messages() -> Result<()> {
let tests = vec![
// Valid cases
(
// shortest valid message
r#"["EOSE","x"]"#,
Ok(RelayMessage::eose("x")),
),
(
// also very short
r#"["NOTICE",""]"#,
Ok(RelayMessage::notice("")),
),
(
r#"["NOTICE","Invalid event format!"]"#,
Ok(RelayMessage::notice("Invalid event format!")),
@@ -197,11 +212,11 @@ mod tests {
),
(
r#"["EOSE"]"#,
Err(Error::DecodeFailed("unrecognized message type".into())),
Err(Error::DecodeFailed("message too short".into())),
),
(
r#"["NOTICE"]"#,
Err(Error::DecodeFailed("unrecognized message type".into())),
Err(Error::DecodeFailed("message too short".into())),
),
(
r#"["NOTICE": 404]"#,