aljaz/lspd
1
0
Fork 0
mirror of https://github.com/aljazceru/lspd.git synced 2026-01-11 01:54:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix the lsps2 cltv delta check

Browse Source 
It was wrongly assumed that the lsp had to enforce a cltv delta +2. It is
actually the recipient creating invoices with a cltv delta +2, but the LSP does
not have anything to do with that.
This commit is contained in:
Jesse de Wit
2024-01-19 16:19:04 +01:00
parent fc6c5982b3
commit 833c79e27f
5 changed files with 6 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lsps2/intercept_handler.go
View File

@@ -278,9 +278,9 @@ func (i *Interceptor) processPart(payment *paymentState, part *partState) {
}
}
// Make sure the cltv delta is enough (actual cltv delta + 2).
// Make sure the cltv delta is enough.
if int64(part.req.IncomingExpiry)-int64(part.req.OutgoingExpiry) <
int64(i.config.TimeLockDelta)+2 {
int64(i.config.TimeLockDelta) {
i.failPart(payment, part, common.FAILURE_INCORRECT_CLTV_EXPIRY)
return
}

8
lsps2/intercept_test.go
View File

@@ -314,13 +314,13 @@ func Test_NoMpp_AmtAboveMaximum(t *testing.T) {
}
// Asserts that a no-MPP+var-invoice mode payment fails when the cltv delta is
// less than cltv delta + 2.
// less than cltv delta.
func Test_NoMpp_CltvDeltaBelowMinimum(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
i := setupInterceptor(ctx, nil)
res := i.Intercept(createPart(&part{cltvDelta: 145}))
res := i.Intercept(createPart(&part{cltvDelta: 143}))
assert.Equal(t, common.INTERCEPT_FAIL_HTLC_WITH_CODE, res.Action)
assert.Equal(t, common.FAILURE_INCORRECT_CLTV_EXPIRY, res.FailureCode)
assertEmpty(t, i)
@@ -533,13 +533,13 @@ func Test_Mpp_BadSecondPart_ThirdPartCompletes(t *testing.T) {
}
// Asserts that a MPP+fixed-invoice mode payment fails when the cltv delta is
// less than cltv delta + 2.
// less than cltv delta.
func Test_Mpp_CltvDeltaBelowMinimum(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
i := setupInterceptor(ctx, &interceptP{store: mppStore()})
res := i.Intercept(createPart(&part{cltvDelta: 145}))
res := i.Intercept(createPart(&part{cltvDelta: 143}))
assert.Equal(t, common.INTERCEPT_FAIL_HTLC_WITH_CODE, res.Action)
assert.Equal(t, common.FAILURE_INCORRECT_CLTV_EXPIRY, res.FailureCode)
assertEmpty(t, i)