From 702ee61b135084c0ce0227d34b8593a2e8daed69 Mon Sep 17 00:00:00 2001
From: SilasMarvin <19626586+SilasMarvin@users.noreply.github.com>
Date: Wed, 3 Jul 2024 20:51:32 -0700
Subject: [PATCH] Added todos and cleaned up tests

---
 crates/lsp-ai/src/memory_backends/vector_store.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/crates/lsp-ai/src/memory_backends/vector_store.rs b/crates/lsp-ai/src/memory_backends/vector_store.rs
index 0bf9339..a2222a2 100644
--- a/crates/lsp-ai/src/memory_backends/vector_store.rs
+++ b/crates/lsp-ai/src/memory_backends/vector_store.rs
@@ -196,6 +196,7 @@ impl VS {
                 .par_values()
                 .fold_with(BTreeMap::new(), |mut acc, chunks| {
                     for chunk in chunks {
+                        // TODO: Review what type of similarity we want to use here
                         let score = match (&chunk.vec, &embedding) {
                             (StoredChunkVec::F32(vec1), StoredChunkVec::F32(vec2)) => {
                                 #[cfg(feature = "simsimd")]
@@ -204,6 +205,7 @@ impl VS {
                                         SpatialSimilarity::cos(vec1, vec2).unwrap_or(0.) as f32
                                     )
                                 }
+                                // TODO: Add default similarity check
                                 #[cfg(not(feature = "simsimd"))]
                                 {
                                     0
@@ -216,6 +218,7 @@ impl VS {
                                         BinarySimilarity::hamming(vec1, vec2).unwrap_or(0.) as f32,
                                     )
                                 }
+                                // TODO: Add default similarity check
                                 #[cfg(not(feature = "simsimd"))]
                                 {
                                     0
@@ -905,7 +908,7 @@ assert multiply_two_numbers(2, 3) == 6
         println!("Insert took {} milliseconds.", elapsed_time.as_millis());
         // Time search
         let now = std::time::Instant::now();
-        let results = vector_store.search(5, embedding, "", ByteRange::new(0, 0))?;
+        vector_store.search(5, embedding, "", 0)?;
         let elapsed_time = now.elapsed();
         println!("Search took {} milliseconds.", elapsed_time.as_millis());
         Ok(())
@@ -940,7 +943,7 @@ assert multiply_two_numbers(2, 3) == 6
         println!("Insert took {} milliseconds.", elapsed_time.as_millis());
         // Time search
         let now = std::time::Instant::now();
-        let results = vector_store.search(5, embedding, "", ByteRange::new(0, 0))?;
+        vector_store.search(5, embedding, "", 0)?;
         let elapsed_time = now.elapsed();
         println!("Search took {} milliseconds.", elapsed_time.as_millis());
         Ok(())