mirror of
https://github.com/getAlby/lndhub.go.git
synced 2025-12-18 13:14:56 +01:00
badb700837
* chore: allow 0 limits for send/receive amount/volume * fix: use pointers for claims * fix: tests to set default as -1 * chore: add 0 check in outgoing exceeded tests * chore: also default max account balance to -1 * chore: remove dbUri :P * chore: remove print statements * chore: add more tests for limits
253 lines
11 KiB
Go
253 lines
11 KiB
Go
package integration_tests
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"time"
|
|
|
|
"github.com/getAlby/lndhub.go/common"
|
|
"github.com/getAlby/lndhub.go/lib/responses"
|
|
"github.com/labstack/echo/v4"
|
|
"github.com/lightningnetwork/lnd/lnrpc"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func (suite *PaymentTestSuite) TestOutGoingPayment() {
|
|
suite.service.Config.ServiceFee = 1
|
|
aliceFundingSats := 1000
|
|
externalSatRequested := 500
|
|
expectedServiceFee := 1
|
|
// 1 sat + 1 ppm
|
|
suite.mlnd.fee = 1
|
|
//fund alice account
|
|
invoiceResponse := suite.createAddInvoiceReq(aliceFundingSats, "integration test external payment alice", suite.aliceToken)
|
|
err := suite.mlnd.mockPaidInvoice(invoiceResponse, 0, false, nil)
|
|
assert.NoError(suite.T(), err)
|
|
|
|
//wait a bit for the callback event to hit
|
|
time.Sleep(10 * time.Millisecond)
|
|
|
|
//create external invoice
|
|
externalInvoice := lnrpc.Invoice{
|
|
Memo: "integration tests: external pay from alice",
|
|
Value: int64(externalSatRequested),
|
|
}
|
|
invoice, err := suite.externalLND.AddInvoice(context.Background(), &externalInvoice)
|
|
assert.NoError(suite.T(), err)
|
|
|
|
var buf bytes.Buffer
|
|
suite.service.Config.MaxSendAmount = 200
|
|
rec := httptest.NewRecorder()
|
|
assert.NoError(suite.T(), json.NewEncoder(&buf).Encode(&ExpectedPayInvoiceRequestBody{
|
|
Invoice: invoice.PaymentRequest,
|
|
}))
|
|
req := httptest.NewRequest(http.MethodPost, "/payinvoice", &buf)
|
|
req.Header.Set(echo.HeaderContentType, echo.MIMEApplicationJSON)
|
|
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", suite.aliceToken))
|
|
suite.echo.ServeHTTP(rec, req)
|
|
//should fail because max send amount check
|
|
assert.Equal(suite.T(), http.StatusBadRequest, rec.Code)
|
|
resp := &responses.ErrorResponse{}
|
|
err = json.NewDecoder(rec.Body).Decode(resp)
|
|
assert.NoError(suite.T(), err)
|
|
assert.Equal(suite.T(), responses.SendExceededError.Message, resp.Message)
|
|
|
|
suite.service.Config.MaxSendAmount = -1
|
|
//pay external from alice
|
|
payResponse := suite.createPayInvoiceReq(&ExpectedPayInvoiceRequestBody{
|
|
Invoice: invoice.PaymentRequest,
|
|
}, suite.aliceToken)
|
|
assert.NotEmpty(suite.T(), payResponse.PaymentPreimage)
|
|
|
|
// check that balance was reduced
|
|
userId := getUserIdFromToken(suite.aliceToken)
|
|
aliceBalance, err := suite.service.CurrentUserBalance(context.Background(), userId)
|
|
if err != nil {
|
|
fmt.Printf("Error when getting balance %v\n", err.Error())
|
|
}
|
|
assert.Equal(suite.T(), int64(aliceFundingSats)-int64(externalSatRequested+int(suite.mlnd.fee)+expectedServiceFee), aliceBalance)
|
|
|
|
// check that no additional transaction entry was created
|
|
transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
|
|
if err != nil {
|
|
fmt.Printf("Error when getting transaction entries %v\n", err.Error())
|
|
}
|
|
// verify transaction entries data
|
|
feeAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeFees, userId)
|
|
incomingAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeIncoming, userId)
|
|
outgoingAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeOutgoing, userId)
|
|
currentAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeCurrent, userId)
|
|
|
|
outgoingInvoices, _ := suite.service.InvoicesFor(context.Background(), userId, common.InvoiceTypeOutgoing)
|
|
incomingInvoices, _ := suite.service.InvoicesFor(context.Background(), userId, common.InvoiceTypeIncoming)
|
|
assert.Equal(suite.T(), 1, len(outgoingInvoices))
|
|
assert.Equal(suite.T(), 1, len(incomingInvoices))
|
|
|
|
// check if there are 6 transaction entries:
|
|
// - [0] incoming
|
|
// - [1] outgoing
|
|
// - [2] fee_reserve
|
|
// - [3] service_fee
|
|
// - [4] fee_reserve_reversal
|
|
// - [5] fee
|
|
//
|
|
assert.Equal(suite.T(), 6, len(transactionEntries))
|
|
|
|
// the incoming funding
|
|
assert.Equal(suite.T(), int64(aliceFundingSats), transactionEntries[0].Amount)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[0].CreditAccountID)
|
|
assert.Equal(suite.T(), incomingAccount.ID, transactionEntries[0].DebitAccountID)
|
|
assert.Equal(suite.T(), int64(0), transactionEntries[0].ParentID)
|
|
assert.Equal(suite.T(), incomingInvoices[0].ID, transactionEntries[0].InvoiceID)
|
|
|
|
// the outgoing payment
|
|
assert.Equal(suite.T(), int64(externalSatRequested), transactionEntries[1].Amount)
|
|
assert.Equal(suite.T(), outgoingAccount.ID, transactionEntries[1].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[1].DebitAccountID)
|
|
assert.Equal(suite.T(), int64(0), transactionEntries[1].ParentID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[1].InvoiceID)
|
|
|
|
// fee
|
|
assert.Equal(suite.T(), int64(suite.mlnd.fee), transactionEntries[5].Amount)
|
|
assert.Equal(suite.T(), feeAccount.ID, transactionEntries[5].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[5].DebitAccountID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[5].InvoiceID)
|
|
|
|
// fee reserve + fee reserve reversal
|
|
assert.Equal(suite.T(), transactionEntries[4].Amount, transactionEntries[2].Amount) // the amount of the fee_reserve and the fee_reserve_reversal must be equal
|
|
assert.Equal(suite.T(), feeAccount.ID, transactionEntries[2].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[2].DebitAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[4].CreditAccountID)
|
|
assert.Equal(suite.T(), feeAccount.ID, transactionEntries[4].DebitAccountID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[2].InvoiceID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[4].InvoiceID)
|
|
|
|
// service fee
|
|
assert.Equal(suite.T(), int64(expectedServiceFee), transactionEntries[3].Amount)
|
|
assert.Equal(suite.T(), feeAccount.ID, transactionEntries[3].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[3].DebitAccountID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[3].InvoiceID)
|
|
|
|
// make sure fee entry parent id is previous entry
|
|
assert.Equal(suite.T(), transactionEntries[1].ID, transactionEntries[5].ParentID)
|
|
assert.Equal(suite.T(), transactionEntries[1].ID, transactionEntries[3].ParentID)
|
|
|
|
// fetch transactions, make sure the fee is there
|
|
// check invoices again
|
|
req = httptest.NewRequest(http.MethodGet, "/gettxs", nil)
|
|
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", suite.aliceToken))
|
|
rec = httptest.NewRecorder()
|
|
suite.echo.ServeHTTP(rec, req)
|
|
responseBody := &[]ExpectedOutgoingInvoice{}
|
|
assert.Equal(suite.T(), http.StatusOK, rec.Code)
|
|
assert.NoError(suite.T(), json.NewDecoder(rec.Body).Decode(&responseBody))
|
|
assert.Equal(suite.T(), int64(suite.mlnd.fee)+int64(expectedServiceFee), (*responseBody)[0].Fee)
|
|
suite.service.Config.ServiceFee = 0 // reset ServiceFee config (we don't expect the service fee everywhere)
|
|
}
|
|
|
|
func (suite *PaymentTestSuite) TestOutGoingPaymentWithNegativeBalance() {
|
|
// this will cause balance to go to -1
|
|
aliceFundingSats := 1000
|
|
externalSatRequested := 1000
|
|
// 1 sat + 1 ppm
|
|
suite.mlnd.fee = 1
|
|
//fund alice account
|
|
invoiceResponse := suite.createAddInvoiceReq(aliceFundingSats, "integration test external payment alice", suite.aliceToken)
|
|
err := suite.mlnd.mockPaidInvoice(invoiceResponse, 0, false, nil)
|
|
assert.NoError(suite.T(), err)
|
|
|
|
//wait a bit for the callback event to hit
|
|
time.Sleep(10 * time.Millisecond)
|
|
|
|
externalInvoice := lnrpc.Invoice{
|
|
Memo: "integration tests: external pay from alice",
|
|
Value: int64(externalSatRequested),
|
|
}
|
|
invoice, err := suite.externalLND.AddInvoice(context.Background(), &externalInvoice)
|
|
assert.NoError(suite.T(), err)
|
|
//pay external from alice
|
|
payResponse := suite.createPayInvoiceReq(&ExpectedPayInvoiceRequestBody{
|
|
Invoice: invoice.PaymentRequest,
|
|
}, suite.aliceToken)
|
|
assert.NotEmpty(suite.T(), payResponse.PaymentPreimage)
|
|
|
|
// check that balance was reduced
|
|
userId := getUserIdFromToken(suite.aliceToken)
|
|
|
|
aliceBalance, err := suite.service.CurrentUserBalance(context.Background(), userId)
|
|
if err != nil {
|
|
fmt.Printf("Error when getting balance %v\n", err.Error())
|
|
}
|
|
assert.Equal(suite.T(), int64(aliceFundingSats)-(int64(externalSatRequested)+suite.mlnd.fee), aliceBalance)
|
|
assert.Equal(suite.T(), int64(-1), aliceBalance)
|
|
|
|
// check that no additional transaction entry was created
|
|
transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
|
|
if err != nil {
|
|
fmt.Printf("Error when getting transaction entries %v\n", err.Error())
|
|
}
|
|
// verify transaction entries data
|
|
feeAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeFees, userId)
|
|
incomingAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeIncoming, userId)
|
|
outgoingAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeOutgoing, userId)
|
|
currentAccount, _ := suite.service.AccountFor(context.Background(), common.AccountTypeCurrent, userId)
|
|
|
|
outgoingInvoices, _ := suite.service.InvoicesFor(context.Background(), userId, common.InvoiceTypeOutgoing)
|
|
incomingInvoices, _ := suite.service.InvoicesFor(context.Background(), userId, common.InvoiceTypeIncoming)
|
|
assert.Equal(suite.T(), 1, len(outgoingInvoices))
|
|
assert.Equal(suite.T(), 1, len(incomingInvoices))
|
|
|
|
assert.Equal(suite.T(), 5, len(transactionEntries))
|
|
|
|
assert.Equal(suite.T(), int64(aliceFundingSats), transactionEntries[0].Amount)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[0].CreditAccountID)
|
|
assert.Equal(suite.T(), incomingAccount.ID, transactionEntries[0].DebitAccountID)
|
|
assert.Equal(suite.T(), int64(0), transactionEntries[0].ParentID)
|
|
assert.Equal(suite.T(), incomingInvoices[0].ID, transactionEntries[0].InvoiceID)
|
|
|
|
assert.Equal(suite.T(), int64(externalSatRequested), transactionEntries[1].Amount)
|
|
assert.Equal(suite.T(), outgoingAccount.ID, transactionEntries[1].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[1].DebitAccountID)
|
|
assert.Equal(suite.T(), int64(0), transactionEntries[1].ParentID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[1].InvoiceID)
|
|
|
|
assert.Equal(suite.T(), int64(suite.mlnd.fee), transactionEntries[4].Amount)
|
|
assert.Equal(suite.T(), feeAccount.ID, transactionEntries[2].CreditAccountID)
|
|
assert.Equal(suite.T(), currentAccount.ID, transactionEntries[2].DebitAccountID)
|
|
assert.Equal(suite.T(), outgoingInvoices[0].ID, transactionEntries[2].InvoiceID)
|
|
|
|
// make sure fee entry parent id is previous entry
|
|
assert.Equal(suite.T(), transactionEntries[1].ID, transactionEntries[4].ParentID)
|
|
}
|
|
|
|
func (suite *PaymentTestSuite) TestZeroAmountInvoice() {
|
|
aliceFundingSats := 1000
|
|
amtToPay := 1000
|
|
//fund alice account
|
|
invoiceResponse := suite.createAddInvoiceReq(aliceFundingSats, "integration test zero amount payment alice", suite.aliceToken)
|
|
err := suite.mlnd.mockPaidInvoice(invoiceResponse, 0, false, nil)
|
|
assert.NoError(suite.T(), err)
|
|
|
|
//wait a bit for the callback event to hit
|
|
time.Sleep(10 * time.Millisecond)
|
|
|
|
//create external invoice
|
|
externalInvoice := lnrpc.Invoice{
|
|
Memo: "integration tests: zero amount pay from alice",
|
|
Value: 0,
|
|
}
|
|
invoice, err := suite.externalLND.AddInvoice(context.Background(), &externalInvoice)
|
|
assert.NoError(suite.T(), err)
|
|
//pay external from alice
|
|
payResponse := suite.createPayInvoiceReq(&ExpectedPayInvoiceRequestBody{
|
|
Invoice: invoice.PaymentRequest,
|
|
Amount: amtToPay,
|
|
}, suite.aliceToken)
|
|
assert.NotEmpty(suite.T(), payResponse.PaymentPreimage)
|
|
assert.Equal(suite.T(), int64(amtToPay), payResponse.Amount)
|
|
}
|