diff --git a/backend/src/main/java/de/cotto/lndmanagej/service/NodeWarningsService.java b/backend/src/main/java/de/cotto/lndmanagej/service/NodeWarningsService.java index b37a2caa..1abf8b22 100644 --- a/backend/src/main/java/de/cotto/lndmanagej/service/NodeWarningsService.java +++ b/backend/src/main/java/de/cotto/lndmanagej/service/NodeWarningsService.java @@ -45,12 +45,8 @@ public class NodeWarningsService { .map(LocalChannel::getRemotePubkey) .distinct() .map(pubkey -> new AbstractMap.SimpleEntry<>(pubkey, getNodeWarnings(pubkey))) - .filter(this::hasWarnings) + .filter(entry -> entry.getValue().hasWarnings()) .map(entry -> new AbstractMap.SimpleEntry<>(nodeService.getNode(entry.getKey()), entry.getValue())) .collect(toMap(Entry::getKey, Entry::getValue)); } - - private boolean hasWarnings(Entry entry) { - return !entry.getValue().warnings().isEmpty(); - } } diff --git a/model/src/main/java/de/cotto/lndmanagej/model/warnings/NodeWarnings.java b/model/src/main/java/de/cotto/lndmanagej/model/warnings/NodeWarnings.java index a10d2de0..e6aa1a23 100644 --- a/model/src/main/java/de/cotto/lndmanagej/model/warnings/NodeWarnings.java +++ b/model/src/main/java/de/cotto/lndmanagej/model/warnings/NodeWarnings.java @@ -14,4 +14,8 @@ public record NodeWarnings(Set warnings) { public Set descriptions() { return warnings.stream().map(NodeWarning::description).collect(Collectors.toSet()); } + + public boolean hasWarnings() { + return !warnings.isEmpty(); + } } diff --git a/model/src/test/java/de/cotto/lndmanagej/model/warnings/NodeWarningsTest.java b/model/src/test/java/de/cotto/lndmanagej/model/warnings/NodeWarningsTest.java index 54618203..7550696f 100644 --- a/model/src/test/java/de/cotto/lndmanagej/model/warnings/NodeWarningsTest.java +++ b/model/src/test/java/de/cotto/lndmanagej/model/warnings/NodeWarningsTest.java @@ -33,4 +33,14 @@ class NodeWarningsTest { void none() { assertThat(NodeWarnings.NONE).isEqualTo(new NodeWarnings(Set.of())); } -} \ No newline at end of file + + @Test + void hasWarnings_empty() { + assertThat(NodeWarnings.NONE.hasWarnings()).isFalse(); + } + + @Test + void hasWarnings_several_warnings() { + assertThat(NODE_WARNINGS.hasWarnings()).isTrue(); + } +}