Rusty Russell 493c2ab1d7 openingd: clean up and fix minor leak. ...

test_openchannel_hook_1:
MEMLEAK: 0x557593c164e8'
  label=wire/fromwire.c:320:char[]'
   backtrace:'
     ccan/ccan/tal/tal.c:437 (tal_alloc_)'
     ccan/ccan/tal/tal.c:466 (tal_alloc_arr_)'
     wire/fromwire.c:320 (fromwire_wirestring)'
     openingd/gen_opening_wire.c:205 (fromwire_opening_got_offer_reply)'
     openingd/openingd.c:1067 (fundee_channel)'
     openingd/openingd.c:1279 (handle_peer_in)'
     openingd/openingd.c:1535 (main)'
   parents:

fromwire_opening_got_offer_reply() allocates two fields off NULL:
err_reason and our_upfront_shutdown_script.  err_reason is used
immediately afterwards (and was the leak detected here), so fixing
that is easy.

To fix the leak of our_upfront_shutdown_script, it makes sense to simply
make it a member of 'state'.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2019-11-28 11:50:13 +01:00

..

Makefile

per-peer-daemons: tie in gossip filter.

2019-09-06 14:35:01 +02:00

opening_wire.csv

openchannel hook: add new close_to field

2019-11-22 00:41:15 +00:00

openingd.c

openingd: clean up and fix minor leak.

2019-11-28 11:50:13 +01:00