Rusty Russell 6e9ae98e1e lightningd: don't send uninialized malformed fields to channeld. ...

==1224== Uninitialised byte(s) found during client check request
==1224==    at 0x152CAD: memcheck_ (mem.h:247)
==1224==    by 0x152D18: towire (towire.c:17)
==1224==    by 0x152DA1: towire_u16 (towire.c:28)
==1224==    by 0x142189: towire_failed_htlc (htlc_wire.c:29)
==1224==    by 0x16343F: towire_channel_init (gen_channel_wire.c:596)
==1224==    by 0x115C2C: peer_start_channeld (channel_control.c:249)
==1224==    by 0x131701: peer_connected (peer_control.c:503)
==1224==    by 0x117820: gossip_msg (gossip_control.c:182)
==1224==    by 0x139D97: sd_msg_read (subd.c:500)
==1224==    by 0x139676: read_fds (subd.c:327)
==1224==    by 0x179D52: next_plan (io.c:59)
==1224==    by 0x17A84F: do_plan (io.c:387)
==1224==  Address 0x1ffefffabe is on thread 1's stack
==1224==  in frame #2, created by towire_u16 (towire.c:26)

Followed by:

2018-06-18T21:53:04.129Z lightningd(1224): 03933884aaf1d6b108397e5efe5c86bcf2d8ca8d2f700eda99db9214fc2712b134 chan #1: Peer permanent failure in CHANNELD_NORMAL: lightning_channeld: received ERROR channel d0101486543e1a8b6871556a4fe1fba4ad4d83ce7f6f92919fd17bd1545d2fd5: UpdateFailMalformedHtlc message doesn't have BADONION bit set

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2018-07-08 15:56:34 +02:00

..

test

lightningd/params: fix typesafe check.

2018-07-07 23:49:25 +00:00

.gitignore

handshaked: remove.

2017-10-20 18:31:32 +02:00

bitcoind.c

bitcoind: fix spurious memleak reports.

2018-06-15 11:53:47 +02:00

bitcoind.h

bitcoind: fix spurious memleak reports.

2018-06-15 11:53:47 +02:00

chaintopology.c

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

chaintopology.h

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

channel_control.c

lightningd: fix up BOLT references.

2018-06-18 12:31:09 +02:00

channel_control.h

channel_control: Forget if unconfirmed for a long time and we are fundee.

2018-05-23 14:37:32 -07:00

channel_state.h

channel_states: fold all the ONCHAIND states into one.

2018-02-23 18:02:00 +01:00

channel.c

gossip: Disable channels when we lose the connection to the peer

2018-05-31 02:30:27 +00:00

channel.h

channel, opening_control: Make first_blocknum u32

2018-05-23 14:37:32 -07:00

closing_control.c

lightningd: fix up BOLT references.

2018-06-18 12:31:09 +02:00

closing_control.h

gossipd: drain fd instead of passing around gossip index.

2018-04-26 05:47:57 +00:00

connect_control.c

Added error code parameter to command_fail

2018-05-26 12:17:36 +02:00

connect_control.h

gossipd: keep reaching struct only when we're actively connecting, and don't retry

2018-04-26 05:47:57 +00:00

dev_ping.c

lightningd: fix up BOLT references.

2018-06-18 12:31:09 +02:00

gossip_control.c

gossip: Pass use_dns option down to gossipd

2018-06-21 11:21:16 +02:00

gossip_control.h

gossipd: separate init and activate.

2018-04-30 12:01:36 +02:00

gossip_msg.c

listpeers: expose peer features as 'local_features' and 'global_features'

2018-07-07 16:07:53 +02:00

gossip_msg.h

listpeers: expose peer features as 'local_features' and 'global_features'

2018-07-07 16:07:53 +02:00

hsm_control.c

hsmd: drop newdir logic.

2018-05-05 17:55:10 +02:00

hsm_control.h

hsmd: drop newdir logic.

2018-05-05 17:55:10 +02:00

htlc_end.c

Remove unused parameter ptr in corrupt(const void *ptr, ...)

2018-02-22 10:46:30 +01:00

htlc_end.h

htlc: keep channel pointer, not peer pointer.

2018-02-14 11:31:58 +01:00

invoice.c

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

invoice.h

invoices: Extensive reorganization of invoice system.

2018-01-16 13:03:54 +01:00

json.c

wireaddr: new type, ADDR_INTERNAL_FORPROXY, use it if we can't/wont resolve.

2018-05-11 09:15:54 +00:00

json.h

gossipd/lightningd: use wireaddr_internal.

2018-05-07 22:37:28 +02:00

jsonrpc_errors.h

wallet: clarify error 302.

2018-06-18 12:33:25 +02:00

jsonrpc.c

add alias and color to getinfo

2018-06-30 08:24:50 +00:00

jsonrpc.h

Added error code parameter to command_fail

2018-05-26 12:17:36 +02:00

lightningd.c

topo: Tell chain_topology about the min and max block height

2018-06-06 03:30:02 +00:00

lightningd.h

opts: Add option to disable DNS lookups

2018-06-21 11:21:16 +02:00

log_status.c

status: make status_io a more generic mechanism.

2018-05-10 02:28:44 +00:00

log_status.h

status: add multiple levels of logging.

2018-02-07 00:46:49 +00:00

log.c

Added error code parameter to command_fail

2018-05-26 12:17:36 +02:00

log.h

common/daemon: common routines for all daemons.

2018-04-03 14:03:28 +02:00

Makefile

Typesafe callback system for parsing json

2018-07-05 00:19:16 +00:00

memdump.c

Makefile: we don't need to define DEVELOPER explicitly.

2018-06-14 14:38:24 +02:00

onchain_control.c

lightningd: fix up BOLT references.

2018-06-18 12:31:09 +02:00

onchain_control.h

onchaind: Replay stored channeltxs to restore onchaind state

2018-04-25 14:33:38 +02:00

opening_control.c

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

opening_control.h

gossipd/lightningd: use wireaddr_internal.

2018-05-07 22:37:28 +02:00

options.c

Update to latest BOLT version.

2018-07-01 17:37:03 +02:00

options.h

hsmd: drop newdir logic.

2018-05-05 17:55:10 +02:00

params.c

params: removed tal context.

2018-07-05 00:19:16 +00:00

params.h

lightningd/params: fix typesafe check.

2018-07-07 23:49:25 +00:00

pay.c

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

pay.h

pay: Let sendpay modify the recorded msatoshi of payments.

2018-03-30 15:40:32 +02:00

payalgo.c

pay: Use locktime_max as maximum cumulative CLTV delta

2018-06-18 12:31:28 +02:00

payalgo.h

payalgo: New file for pay command.

2018-02-16 13:08:29 +01:00

peer_control.c

listpeers: expose peer features as 'local_features' and 'global_features'

2018-07-07 16:07:53 +02:00

peer_control.h

gossipd/gossip_constants.h: Single place for BOLT constants.

2018-05-19 15:52:56 -04:00

peer_htlcs.c

lightningd: don't send uninialized malformed fields to channeld.

2018-07-08 15:56:34 +02:00

peer_htlcs.h

channel_control: Forget if unconfirmed for a long time and we are fundee.

2018-05-23 14:37:32 -07:00

subd.c

lighningd: Remove --debug-subdaemon-io.

2018-05-20 02:32:42 +00:00

subd.h

subd: record which ones connect to a peer.

2018-04-26 05:47:57 +00:00

watch.c

Update ccan/structeq.

2018-07-04 23:57:00 +02:00

watch.h

topo: Remove in-memory txs from the block struct

2018-04-13 00:04:37 +02:00