Rusty Russell
cf55d40eca
psbt: fix dual-funding memleak.
This happened occasionally in tests/test_opening.py::test_rbf_fails_to_broadcast:
we overwrote the witness stack without freeing the old one.
```
lightningd-2: 2022-03-18T02:23:32.113Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: MEMLEAK: 0x559c375d9df8
lightningd-2: 2022-03-18T02:23:32.113Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: label=wally_tal
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: backtrace:
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ccan/ccan/tal/tal.c:442 (tal_alloc_)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ccan/ccan/tal/tal.c:471 (tal_alloc_arr_)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: common/setup.c:13 (wally_tal)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ../../../libwally-core/src/internal.c:285 (wally_calloc)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ../../../libwally-core/src/transaction.c:234 (wally_tx_witness_stack_init_alloc)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ../../../libwally-core/src/psbt.c:1119 (pull_psbt_input)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: ../../../libwally-core/src/psbt.c:1411 (wally_psbt_from_bytes)
lightningd-2: 2022-03-18T02:23:32.114Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: bitcoin/psbt.c:722 (psbt_from_bytes)
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: bitcoin/psbt.c:753 (fromwire_wally_psbt)
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: openingd/dualopend_wiregen.c:246 (fromwire_dualopend_reinit)
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: openingd/dualopend.c:3855 (main)
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: parents:
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: struct wally_psbt
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-dualopend-chan#1: openingd/dualopend.c:3804:struct state
lightningd-2: 2022-03-18T02:23:32.115Z **BROKEN** 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba932
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-03-21 10:19:50 +10:30
..
2022-03-18 09:20:11 +10:30
2021-12-14 11:21:35 +10:30
2021-09-17 09:43:22 +09:30
2021-12-28 04:42:42 +10:30
2021-12-28 04:42:42 +10:30
2021-11-17 10:51:48 +10:30
2021-11-17 10:51:48 +10:30
2021-12-06 10:05:39 +10:30
2018-05-10 02:28:44 +00:00
2021-11-14 18:49:46 +01:00
2021-11-14 18:49:46 +01:00
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2021-12-06 10:05:39 +10:30
2021-06-11 13:54:20 +09:30
2021-02-04 12:02:36 +10:30
2020-09-23 16:30:36 +09:30
2021-12-06 10:05:39 +10:30
2021-01-10 13:44:04 +01:00
2021-12-06 10:05:39 +10:30
2020-05-18 14:51:12 +02:00
2021-12-06 10:05:39 +10:30
2021-12-01 05:44:28 +10:30
2021-12-06 10:05:39 +10:30
2020-04-04 16:08:49 +10:30
2021-12-30 14:36:55 +10:30
2021-07-20 13:28:38 -04:00
2021-12-14 11:21:35 +10:30
2021-01-09 14:34:35 +10:30
2022-02-27 07:44:26 +10:30
2021-09-17 09:43:22 +09:30
2021-12-06 10:05:39 +10:30
2021-10-08 13:47:30 +02:00
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-10-23 12:59:13 +02:00
2021-12-30 09:50:40 +10:30
2021-12-30 09:50:40 +10:30
2021-12-06 10:05:39 +10:30
2021-10-08 16:07:21 +02:00
2022-03-10 10:22:29 +10:30
2022-03-10 10:22:29 +10:30
2020-04-07 13:52:48 +09:30
2022-03-05 15:12:12 +10:30
2022-03-05 15:12:12 +10:30
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2022-01-20 15:24:06 +10:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2022-01-20 15:24:06 +10:30
2021-09-17 09:43:22 +09:30
2021-10-10 13:22:29 +02:00
2020-02-02 12:59:17 +10:30
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2021-12-06 10:05:39 +10:30
2020-11-10 10:34:13 -06:00
2022-01-20 15:24:06 +10:30
2022-01-20 15:24:06 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2020-04-04 16:08:49 +10:30
2020-04-04 16:08:49 +10:30
2021-12-15 12:24:54 +10:30
2021-12-06 10:05:39 +10:30
2021-12-01 05:44:28 +10:30
2021-12-30 14:36:55 +10:30
2021-06-04 16:13:08 +09:30
2021-02-04 12:02:36 +10:30
2021-02-04 12:02:36 +10:30
2021-07-20 13:28:38 -04:00
2021-12-06 10:05:39 +10:30
2019-09-06 14:35:01 +02:00
2022-02-08 11:15:52 +10:30
2022-01-20 15:24:06 +10:30
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2021-12-06 10:05:39 +10:30
2020-02-05 14:19:12 +01:00
2021-12-06 10:05:39 +10:30
2020-12-11 15:51:24 +01:00
2021-12-15 12:24:54 +10:30
2021-12-15 12:24:54 +10:30
2021-12-06 10:05:39 +10:30
2018-02-08 22:49:34 +01:00
2021-12-06 10:05:39 +10:30
2021-10-23 12:59:13 +02:00
2022-02-27 07:44:26 +10:30
2022-01-27 12:22:36 +01:00
2022-03-16 12:06:21 +10:30
2022-03-16 12:06:21 +10:30
2021-09-17 09:43:22 +09:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2022-03-10 10:22:29 +10:30
2022-01-27 12:22:36 +01:00
2021-12-06 10:05:39 +10:30
2020-12-15 12:05:02 +01:00
2021-09-17 09:43:22 +09:30
2022-03-05 15:12:12 +10:30
2022-03-05 15:12:12 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-12-14 11:21:35 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-11-30 13:34:44 +10:30
2021-12-06 10:05:39 +10:30
2017-08-29 17:54:14 +02:00
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-07-20 13:28:38 -04:00
2022-03-10 10:22:29 +10:30
2022-03-20 08:42:57 +10:30
2021-11-27 10:38:13 +10:30
2022-01-20 15:24:06 +10:30
2022-01-20 15:24:06 +10:30
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2022-03-18 09:20:11 +10:30
2022-03-18 09:20:11 +10:30
2021-12-06 10:05:39 +10:30
2020-01-23 16:17:42 +10:30
2021-07-20 13:28:38 -04:00
2022-02-27 07:44:26 +10:30
2022-02-27 07:44:26 +10:30
2021-12-06 10:05:39 +10:30
2018-02-23 18:02:00 +01:00
2022-02-08 11:15:52 +10:30
2021-02-04 12:02:52 +10:30
2022-01-20 15:24:06 +10:30
2022-01-20 15:24:06 +10:30
2022-01-20 15:24:06 +10:30
2021-02-04 12:02:36 +10:30
2021-09-17 09:43:22 +09:30
2022-02-08 11:15:52 +10:30
2022-02-08 11:15:52 +10:30
2021-12-06 10:05:39 +10:30
2021-12-06 10:05:39 +10:30
2021-12-14 11:26:47 +10:30
2021-10-10 15:32:57 +02:00
2021-09-17 09:43:22 +09:30
2020-10-21 08:58:34 +10:30
2022-03-21 10:19:50 +10:30
2021-03-25 20:05:11 +10:30
2022-03-10 10:22:29 +10:30
2022-03-10 10:22:29 +10:30
2022-01-26 13:34:45 +10:30
2022-01-26 13:34:45 +10:30
2021-12-06 10:05:39 +10:30
2019-04-16 21:22:13 +00:00
2021-12-06 10:05:39 +10:30
2020-08-28 10:56:50 +09:30
2022-02-08 11:15:52 +10:30
2022-02-08 11:15:52 +10:30
2022-03-18 09:20:11 +10:30
2022-03-18 09:20:11 +10:30
2021-11-17 10:51:48 +10:30
2020-05-19 13:35:42 +09:30
2022-01-25 06:26:52 +10:30
2021-05-26 20:01:03 +09:30
2022-03-18 09:20:11 +10:30
2021-09-22 06:44:26 +09:30
2021-12-06 10:05:39 +10:30
2020-10-23 13:53:16 +10:30
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2018-02-08 19:07:12 +01:00
2022-02-08 11:15:52 +10:30
2021-09-17 09:43:22 +09:30
2022-01-20 15:24:06 +10:30
2021-09-17 09:43:22 +09:30
2022-01-20 15:24:06 +10:30
2022-01-20 15:24:06 +10:30
2020-10-20 12:50:31 +10:30
2021-09-21 18:04:43 +02:00
2021-12-06 10:05:39 +10:30
2022-03-21 10:19:50 +10:30
2022-03-21 10:19:50 +10:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2021-12-06 10:05:39 +10:30
2019-10-07 20:03:24 -05:00
2021-12-06 10:05:39 +10:30
2021-09-17 09:43:22 +09:30
2022-03-11 16:42:45 +10:30
2022-03-11 16:42:45 +10:30