Christian Decker 2146a548bd plugin: Do not return multiple times from pay ...

While we were unsetting the `payment->cmd` in case of a success to signal that
we should not return to the JSON-RPC command twice, we were not doing that in
the case of failures. This was causing multiple responses to a single incoming
command, and `lightningd` was correctly killing the plugin. This issue was
introduced through early returns (anything setting `payment->abort=true`) and
was caused in Rusty's case through an MPP timeout.

Fixes #3847
Reported-by: Rusty Russell <@rustyrussell>
Signed-off-by: Christian Decker <@cdecker>

2020-07-18 11:40:02 +02:00

..

data

migrations: ignore channels that don't have a peer_id

2020-06-17 14:30:41 +02:00

plugins

pytest: Reproduce issue #3847

2020-07-18 11:40:02 +02:00

vectors

pytest: Add tests for the sphinx onion generation and processing

2020-03-12 10:25:01 +10:30

benchmark.py

py-tests: rename 'announce' to 'wait_for_announce'

2018-12-08 15:15:55 -08:00

conftest.py

pytest: Pass result to fixtures and keep directories of failed tests

2018-08-07 00:54:19 +00:00

db.py

pytest: Have the DB provider search for the postgres binary

2019-09-22 02:03:43 +00:00

fixtures.py

pytest: Add a compat() fixture allowing checks for specific flags

2020-07-07 23:25:45 +02:00

test_closing.py

pytest: Disable MPP sending for 4 tests

2020-07-15 11:32:58 +02:00

test_connection.py

pytest: Disable MPP sending for 4 tests

2020-07-15 11:32:58 +02:00

test_db.py

migrations: ignore channels that don't have a peer_id

2020-06-17 14:30:41 +02:00

test_gossip.py

gossipd: return channel_announcement features for listchannels.

2020-05-07 08:44:58 +09:30

test_invoices.py

invoice: ignore dead-end heuristic on explicitly specified channels.

2020-04-14 14:13:26 -05:00

test_misc.py

JSON API: fix up two existing warnings to be conformant.

2020-07-14 21:28:26 +02:00

test_onion.py

pytest: Actually make sure that the direcory exists

2020-03-24 09:52:33 +10:30

test_pay.py

pytest: Disable test_pay_routeboost for valgrind due to timeout

2020-07-15 11:32:58 +02:00

test_plugin.py

plugin: Do not return multiple times from pay

2020-07-18 11:40:02 +02:00

test_wallet.py

fundpsbt: make parameters more usable.

2020-07-17 13:53:46 +02:00

utils.py

bitcoin: add weight calculation helpers.

2020-07-06 19:25:05 +02:00