Rusty Russell c96cee9b8d channeld: fix invalid assumption in htlc restore. ...

A long time ago (93dcd5fed7), I
simplified the htlc reload code so it adjusted the amounts for HTLCs
in id order.  As we presumably allowed them to be added in that order,
this avoided special-casing overflow (which was about to deliberately
be made harder by the new amount_msat code).

Unfortunately, htlc id order is not canonical, since htlc ids are
assigned consecutively in both directions!  Concretely, we can have two HTLCs:

	HTLC #0 LOCAL->REMOTE: 500,000,000 msat, state RCVD_REMOVE_REVOCATION
	HTLC #0 REMOTE->LOCAL: 10,000 msat, state SENT_ADD_COMMIT

On a new remote-funded channel, in which we have 0 balance, these
commits *only* work in this order.  Sorting by HTLC ID is not enough!
In fact, we'd have to worry about redemption order as well, as that
matters.

So, regretfully, we offset the balances halfway to UINT64_MAX, then check
they didn't underflow at the end.  This loses us this one sanity check,
but that's probably OK.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2019-11-05 22:38:07 +01:00

..

data

pytest: test db upgrade.

2019-09-06 14:19:14 +02:00

plugins

pytest: make test_plugin_slowinit a test again

2019-10-11 10:05:08 -05:00

benchmark.py

py-tests: rename 'announce' to 'wait_for_announce'

2018-12-08 15:15:55 -08:00

btcproxy.py

pytest: Do not edit the global copy of the bitcoind config

2019-10-03 04:32:57 +00:00

conftest.py

pytest: Pass result to fixtures and keep directories of failed tests

2018-08-07 00:54:19 +00:00

db.py

pytest: Have the DB provider search for the postgres binary

2019-09-22 02:03:43 +00:00

fixtures.py

pytest: Check for null access warnings in tests

2019-10-21 13:56:10 +02:00

requirements.txt

change psycopg2 to psycopg2-binary

2019-11-01 18:54:57 +01:00

test_closing.py

pytest: Add the test for compact of deprecated close style

2019-10-09 21:04:16 -05:00

test_connection.py

channeld: fix invalid assumption in htlc restore.

2019-11-05 22:38:07 +01:00

test_db.py

pytest: fix flaky 'Bad gossip' error in test_block_backfill

2019-11-04 17:50:58 +01:00

test_gossip.py

pytest: prepare test_gossip_timestamp_filter to be spammed.

2019-11-04 17:50:58 +01:00

test_invoices.py

pytest: Mark some tests as skippable that are too bitcoin-specific

2019-10-03 04:32:57 +00:00

test_misc.py

test: amend 'behind sync' tests

2019-11-04 17:52:48 +01:00

test_pay.py

pytest: allow bad gossip in test_pay_direct.

2019-10-21 14:08:05 +02:00

test_plugin.py

pytest: make test_plugin_slowinit a test again

2019-10-11 10:05:08 -05:00

test_wallet.py

pytest: test hsm_secret encryption

2019-10-09 22:00:38 -05:00

utils.py

pytest: add filters arg to query_gossip()

2019-10-10 21:48:52 -05:00