lightning

mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 07:04:22 +01:00

Files

Rusty Russell af7e641445 gossipd: don't "unmark" dying channels' updates if we receive them.

This looked like a test flake, but was real:

```
        l1.daemon.wait_for_log("closing soon due to the funding outpoint being spent")
    
        # We won't gossip the dead channel any more (but we still propagate node_announcement).  But connectd is not explicitly synced, so wait for "a bit".
        time.sleep(1)
>       assert len(get_gossip(l1)) == 2
E       assert 4 == 2
```

We can see that two channel_updates come in *after* we mark it dying:

```
gossipd: channel 103x1x0 closing soon due to the funding outpoint being spent
gossipd: REPLY WIRE_GOSSIPD_NEW_BLOCKHEIGHT_REPLY with 0 fds
022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-gossipd: Received channel_update for channel 103x1x0/0 now DISABLED
022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-gossipd: Received channel_update for channel 103x1x0/1 now DISABLED
```

We should keep marking channel_updates the same way.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2023-07-25 10:11:05 +09:30

.gitignore

gossipd/test/run-bench-find_route: don't abort if we try to route to ourselves

2017-12-20 13:57:28 +01:00

Makefile

common/onion: split into decode and encode routines.

2022-11-09 15:08:03 +01:00

run-check_channel_announcement.c

gossipd: don't "unmark" dying channels' updates if we receive them.

2023-07-25 10:11:05 +09:30

run-check_node_announcement.c

gossipd: don't use peer softrefs for gossip credit.