Rusty Russell 7e062fd637 onchaind: don't assert() when htlc fulfilled twice. ...

In the normal (peer-to-peer) path, the HTLC state prevents us fulfilling
twice, but this goes out the window with onchain HTLCs.

The actual assert which caught it was lightningd/pay.c:70 (payment_succeeded)
in the test_htlc_in_timeout test, after the next commit.

So add an assert earlier (in fulfill_our_htlc_out) and check in the
one caller where it can be true.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2018-01-02 13:21:25 +01:00

..

test

Remove duplicate includes

2017-12-28 16:09:24 +01:00

.gitignore

handshaked: remove.

2017-10-20 18:31:32 +02:00

bitcoind.c

bitcoind: delete chaintips code.

2017-12-21 14:33:27 +01:00

bitcoind.h

bitcoind: delete chaintips code.

2017-12-21 14:33:27 +01:00

build_utxos.c

build_utxos: fix weight calculation, and make more accurate.

2017-12-20 12:56:15 +01:00

build_utxos.h

build_utxos: fix weight calculation, and make more accurate.

2017-12-20 12:56:15 +01:00

chaintopology.c

chaintopology: only do callbacks once chain has settled.

2017-12-21 14:33:27 +01:00

chaintopology.h

chaintopology: only do callbacks once chain has settled.

2017-12-21 14:33:27 +01:00

dev_ping.c

jsonrpc: make explicit call to indicate cmd is still pending.

2017-12-20 12:43:10 +01:00

gossip_control.c

jsonrpc: make explicit call to indicate cmd is still pending.

2017-12-20 12:43:10 +01:00

gossip_control.h

gossipd: rewrite to do the handshake internally.

2017-10-20 18:31:32 +02:00

gossip_msg.c

ipaddr: rename to wireaddr.

2017-10-26 21:01:09 +00:00

gossip_msg.h

ipaddr: rename to wireaddr.

2017-10-26 21:01:09 +00:00

hsm_control.c

hsm: Cleanup after merging control and client libraries

2017-12-03 17:06:13 +01:00

hsm_control.h

lightningd/hsm_control: use a simple fd for HSM.

2017-06-27 10:25:53 +09:30

htlc_end.c

htlc_out: initialize hout->key.id, in case we destroy it before setting.

2017-12-21 09:13:28 +01:00

htlc_end.h

htlc_out: initialize hout->key.id, in case we destroy it before setting.

2017-12-21 09:13:28 +01:00

invoice.c

invoice: Properly implement waitinvoice.

2018-01-02 00:36:16 +00:00

invoice.h

invoice: Properly implement waitinvoice.

2018-01-02 00:36:16 +00:00

jsonrpc.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

jsonrpc.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

lightningd.c

lightningd: Add missing final cleanups.

2018-01-02 01:31:04 +00:00

lightningd.h

lightningd: use env var not cmdline to suppress backtrace.

2017-12-20 12:43:10 +01:00

log.c

log: mark ltmp as notleak.

2017-12-20 12:43:10 +01:00

log.h

memleak: add backtrace to allocations.

2017-12-20 12:43:10 +01:00

Makefile

lightningd: tal memleak detection, dev-memleak command.

2017-12-20 12:43:10 +01:00

memdump.c

lightningd: require explicit LIGHTNINGD_DEV_MEMLEAK env var to do memleak.

2017-12-20 12:43:10 +01:00

netaddress.c

wireaddr: add ip[:port] parsing

2017-12-21 09:56:20 +00:00

netaddress.h

wireaddr: add ip[:port] parsing

2017-12-21 09:56:20 +00:00

opt_time.c

common: absorb remaining files from daemon/

2017-08-29 17:54:14 +02:00

opt_time.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

options.c

Remove duplicate includes

2017-12-28 16:09:24 +01:00

options.h

ipaddr: rename to wireaddr.

2017-10-26 21:01:09 +00:00

pay.c

pay: close leaks.

2017-12-20 12:43:10 +01:00

pay.h

lightningd: unify pay vs forward path when handling failures.

2017-06-23 09:29:42 +09:30

peer_control.c

Pass bool true instead of "true" to json_add_bool(..., bool value)

2018-01-02 01:18:42 +00:00

peer_control.h

travis: reenable check-source (without BOLT text).

2017-12-21 14:33:27 +01:00

peer_htlcs.c

onchaind: don't assert() when htlc fulfilled twice.

2018-01-02 13:21:25 +01:00

peer_htlcs.h

htlc: Defer saving the outgoing payment until we store the HTLC

2017-11-23 23:45:28 +00:00

peer_state.h

gossipd: rewrite to do the handshake internally.

2017-10-20 18:31:32 +02:00

subd.c

subd: if a required daemon exits, wait instead of killing it.

2017-12-17 02:44:20 +00:00

subd.h

subd: wrap all message callbacks in a transaction.

2017-11-06 10:24:34 +01:00

txfilter.c

fixup! txfilter: Add a simple transaction filter

2017-11-29 14:39:12 +01:00

txfilter.h

fixup! txfilter: Add a simple transaction filter

2017-11-29 14:39:12 +01:00

watch.c

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00

watch.h

bitcoin: create new wrapper type bitcoin_txid, log backward endianness.

2017-12-21 11:05:38 +00:00