lightning

mirror of https://github.com/aljazceru/lightning.git synced 2026-01-10 17:44:22 +01:00

Files

Sebastian Falbesoner 3a881d9b41 db: unregister sqlite3 trace callback also in error case

For sqlite3 versions < 3.14 (i.e. HAVE_SQLITE3_EXPANDED_SQL is not set),
tracing is used to dump statements. The function db_sqlite3_exec()
registers a tracing callback in the beginning and unregisters it at the
end to "avoid it accessing the potentially stale pointer to stmt".
However, the unregistering so far only happened in the success case,
i.e. if the prepare or step calls failed, the callback was still set!

Running the test wallet/test/db-run with sqlite 3.11 leads to a
segmentation fault in the last call to db_commit_transaction():
the tested transaction contains an invalid statement and the (still
registered) trace callback is triggered then by sqlite3_exec() in
db_sqlite3_commit_tx(), leading to a segfault in db_changes_add()
(according to gdb), where it tries to access "stmt->query->readonly".

Changelog-None

2020-05-07 10:41:16 +09:30

test

plugin_hook_call: return indication whether we called the callback or not.

2020-05-05 13:45:17 +09:30

.gitignore

wallet: Create and manage a sqlite3 database for the wallet

2017-06-06 09:16:10 +09:30

db_common.h

db: Track the data_version in the database

2020-01-02 14:12:59 -06:00

db_postgres.c

db: Implement postgres driver primitives