mirror of
https://github.com/aljazceru/lightning.git
synced 2026-01-09 00:54:22 +01:00
Since we seem to have some isolation concerns when re-generating the same HSM secret and re-parsing the blockchain some blocks in the past. This also alleviates the problem of printing to a logging stream that has been closed. Previously bitcoind would keep running despite a test had failed and continue logging to the, now closed, StringIO that py.test uses when capturing stdout. The performance impact seems to be 1-3 second per test, not too bad IMHO for increased test isolation and cleaner logs: |--------------------+---------------+----------| | | No_valgrind | Valgrind | |--------------------+---------------+----------| | bitcoind per suite | 10 min 24 sec | 46:15.31 | | bitcoind per test | 11 min 38 sec | 49:21.64 | |--------------------+---------------+----------| Signed-off-by: Christian Decker <decker.christian@gmail.com>