aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-20 15:44:21 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
38d90b250596d38a777ab064c3788a730f14d753
lightning/plugins
History
Rusty Russell 38d90b2505 autoclean: fix timer crash when we're cleaning two things at once. 
If we had two things to clean, we fired off two requests (eg.
listforwards and listinvoices) and both marked the timer as finished,
triggering an assert.

We already have a refcount for outstanding requests to avoid this
for e.g. outstanding del commands, so use it here too!

```
Jan 19 19:20:00  lightningd[748044]: autoclean: plugins/libplugin.c:445: timer_complete: Assertion `p->in_timer > 0' failed.
Jan 19 19:20:00  lightningd[748044]: autoclean: FATAL SIGNAL 6 (version v22.11.1)
Jan 19 19:20:00  lightningd[748044]: 0x562c388136e4 send_backtrace
Jan 19 19:20:00  lightningd[748044]:         common/daemon.c:33
Jan 19 19:20:00  lightningd[748044]: 0x562c3881376c crashdump
Jan 19 19:20:00  lightningd[748044]:         common/daemon.c:46
Jan 19 19:20:00  lightningd[748044]: 0x7f26d0898d5f ???
Jan 19 19:20:00  lightningd[748044]:         ./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
Jan 19 19:20:00  lightningd[748044]: 0x7f26d0898ce1 __GI_raise
Jan 19 19:20:00  lightningd[748044]:         ../sysdeps/unix/sysv/linux/raise.c:51
Jan 19 19:20:00  lightningd[748044]: 0x7f26d0882536 __GI_abort
Jan 19 19:20:00  lightningd[748044]:         ./stdlib/abort.c:79
Jan 19 19:20:00  lightningd[748044]: 0x7f26d088240e __assert_fail_base
Jan 19 19:20:00  lightningd[748044]:         ./assert/assert.c:92
Jan 19 19:20:00  lightningd[748044]: 0x7f26d0891661 __GI___assert_fail
Jan 19 19:20:00  lightningd[748044]:         ./assert/assert.c:101
Jan 19 19:20:00  lightningd[748044]: 0x562c3880355d timer_complete
Jan 19 19:20:00  lightningd[748044]:         plugins/libplugin.c:445
Jan 19 19:20:00  lightningd[748044]: 0x562c38800b54 clean_finished
Jan 19 19:20:00  lightningd[748044]:         plugins/autoclean.c:122
Jan 19 19:20:00  lightningd[748044]: 0x562c388010ed clean_finished_one
Jan 19 19:20:00  lightningd[748044]:         plugins/autoclean.c:132
Jan 19 19:20:00  lightningd[748044]: 0x562c388011b6 del_done
Jan 19 19:20:00  lightningd[748044]:         plugins/autoclean.c:149
Jan 19 19:20:00  lightningd[748044]: 0x562c388058b5 handle_rpc_reply
Jan 19 19:20:00  lightningd[748044]:         plugins/libplugin.c:768
Jan 19 19:20:00  lightningd[748044]: 0x562c38805a39 rpc_read_response_one
Jan 19 19:20:00  lightningd[748044]:         plugins/libplugin.c:944
Jan 19 19:20:00  lightningd[748044]: 0x562c38805ad7 rpc_conn_read_response
Jan 19 19:20:00  lightningd[748044]:         plugins/libplugin.c:968
Jan 19 19:20:00  lightningd[748044]: 0x562c38876b60 next_plan
Jan 19 19:20:00  lightningd[748044]:         ccan/ccan/io/io.c:59
Jan 19 19:20:00  lightningd[748044]: 0x562c38876fe7 do_plan
Jan 19 19:20:00  lightningd[748044]:         ccan/ccan/io/io.c:407
Jan 19 19:20:00  lightningd[748044]: 0x562c38877080 io_ready
Jan 19 19:20:00  lightningd[748044]:         ccan/ccan/io/io.c:417
Jan 19 19:20:00  lightningd[748044]: 0x562c3887823c io_loop
Jan 19 19:20:00  lightningd[748044]:         ccan/ccan/io/poll.c:453
Jan 19 19:20:00  lightningd[748044]: 0x562c38805d11 plugin_main
Jan 19 19:20:00  lightningd[748044]:         plugins/libplugin.c:1801
Jan 19 19:20:00  lightningd[748044]: 0x562c38801c7a main
Jan 19 19:20:00  lightningd[748044]:         plugins/autoclean.c:613
```

Fixes: #5912
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2023-02-27 11:05:36 -06:00
..
bkpr
common/bolt11: const cleanup, fix parsing errors.
2023-01-25 13:59:34 -06:00
examples
pytest: Add test for optional options in cln-plugin
2022-11-03 11:28:22 +01:00
grpc-plugin
rs: Bump crate versions for publication
2022-12-22 15:42:12 +01:00
spender
v2 opens: don't use p2sh inputs for v2 opens
2023-02-04 15:31:16 +10:30
src
grpc: Silence a warning about nonnumericids being unused
2023-02-07 08:23:17 -06:00
test
common/gossip_store: clean up header.
2023-01-30 15:15:41 -06:00
.gitignore
ignore sql binary plugin
2023-02-08 14:38:58 -06:00
autoclean.c
autoclean: fix timer crash when we're cleaning two things at once.
2023-02-27 11:05:36 -06:00
bcli.c
libplugin: mark the cmd notleak() whenever command_still_pending() called.
2022-09-19 11:34:42 +09:30
Cargo.toml
rs: Add cln-plugin metadata
2023-01-02 14:33:02 +01:00
chanbackup.c
options: create enable/disable option for peer storage.
2023-02-08 08:37:59 -06:00
commando.c
commando: don't try putting an integer as the 'string' parameter to "datastore".
2023-02-11 12:22:40 -06:00
fetchinvoice.c
plugins: update to match latest offers text.
2023-01-30 13:24:29 +10:30
funder_policy.c
df: pass lease data back to funder for rbfs
2022-10-20 13:42:41 +02:00
funder_policy.h
df: pass lease data back to funder for rbfs
2022-10-20 13:42:41 +02:00
funder.c
v2 opens: don't use p2sh inputs for v2 opens
2023-02-04 15:31:16 +10:30
keysend.c
hsmd: add hsmd_preapprove_keysend and check_preapprovekeysend pay modifier
2023-01-26 21:10:15 -06:00
libplugin-pay.c
valgrind-fix: patch valgrind error on log statement in pay plugin
2023-02-02 18:08:27 -06:00
libplugin-pay.h
valgrind-fix: patch valgrind error on log statement in pay plugin
2023-02-02 18:08:27 -06:00
libplugin.c
libplugin: don't spew datastore errors to LOG_DEBUG.
2023-02-11 12:22:40 -06:00
libplugin.h
libplugin: don't spew datastore errors to LOG_DEBUG.
2023-02-11 12:22:40 -06:00
Makefile
Makefile: don't try to build sql plugin if there's no sqlite3 support.
2023-02-06 09:20:28 +01:00
offers_inv_hook.c
lightningd: re-add 'offerout' functionality, as 'invoicerequest'.
2022-11-09 15:08:03 +01:00
offers_inv_hook.h
lightningd: re-add 'offerout' functionality, as 'invoicerequest'.
2022-11-09 15:08:03 +01:00
offers_invreq_hook.c
offers: fix pay where we are using deprecated apis.
2023-02-03 16:59:51 +01:00
offers_invreq_hook.h
offers: create a real blinded path, if necessary.
2022-11-09 15:08:03 +01:00
offers_offer.c
plugins: update to match latest offers text.
2023-01-30 13:24:29 +10:30
offers_offer.h
lightningd: re-add 'offerout' functionality, as 'invoicerequest'.
2022-11-09 15:08:03 +01:00
offers.c
decode: fix handling of blinded_payinfo.
2023-01-30 13:24:29 +10:30
offers.h
common: update to latest onion message spec.
2022-10-26 11:29:06 +10:30
pay.c
hsmd: add hsmd_preapprove_invoice and check_preapproveinvoice pay modifier
2023-01-26 21:10:15 -06:00
README.md
doc: fix wording in plugins/README.md
2020-01-06 12:57:59 +01:00
sql.c
plugins/sql: fix foreign keys.
2023-02-02 14:56:04 -06:00
topology.c
plugins/topology: add direction field to listchannels.
2023-01-30 15:15:41 -06:00
txprepare.c
upgradewallet: JSONRPC call to update p2sh outputs to a native segwit
2023-02-04 15:31:16 +10:30

README.md

Plugin Directory

Any file in this directory which is executable and whose name only consists of alphanumeric characters, space, '.', '-' or '_' will be automatically loaded when lightningd starts (unless suppressed with commandline options).