aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 07:04:22 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
36e51568322f6bd3b2bf6fbcc48695cbe081caa9
lightning/lightningd
History
Rusty Russell 36e5156832 lightningd: fix close of ancient all-dust channel. 
libwally asserts() when trying to calculate the txid: we report it as
invalid elsewhere, but then crash:

```
May 19 20:37:03 c-lightning lightningd[26236]: 2022-05-19T20:37:03.689Z DEBUG   lightningd: close_command: timeout = 1
May 19 20:37:04 c-lightning lightningd[26236]: 2022-05-19T20:37:04.689Z UNUSUAL 037f32400c108f8385db94371bfcef08948bc0042069c1ef6f39086cdf23420ee5-chan#91: Peer permanent failure in CHANNELD_SHUTTING_DOWN: Forcibly closed by `close` command timeout
May 19 20:37:04 c-lightning lightningd[26236]: 2022-05-19T20:37:04.689Z **BROKEN** 037f32400c108f8385db94371bfcef08948bc0042069c1ef6f39086cdf23420ee5-chan#91: Cannot broadcast our commitment tx: it's invalid! (ancient channel?)
May 19 20:37:04 c-lightning lightningd[26236]: lightningd: bitcoin/tx.c:485: wally_txid: Assertion `len == written' failed.
May 19 20:37:04 c-lightning lightningd[26236]: lightningd: FATAL SIGNAL 6 (version v0.11.1)
May 19 20:37:04 c-lightning lightningd[26236]: 0x45bd01 send_backtrace
May 19 20:37:04 c-lightning lightningd[26236]:         common/daemon.c:33
May 19 20:37:04 c-lightning lightningd[26236]: 0x45bd8b crashdump
May 19 20:37:04 c-lightning lightningd[26236]:         common/daemon.c:46
May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f877604bf ???
May 19 20:37:04 c-lightning lightningd[26236]:         ???:0
May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87760438 ???
May 19 20:37:04 c-lightning lightningd[26236]:         ???:0
May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87762039 ???
May 19 20:37:04 c-lightning lightningd[26236]:         ???:0
May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87758be6 ???
May 19 20:37:04 c-lightning lightningd[26236]:         ???:0
May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87758c91 ???
May 19 20:37:04 c-lightning lightningd[26236]:         ???:0
May 19 20:37:04 c-lightning lightningd[26236]: 0x4751b7 wally_txid
May 19 20:37:04 c-lightning lightningd[26236]:         bitcoin/tx.c:485
May 19 20:37:04 c-lightning lightningd[26236]: 0x4751f4 bitcoin_txid
May 19 20:37:04 c-lightning lightningd[26236]:         bitcoin/tx.c:496
May 19 20:37:04 c-lightning lightningd[26236]: 0x40bad0 resolve_one_close_command
May 19 20:37:04 c-lightning lightningd[26236]:         lightningd/closing_control.c:60
May 19 20:37:04 c-lightning lightningd[26236]: 0x40cef3 resolve_close_command
May 19 20:37:04 c-lightning lightningd[26236]:         lightningd/closing_control.c:82
May 19 20:37:04 c-lightning lightningd[26236]: 0x430355 drop_to_chain
May 19 20:37:04 c-lightning lightningd[26236]:         lightningd/peer_control.c:286
```

Fixes: #5277
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2022-07-10 20:24:04 -05:00
..
test
options: let log-level subsystem filter also cover nodeid.
2022-07-09 09:59:52 +09:30
.gitignore
Ignore all the deamon inside the git history
2021-10-28 15:51:38 +02:00
bitcoind.c
lightningd: track weird CI crash in test_important_plugin
2022-06-27 17:21:35 +09:30
bitcoind.h
common: use bitcoin_outpoint.
2021-10-15 12:09:36 +02:00
chaintopology.c
lightningd: track weird CI crash in test_important_plugin
2022-06-27 17:21:35 +09:30
chaintopology.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
channel_control.c
channeld: Track the funding depth while awaiting lockin
2022-07-04 22:14:06 +02:00
channel_control.h
lightningd: handle reestablish directly from connectd.
2022-03-23 13:20:12 +10:30
channel_state.h
channel-state: add two new states, for dualopend
2021-01-10 13:44:04 +01:00
channel.c
channeld: fix uninitializes scid alias for dual-funding.
2022-07-09 09:59:52 +09:30
channel.h
channeld: Track the funding depth while awaiting lockin
2022-07-04 22:14:06 +02:00
closing_control.c
lightningd: fix close of ancient all-dust channel.
2022-07-10 20:24:04 -05:00
closing_control.h
patch lightningd-peer-fds.patch
2022-01-20 15:24:06 +10:30
coin_mvts.c
balance_snapshot: don't count unconfirmed utxos
2022-03-05 15:12:12 +10:30
coin_mvts.h
coin_mvt: tiny, dont import lightningd header
2022-02-07 13:02:09 +10:30
connect_control.c
lightnind: removeDEFAULT_PORT global definition
2022-06-28 06:09:01 +09:30
connect_control.h
lightningd: don't tell connectd to discard peer unless no subds left.
2022-03-23 13:20:12 +10:30
datastore.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
dual_open_control.c
df: check mempool/block for funding output on broadcast fail
2022-07-08 19:21:11 +09:30
dual_open_control.h
connectd: hold peer until we're interested.
2022-03-23 13:20:12 +10:30
gossip_control.c
gossip: Add both channel directions with their respective alias
2022-07-04 22:14:06 +02:00
gossip_control.h
connectd: remove second gossip fd.
2022-02-08 11:15:52 +10:30
hsm_control.c
cli: make the command line more user friendly.
2022-03-24 09:53:38 +10:30
hsm_control.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
htlc_end.c
lightningd: fix overzealous check in htlc_out_check:
2022-04-20 16:30:05 +09:30
htlc_end.h
coin_mvt: record fees for an outbound htlc
2021-12-28 04:42:42 +10:30
htlc_set.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
htlc_set.h
Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES
2020-09-08 09:42:00 +09:30
invoice.c
invoice: turn assert failure into more informative log_broken message.
2022-07-10 19:55:33 -05:00
invoice.h
Makefile: use completely separate spec-derived files for EXPERIMENTAL_FEATURES
2020-09-08 09:42:00 +09:30
io_loop_with_timers.c
database: pull out database code into a new module
2022-03-05 15:03:34 +10:30
io_loop_with_timers.h
lightningd/io_loop_with_timers.c: Move mainloop to its own source file, have chaintopology use it.
2019-05-31 17:57:10 +02:00
json.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
json.h
common: hoist param_bitcoin_address where plugins can use it.
2020-08-11 08:39:24 +09:30
jsonrpc.c
lightningd: track weird CI crash in test_important_plugin
2022-06-27 17:21:35 +09:30
jsonrpc.h
lightningd: cleanup, freeing jsonrpc in shutdown cannot trigger db write's anymore
2021-11-30 13:34:44 +10:30
lightningd.c
bolt: Reflect the zeroconf featurebits in code
2022-07-04 22:14:06 +02:00
lightningd.h
lightningd: multiple log-file options allow more than one log output.
2022-06-27 17:21:35 +09:30
log_status.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
log_status.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
log.c
lightningd: make log-prefix actually prepend all log messages as expected.
2022-07-09 09:59:52 +09:30
log.h
options: let log-level subsystem filter also cover nodeid.
2022-07-09 09:59:52 +09:30
Makefile
channeld: take over gossip_rcvd_filter.c and is_msg_gossip_broadcast.
2022-06-17 14:14:02 +09:30
memdump.c
memleak: fix double-free if we timeout.
2022-03-23 13:20:12 +10:30
memdump.h
lightningd: simplify memleak code.
2022-03-10 09:40:09 +10:30
notification.c
db: Store the local alias for forwarded incoming payments
2022-07-04 22:14:06 +02:00
notification.h
lightningd: add "style" to listforwards.
2022-03-31 19:38:05 +10:30
offer.c
Changed external/libwally-core to test_build_fix
2022-04-12 15:17:52 +09:30
onchain_control.c
lightningd: extra sanity checks and rescue attempts for missing HTLCs.
2022-03-31 13:40:27 +10:30
onchain_control.h
onchaind: remove 'is_replay' logic
2021-12-28 04:42:42 +10:30
onion_message.c
connectd: restore obs2 onion support.
2022-03-29 10:55:12 +10:30
onion_message.h
common: remove support for pre v0.10.2 onionmessages.
2021-12-01 05:44:28 +10:30
opening_common.c
jsonrpc: Add mindepth argument to fundchannel and multifundchannel
2022-07-04 22:14:06 +02:00
opening_common.h
lightningd: handle reestablish directly from connectd.
2022-03-23 13:20:12 +10:30
opening_control.c
lightningd: mark subd->conn notleak() properly in transition.
2022-07-09 09:59:52 +09:30
opening_control.h
connectd: hold peer until we're interested.
2022-03-23 13:20:12 +10:30
options.c
options: print empty options properly.
2022-07-09 09:59:52 +09:30
options.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
pay.c
ld: Use the local alias when reporting failures with zeroconf
2022-07-04 22:14:06 +02:00
pay.h
lightningd: use our cached channel_update for errors instead of asking gossipd.
2022-02-08 11:15:52 +10:30
peer_control.c
lightningd: fix close of ancient all-dust channel.
2022-07-10 20:24:04 -05:00
peer_control.h
lightningd: fix close of ancient all-dust channel.
2022-07-10 20:24:04 -05:00
peer_fd.c
subdaemons: remove gossipd fd from per-peer daemons.
2022-02-08 11:15:52 +10:30
peer_fd.h
subdaemons: remove gossipd fd from per-peer daemons.
2022-02-08 11:15:52 +10:30
peer_htlcs.c
ld: Use the local alias in the htlc_accepted hook
2022-07-04 22:14:06 +02:00
peer_htlcs.h
lightningd: extra sanity checks and rescue attempts for missing HTLCs.
2022-03-31 13:40:27 +10:30
ping.c
connectd: handle pings and pongs.
2022-02-08 11:15:52 +10:30
plugin_control.c
lightning-cli plugin start - Assume default relative path
2022-06-17 14:18:48 +09:30
plugin_control.h
plugins: add command field to subcommand output.
2021-06-25 09:49:33 +09:30
plugin_hook.c
lightningd: track weird CI crash in test_important_plugin
2022-06-27 17:21:35 +09:30
plugin_hook.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
plugin.c
lightningd: track weird CI crash in test_important_plugin
2022-06-27 17:21:35 +09:30
plugin.h
lightningd: cleanup obsolete plugins->shutdown flag
2021-12-14 09:33:10 +10:30
routehint.c
invoice: Consider aliases too when selecting routehints
2022-07-04 22:14:06 +02:00
routehint.h
invoice: overhaul routehints to use topology.listincoming, cleanup.
2021-06-16 10:29:17 +09:30
signmessage.c
signmessage: improve the UX of the rpc command when zbase is not a valid one
2022-06-24 14:02:04 +09:30
subd.c
options: let log-level subsystem filter also cover nodeid.
2022-07-09 09:59:52 +09:30
subd.h
subd: make channel/peer own the subd.
2022-03-30 06:27:52 +10:30
watch.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
watch.h
common: use bitcoin_outpoint.
2021-10-15 12:09:36 +02:00