Rusty Russell
c205970035
connectd: fix transient memleak report.
We left their_features dangling allocated off the hook_payload, whereas
we explicitly move it to the peer, so steal/take it onto that.
```
- Node /tmp/ltests-gh55a_h2/test_connection_moved_1/lightning-2/ has memory leaks: [
{
"backtrace": [
"/home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:477 (tal_alloc_)",
"/home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:506 (tal_alloc_arr_)",
"/home/runner/work/lightning/lightning/connectd/connectd_wiregen.c:410 (fromwire_connectd_peer_connected)",
"/home/runner/work/lightning/lightning/lightningd/peer_control.c:1418 (peer_connected)",
"/home/runner/work/lightning/lightning/lightningd/connect_control.c:592 (connectd_msg)",
"/home/runner/work/lightning/lightning/lightningd/subd.c:557 (sd_msg_read)",
"/home/runner/work/lightning/lightning/ccan/ccan/io/io.c:59 (next_plan)",
"/home/runner/work/lightning/lightning/ccan/ccan/io/io.c:407 (do_plan)",
"/home/runner/work/lightning/lightning/ccan/ccan/io/io.c:417 (io_ready)",
"/home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:453 (io_loop)",
"/home/runner/work/lightning/lightning/lightningd/io_loop_with_timers.c:22 (io_loop_with_timers)",
"/home/runner/work/lightning/lightning/lightningd/lightningd.c:1243 (main)"
],
"label": "connectd/connectd_wiregen.c:410:u8[]",
"parents": [
"lightningd/peer_control.c:1415:struct peer_connected_hook_payload",
"lightningd/plugin_hook.c:260:struct plugin_hook_request **NOTLEAK**",
"lightningd/plugin_hook.c:87:struct hook_instance *[] **NOTLEAK**"
],
"value": "0x5582622b1ff8"
}
]
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2023-07-22 08:52:55 +09:30
..
2023-07-21 16:44:22 +09:30
2021-10-28 15:51:38 +02:00
2023-07-11 11:41:15 +09:30
2023-06-29 11:28:47 -04:00
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-10 16:52:17 +09:30
2022-09-12 09:34:52 +09:30
2023-03-25 15:28:02 +10:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-03-25 15:28:02 +10:30
2023-03-25 15:28:02 +10:30
2023-07-11 11:41:15 +09:30
2022-09-16 12:31:45 +09:30
2023-01-21 08:05:31 -06:00
2022-02-07 13:02:09 +10:30
2023-07-09 16:49:48 +09:30
2023-07-09 16:49:48 +09:30
2023-02-05 20:40:47 +01:00
2023-02-11 12:22:40 -06:00
2023-07-11 11:41:15 +09:30
2023-01-13 10:42:42 +10:30
2023-07-09 16:49:48 +09:30
2023-04-10 07:31:12 +09:30
2023-03-18 15:55:49 +10:30
2022-09-24 15:22:27 +09:30
2023-06-29 11:28:47 -04:00
2023-04-10 17:26:47 +09:30
2022-10-26 11:29:06 +10:30
2022-10-26 11:29:06 +10:30
2023-04-07 21:22:56 +09:30
2020-09-08 09:42:00 +09:30
2023-07-18 14:24:01 +09:30
2023-07-18 14:24:01 +09:30
2022-03-05 15:03:34 +10:30
2019-05-31 17:57:10 +02:00
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-21 16:44:22 +09:30
2023-07-21 16:44:22 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-21 16:44:22 +09:30
2023-04-10 17:26:47 +09:30
2022-03-10 09:40:09 +10:30
2023-07-13 18:59:37 +09:30
2022-09-19 10:18:55 +09:30
2023-04-10 17:26:47 +09:30
2023-07-11 11:41:15 +09:30
2021-12-28 04:42:42 +10:30
2023-01-30 13:24:29 +10:30
2021-12-01 05:44:28 +10:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-06-29 11:28:47 -04:00
2023-01-13 10:42:42 +10:30
2023-07-19 19:13:57 +09:30
2023-06-20 20:08:25 +09:30
2023-07-19 19:13:57 +09:30
2022-09-19 10:18:55 +09:30
2023-07-22 08:52:55 +09:30
2023-07-22 08:52:55 +09:30
2022-02-08 11:15:52 +10:30
2022-02-08 11:15:52 +10:30
2023-07-09 16:49:48 +09:30
2023-01-17 14:13:45 +10:30
2022-07-15 12:24:00 -05:00
2022-09-16 12:31:45 +09:30
2021-06-25 09:49:33 +09:30
2023-07-19 19:13:57 +09:30
2022-09-16 12:31:45 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2022-08-09 16:31:36 -05:00
2021-06-16 10:29:17 +09:30
2023-07-21 16:44:22 +09:30
2023-07-21 16:44:22 +09:30
2023-04-10 17:26:47 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2023-07-19 19:13:57 +09:30
2022-08-31 12:18:28 +03:00