niftynei
0f05238e97
psbt: set the witness script to null, also
...
Otherwise libwally pushes the psbt-key for 'witness script' onto the
serialized version and we fail the 'is this identical' check.
Relevant line from libwally, where if bytes, we push a psbt_key.
```
static void push_typed_varbuff(unsigned char **cursor, size_t *max,
uint64_t type,
const unsigned char *bytes, size_t bytes_len)
{
if (bytes) {
push_psbt_key(cursor, max, type, NULL, 0);
push_varbuff(cursor, max, bytes, bytes_len);
}
}
```
Reported-By: @grubles
Changelog-Fixed: openchannel_signed would fail on PSBT comparison of materially identical PSBTs
2021-09-05 14:24:14 +02:00
..
2021-09-05 14:24:14 +02:00
2019-11-13 03:31:20 +00:00
2020-02-05 14:19:12 +01:00
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2018-07-30 11:31:17 +02:00
2018-05-10 02:28:44 +00:00
2020-10-21 19:34:39 +02:00
2020-10-21 19:34:39 +02:00
2020-12-09 16:40:13 +10:30
2020-12-09 16:40:13 +10:30
2021-06-11 13:54:20 +09:30
2021-06-11 13:54:20 +09:30
2021-02-04 12:02:36 +10:30
2020-09-23 16:30:36 +09:30
2021-01-10 13:44:04 +01:00
2021-01-10 13:44:04 +01:00
2020-05-18 14:51:12 +02:00
2020-05-18 14:51:12 +02:00
2020-12-15 12:05:02 +01:00
2021-01-13 14:45:36 +01:00
2020-04-04 16:08:49 +10:30
2020-04-04 16:08:49 +10:30
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-01-09 14:34:35 +10:30
2021-01-09 14:34:35 +10:30
2021-06-11 13:54:20 +09:30
2020-12-15 12:05:02 +01:00
2021-07-30 15:45:30 +09:30
2021-01-13 14:45:36 +01:00
2021-07-03 12:13:45 +09:30
2021-07-21 13:27:27 -04:00
2019-02-21 08:01:37 +00:00
2019-07-16 06:10:58 +00:00
2021-03-09 14:55:05 +10:30
2021-03-09 14:55:05 +10:30
2020-06-11 13:13:13 +02:00
2020-06-11 13:13:13 +02:00
2020-04-07 13:52:48 +09:30
2021-02-04 12:02:36 +10:30
2020-09-09 19:54:20 +09:30
2020-12-16 11:48:25 +01:00
2019-11-23 22:42:34 +00:00
2017-10-20 18:31:32 +02:00
2017-10-20 18:31:32 +02:00
2021-06-25 13:23:28 +09:30
2019-06-04 01:29:39 +00:00
2021-02-04 12:02:36 +10:30
2018-09-28 04:14:28 +00:00
2019-05-03 11:42:48 +02:00
2019-05-03 11:42:48 +02:00
2021-02-04 12:02:36 +10:30
2020-02-02 12:59:17 +10:30
2020-09-08 09:42:00 +09:30
2020-06-23 18:49:15 +02:00
2019-07-17 12:55:37 -05:00
2019-07-17 12:55:37 -05:00
2020-11-10 10:34:13 -06:00
2020-11-10 10:34:13 -06:00
2021-06-25 13:23:28 +09:30
2021-06-25 13:23:28 +09:30
2021-05-22 17:53:04 +09:30
2021-05-22 17:53:04 +09:30
2020-08-25 12:53:13 +09:30
2020-04-04 16:08:49 +10:30
2020-04-04 16:08:49 +10:30
2020-01-31 06:02:47 +00:00
2021-07-03 12:13:45 +09:30
2021-07-03 12:13:45 +09:30
2021-06-04 16:13:08 +09:30
2021-06-04 16:13:08 +09:30
2021-02-04 12:02:36 +10:30
2021-02-04 12:02:36 +10:30
2021-07-20 13:28:38 -04:00
2020-09-08 09:42:00 +09:30
2019-09-06 14:35:01 +02:00
2021-05-22 17:53:04 +09:30
2020-10-21 08:58:34 +10:30
2021-08-24 06:42:32 +09:30
2021-08-24 06:42:32 +09:30
2020-02-05 14:19:12 +01:00
2020-02-05 14:19:12 +01:00
2020-12-11 15:51:24 +01:00
2020-12-11 15:51:24 +01:00
2021-06-18 10:40:07 +09:30
2021-01-06 13:50:01 +01:00
2020-10-22 12:14:34 +10:30
2018-02-08 22:49:34 +01:00
2020-08-14 11:51:14 +09:30
2020-08-14 11:51:14 +09:30
2020-08-24 20:55:47 +09:30
2020-08-24 20:55:47 +09:30
2021-03-23 14:24:38 -05:00
2020-12-11 15:51:24 +01:00
2020-11-23 12:21:33 -06:00
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-09-02 15:06:18 +02:00
2021-07-20 13:28:38 -04:00
2018-10-19 22:02:11 +00:00
2020-02-05 14:19:12 +01:00
2020-12-15 12:05:02 +01:00
2020-12-15 12:05:02 +01:00
2021-06-16 10:29:17 +09:30
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-03-03 09:18:53 +10:30
2020-10-23 13:53:16 +10:30
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-02-04 12:02:36 +10:30
2021-01-07 19:32:47 +01:00
2021-08-25 10:06:31 +02:00
2020-08-24 20:55:47 +09:30
2017-08-29 17:54:14 +02:00
2020-08-24 20:55:47 +09:30
2019-09-10 16:18:25 -05:00
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-07-23 13:26:31 -04:00
2021-02-04 12:02:36 +10:30
2020-09-23 13:52:49 +09:30
2021-02-04 12:02:36 +10:30
2019-05-03 11:42:48 +02:00
2021-02-04 12:02:36 +10:30
2020-12-09 16:40:13 +10:30
2021-06-26 10:55:13 +09:30
2021-06-26 10:55:13 +09:30
2020-05-18 14:51:12 +02:00
2020-01-23 16:17:42 +10:30
2021-07-20 13:28:38 -04:00
2021-06-16 10:29:17 +09:30
2020-02-05 14:19:12 +01:00
2021-06-30 14:12:24 +09:30
2018-02-23 18:02:00 +01:00
2021-02-04 12:02:52 +10:30
2021-02-04 12:02:52 +10:30
2021-02-04 12:02:52 +10:30
2021-07-21 13:27:27 -04:00
2021-07-21 13:27:27 -04:00
2021-02-04 12:02:36 +10:30
2020-05-07 15:05:39 +09:30
2021-02-04 12:02:36 +10:30
2019-09-20 06:55:00 +00:00
2020-06-11 13:13:13 +02:00
2019-04-08 00:00:00 +00:00
2020-09-08 09:42:00 +09:30
2018-02-22 12:24:26 +01:00
2021-02-04 12:02:36 +10:30
2020-10-21 08:58:34 +10:30
2021-03-25 20:05:11 +10:30
2021-03-25 20:05:11 +10:30
2021-09-05 14:24:14 +02:00
2021-09-05 14:24:14 +02:00
2019-04-16 21:22:13 +00:00
2019-04-16 21:22:13 +00:00
2020-08-28 10:56:50 +09:30
2020-08-28 10:56:50 +09:30
2021-06-25 13:23:28 +09:30
2021-06-25 13:23:28 +09:30
2021-07-14 14:38:00 -05:00
2021-05-22 17:53:04 +09:30
2021-08-14 12:44:33 +09:30
2020-05-19 13:35:42 +09:30
2021-05-26 20:01:03 +09:30
2021-05-26 20:01:03 +09:30
2018-05-09 04:43:21 +00:00
2018-05-09 04:43:21 +00:00
2021-02-04 12:02:36 +10:30
2020-12-11 15:51:24 +01:00
2020-10-23 13:53:16 +10:30
2020-10-23 13:53:16 +10:30
2018-02-08 19:07:12 +01:00
2021-04-24 13:56:58 +09:30
2018-02-08 19:07:12 +01:00
2021-07-21 13:27:27 -04:00
2021-07-21 13:27:27 -04:00
2021-04-24 13:56:58 +09:30
2019-11-18 04:50:22 +00:00
2019-11-18 04:50:22 +00:00
2019-09-06 14:35:01 +02:00
2018-03-16 00:16:10 +00:00
2017-08-29 17:54:14 +02:00
2020-10-20 12:50:31 +10:30
2021-02-04 12:02:36 +10:30
2021-07-20 13:28:38 -04:00
2020-12-02 10:38:04 +10:30
2021-01-13 14:45:36 +01:00
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2020-10-22 12:14:34 +10:30
2018-01-29 03:22:27 +00:00
2019-06-08 02:58:27 +00:00
2019-10-07 20:03:24 -05:00
2021-02-04 12:02:52 +10:30
2021-02-04 12:02:52 +10:30
2021-06-16 10:29:17 +09:30
2021-06-17 11:46:48 +09:30