Rusty Russell 21d2cc663b lightningd: apply feerate changes correctly. ...

Feerate changes are asymmetric, as they can only be sent by the funder.

For FUNDER, the remote feerate is set when upon send of
commitment_signed, and the local feerate is set on receipt of
revoke_and_ack.

For non-funder, the local feerate is set on receipt of
commitment_signed, and the remote feerate set on send of
revoke_and_ack.  In our code, these two happen together.

channeld gets this right, but lightningd ignored the funder/fundee
distinction, and as a result, receipt of a commitment_signed by the
funder altered fees in the database.  If there was a reconnection
event or restart, then these (incorrect) values would be used, causing
us to complain about a 'Bad commit_sig signature' and close the
channel.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2019-10-28 13:07:41 -05:00

..

data

pytest: test db upgrade.

2019-09-06 14:19:14 +02:00

plugins

pytest: make test_plugin_slowinit a test again

2019-10-11 10:05:08 -05:00

benchmark.py

py-tests: rename 'announce' to 'wait_for_announce'

2018-12-08 15:15:55 -08:00

btcproxy.py

pytest: Do not edit the global copy of the bitcoind config

2019-10-03 04:32:57 +00:00

conftest.py

pytest: Pass result to fixtures and keep directories of failed tests

2018-08-07 00:54:19 +00:00

db.py

pytest: Have the DB provider search for the postgres binary

2019-09-22 02:03:43 +00:00

fixtures.py

pytest: Check for null access warnings in tests

2019-10-21 13:56:10 +02:00

requirements.txt

pytest: Add db_provider and db instances for configurable backends

2019-09-22 02:03:43 +00:00

test_closing.py

pytest: Add the test for compact of deprecated close style

2019-10-09 21:04:16 -05:00

test_connection.py

lightningd: apply feerate changes correctly.

2019-10-28 13:07:41 -05:00

test_db.py

pytest: Mark some tests as skippable that are too bitcoin-specific

2019-10-03 04:32:57 +00:00

test_gossip.py

common/features: only support a single feature bitset.

2019-10-11 02:52:04 +00:00

test_invoices.py

pytest: Mark some tests as skippable that are too bitcoin-specific

2019-10-03 04:32:57 +00:00

test_misc.py

pylightning: wrap signmessage/checkmessage.

2019-10-15 17:15:23 +02:00

test_pay.py

pytest: allow bad gossip in test_pay_direct.

2019-10-21 14:08:05 +02:00

test_plugin.py

pytest: make test_plugin_slowinit a test again

2019-10-11 10:05:08 -05:00

test_wallet.py

pytest: test hsm_secret encryption

2019-10-09 22:00:38 -05:00

utils.py

pytest: add filters arg to query_gossip()

2019-10-10 21:48:52 -05:00