lightning

mirror of https://github.com/aljazceru/lightning.git synced 2025-12-24 01:24:26 +01:00

Files

Rusty Russell 1c495ca5a8 connectd: fix accidental handling of old reconnections.

We had multiple reports of channels being unilaterally closed because
it seemed like the peer was sending old revocation numbers.

Turns out, it was actually old reestablish messages!  When we have a
reconnection, we would put the new connection aside, and tell lightningd
to close the current connection: when it did, we would restart
processing of the initial reconnection.

However, we could end up with *multiple* "reconnecting" connections,
while waiting for an existing connection to close.  Though the
connections were long gone, there could still be messages queued
(particularly the channel_reestablish message, which comes early on).

Eventually, a normal reconnection would cause us to process one of
these reconnecting connections, and channeld would see the (perhaps
very old!) messages, and get confused.

(I have a test which triggers this, but it also hangs the connect
 command, due to other issues we will fix in the next release...)

Fixes: #5240
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2022-05-16 09:59:42 +09:30

test

connectd: restore obs2 onion support.

2022-03-29 10:55:12 +10:30

connectd_gossipd_wire.csv

gossipd: don't hand out fds.

2022-02-08 11:15:52 +10:30

connectd_wire.csv

connectd: disable advertizement of WEBSOCKET addresses.

2022-04-21 06:13:55 +09:30

connectd.c

connectd: fix accidental handling of old reconnections.