Rusty Russell 1a78efaee5 peer_control: don't refer to peer in copy_to_parent_log ...

Once we rely on the logbook outlasting the peer, we can't refer to the
peer from the logbook function:

Valgrind error file: valgrind-errors.26567
==26567== Invalid read of size 8
==26567==    at 0x126297: copy_to_parent_log (peer_control.c:690)
==26567==    by 0x11C06B: maybe_print (log.c:253)
==26567==    by 0x11C145: logv (log.c:270)
==26567==    by 0x11C448: log_ (log.c:319)
==26567==    by 0x132951: destroy_subd (subd.c:537)
==26567==    by 0x179C19: notify (tal.c:240)
==26567==    by 0x17A0CE: del_tree (tal.c:400)
==26567==    by 0x17A120: del_tree (tal.c:410)
==26567==    by 0x17A4ED: tal_free (tal.c:509)
==26567==    by 0x16DEB5: io_close (io.c:443)
==26567==    by 0x1328BC: sd_msg_read (subd.c:516)
==26567==    by 0x1320AC: read_fds (subd.c:328)
==26567==  Address 0x6cf9ca0 is 48 bytes inside a block of size 216 free'd
==26567==    at 0x4C30D3B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26567==    by 0x17A1A9: del_tree (tal.c:421)
==26567==    by 0x17A4ED: tal_free (tal.c:509)
==26567==    by 0x124B6C: delete_peer (peer_control.c:180)
==26567==    by 0x12B369: destroy_uncommitted_channel (peer_control.c:2505)
==26567==    by 0x179C19: notify (tal.c:240)
==26567==    by 0x17A0CE: del_tree (tal.c:400)
==26567==    by 0x17A4ED: tal_free (tal.c:509)
==26567==    by 0x12B31E: opening_channel_errmsg (peer_control.c:2496)
==26567==    by 0x13243A: handle_peer_error (subd.c:407)
==26567==    by 0x1326E4: sd_msg_read (subd.c:472)
==26567==    by 0x1320AC: read_fds (subd.c:328)
==26567==  Block was alloc'd at
==26567==    at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26567==    by 0x179C83: allocate (tal.c:250)
==26567==    by 0x17A250: tal_alloc_ (tal.c:448)
==26567==    by 0x124950: new_peer (peer_control.c:151)
==26567==    by 0x12B3EC: new_uncommitted_channel (peer_control.c:2521)
==26567==    by 0x12B5C5: peer_accept_channel (peer_control.c:2569)
==26567==    by 0x126099: peer_sent_nongossip (peer_control.c:641)
==26567==    by 0x113B28: peer_nongossip (gossip_control.c:55)
==26567==    by 0x113D9D: gossip_msg (gossip_control.c:144)
==26567==    by 0x132783: sd_msg_read (subd.c:487)
==26567==    by 0x1320AC: read_fds (subd.c:328)
==26567==    by 0x16D1FE: next_plan (io.c:59)
==26567==

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2018-02-19 02:56:51 +00:00

..

test

lightningd: use tal_link for log_book.

2018-02-19 02:56:51 +00:00

.gitignore

handshaked: remove.

2017-10-20 18:31:32 +02:00

bitcoind.c

bitcoind: trivial cleanups.

2018-02-01 03:12:43 +00:00

bitcoind.h

lightningd: bitcoind and topology routines take channel, not peer.

2018-02-14 11:31:58 +01:00

build_utxos.c

wallet: Use newindex primitive to generate change key index

2018-01-08 17:19:25 +01:00

build_utxos.h

build_utxos: fix weight calculation, and make more accurate.

2017-12-20 12:56:15 +01:00

chaintopology.c

chaintopology: fix 100 block subtraction.

2018-02-16 13:07:12 +01:00

chaintopology.h

lightningd: bitcoind and topology routines take channel, not peer.

2018-02-14 11:31:58 +01:00

channel.c

wallet: don't use rowid for the channel's DBID.

2018-02-19 02:56:51 +00:00

channel.h

wallet: don't use rowid for the channel's DBID.

2018-02-19 02:56:51 +00:00

dev_ping.c

lightningd: split struct peer into struct peer and struct channel.

2018-02-14 11:31:58 +01:00

gossip_control.c

gossip: Fix up some comments on PR #955

2018-02-11 11:40:59 +01:00

gossip_control.h

gossipd: rewrite to do the handshake internally.

2017-10-20 18:31:32 +02:00

gossip_msg.c

tools/generate_wire.py: make varlen structs self-allocate.

2018-02-08 19:07:12 +01:00

gossip_msg.h

tools/generate_wire.py: make varlen structs self-allocate.

2018-02-08 19:07:12 +01:00

hsm_control.c

hsm: give it its own log, so it has unique prefix.

2018-02-07 00:46:49 +00:00

hsm_control.h

lightningd/hsm_control: use a simple fd for HSM.

2017-06-27 10:25:53 +09:30

htlc_end.c

Rename (almost) all destructors to destroy_<type>.

2018-02-14 11:31:58 +01:00

htlc_end.h

htlc: keep channel pointer, not peer pointer.

2018-02-14 11:31:58 +01:00

invoice.c

invoice: Disable overlong description.

2018-02-19 02:42:11 +00:00

invoice.h

invoices: Extensive reorganization of invoice system.

2018-01-16 13:03:54 +01:00

jsonrpc_errors.h

payalgo: Create a new failure for paying expired invoice.

2018-02-18 13:51:37 +01:00

jsonrpc.c

jsonrpc: allow multiple commands in-flight from single JSON connection.

2018-02-16 17:51:04 +01:00

jsonrpc.h

jsonrpc: allow multiple commands in-flight from single JSON connection.

2018-02-16 17:51:04 +01:00

lightningd.c

lightningd: use tal_link for log_book.

2018-02-19 02:56:51 +00:00

lightningd.h

lightningd: use tal_link for log_book.

2018-02-19 02:56:51 +00:00

log_status.c

status: generate messages rather than marshal/unmarshal manually.

2018-02-08 19:07:12 +01:00

log_status.h

status: add multiple levels of logging.

2018-02-07 00:46:49 +00:00

log.c

lightningd: use tal_link for log_book.

2018-02-19 02:56:51 +00:00

log.h

lightningd: use tal_link for log_book.

2018-02-19 02:56:51 +00:00

Makefile

payalgo: New file for pay command.

2018-02-16 13:08:29 +01:00

memdump.c

Start all command descriptions with a verb ("Show", "Set", etc.). Remove unused help texts.

2018-01-23 13:32:44 +01:00

netaddress.c

Fix a-vs-an typos

2018-02-08 22:49:34 +01:00

netaddress.h

wireaddr: add ip[:port] parsing

2017-12-21 09:56:20 +00:00

opt_time.c

common: absorb remaining files from daemon/

2017-08-29 17:54:14 +02:00

opt_time.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

options.c

lightningd: implement --daemon.

2018-02-16 13:02:41 +01:00

options.h

lightningd: --deprecated-api option to turn off deprecated APIs.

2018-01-19 22:23:45 +00:00

pay.c

payalgo: Repeat pay command if possible.

2018-02-16 13:08:29 +01:00

pay.h

payalgo: New file for pay command.

2018-02-16 13:08:29 +01:00

payalgo.c

payalgo: Create a new failure for paying expired invoice.

2018-02-18 13:51:37 +01:00

payalgo.h

payalgo: New file for pay command.

2018-02-16 13:08:29 +01:00

peer_control.c

peer_control: don't refer to peer in copy_to_parent_log

2018-02-19 02:56:51 +00:00

peer_control.h

wallet: don't implicitly remove peers, but do it explicitly.

2018-02-14 11:31:58 +01:00

peer_htlcs.c

onchain: handle case where multiple HTLCs exist for same payment_hash.

2018-02-14 11:57:42 +01:00

peer_htlcs.h

lightningd/peer_htlcs: remove remaining peer_ shims.

2018-02-14 11:31:58 +01:00

peer_state.h

wallet: don't use rowid for the channel's DBID.

2018-02-19 02:56:51 +00:00

subd.c

Rename (almost) all destructors to destroy_<type>.

2018-02-14 11:31:58 +01:00

subd.h

subd: keep pointer to channel, not peer.

2018-02-14 11:31:58 +01:00

txfilter.c

txfilter: Expose the txfilter_add_scriptpubkey function

2018-01-08 17:19:25 +01:00

txfilter.h

txfilter: Expose the txfilter_add_scriptpubkey function

2018-01-08 17:19:25 +01:00

watch.c

lightningd: bitcoind and topology routines take channel, not peer.

2018-02-14 11:31:58 +01:00

watch.h

lightningd: bitcoind and topology routines take channel, not peer.

2018-02-14 11:31:58 +01:00