Rusty Russell 13b1d922bb chaintopology: fix rebroadcast code. ...

broadcast_remainder() does two things: get the error message for the
previous transaction, and send the next one (shrinking the array).

But it has two bugs:
1) It logs results on the tx at the end of the array, which is the one
   it is *about* to send, and
2) The initial caller (rebroadcast_txs) hands it the complete array,
   so the first tx gets broadcast twice.

The correct thing to do is to strip the array, then send the tail for
the next callback.  And use nicely-named vars to help document what
we're doing.

Reported-by: Christian Decker
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2016-11-07 23:04:02 +10:30

..

jsmn @ bd9bd55c3a

daemon/jsmn: Add submodule for jsmn.

2016-01-22 06:37:13 +10:30

test

jsonrpc: Fixed listinvoice returning broken JSON

2016-10-23 10:57:29 +02:00

.gitignore

daemon: first code.

2016-01-22 06:41:47 +10:30

bitcoind.c

bitcoind_sendrawtx: hand error code to callback.

2016-11-07 23:00:02 +10:30

bitcoind.h

bitcoind_sendrawtx: hand error code to callback.

2016-11-07 23:00:02 +10:30

chaintopology.c

chaintopology: fix rebroadcast code.

2016-11-07 23:04:02 +10:30

chaintopology.h

broadcast_tx: add optional failed callback.

2016-11-07 23:01:02 +10:30

channel.c

channel: fix max feelevel calculation.

2016-10-07 14:00:17 +10:30

channel.h

peer: give more sensible error if anchor is too large.

2016-09-13 12:40:32 +09:30

commit_tx.c

commit_tx: free temporary wscript, rather than leaving attached to tx.

2016-11-04 11:17:03 +10:30

commit_tx.h

channel: remove enum channel_side, rename htlc_side to side.

2016-08-31 16:06:32 +09:30

configdir.c

config: different defaults for mainnet and testnet.

2016-10-07 14:00:18 +10:30

configdir.h

config: different defaults for mainnet and testnet.

2016-10-07 14:00:18 +10:30

controlled_time.c

daemon: rename all the low-level commands to dev-

2016-09-06 16:47:49 +09:30

controlled_time.h

daemon: test restarting.

2016-08-18 14:25:14 +09:30

cryptopkt.c

peer: free init packet.

2016-11-04 11:17:04 +10:30

cryptopkt.h

peer: do logging before crypto is on.

2016-08-31 16:06:31 +09:30

db.c

db: fix leak for initial commit state.

2016-11-04 11:17:05 +10:30

db.h

daemon: fix feechange logic.

2016-10-07 14:00:17 +10:30

dns.c

dns: simplify code by reaping dns child as soon as we have answers.

2016-11-04 11:17:03 +10:30

dns.h

daemon: rename 'state' to 'dstate' everywhere.

2016-01-22 06:41:49 +10:30

failure.c

htlc: save fail message in HTLC.

2016-08-31 14:51:41 +09:30

failure.h

htlc: save fail message in HTLC.

2016-08-31 14:51:41 +09:30

feechange_state.h

daemon: handle feechange requests.

2016-08-26 15:31:19 +09:30

feechange.c

feechange: fix db updates.

2016-11-01 21:33:27 +10:30

feechange.h

db: save error, return it when we commit transaction.

2016-09-06 16:47:49 +09:30

htlc_state.h

db.c: database API.

2016-08-18 14:25:13 +09:30

htlc.c

db: save error, return it when we commit transaction.

2016-09-06 16:47:49 +09:30

htlc.h

db: save error, return it when we commit transaction.

2016-09-06 16:47:49 +09:30

invoice.c

invoice: print duplicate r value even if we choose it.

2016-11-01 21:34:58 +10:30

invoice.h

db: save error, return it when we commit transaction.

2016-09-06 16:47:49 +09:30

irc_announce.c

irc: Fix crash bug in node announcement parsing

2016-11-04 15:01:01 -07:00

irc_announce.h

routing: Added IRC announcement glue

2016-09-07 23:49:39 +02:00

json.c

getroute: add a risk factor.

2016-09-06 16:47:48 +09:30

json.h

getroute: add a risk factor.

2016-09-06 16:47:48 +09:30

jsonrpc.c

jsonrpc: free old connections

2016-11-01 21:34:57 +10:30

jsonrpc.h

Merge remote-tracking branch 'origin/pr/44'

2016-10-17 12:31:19 +10:30

lightning-cli.c

log: add netaddr

2016-11-04 11:17:03 +10:30

lightningd.c

config: Allow overriding the transaction fee rate

2016-11-06 10:35:48 -08:00

lightningd.h

config: Allow overriding the transaction fee rate

2016-11-06 10:35:48 -08:00

log.c

log: add netaddr

2016-11-04 11:17:03 +10:30

log.h

log: add netaddr

2016-11-04 11:17:03 +10:30

Makefile

sphinx: Integrate sphinx OR with lightningd

2016-10-16 16:40:50 +02:00

netaddr.c

peer: keep addresses separately from peers.

2016-08-18 14:25:14 +09:30

netaddr.h

peer: keep addresses separately from peers.

2016-08-18 14:25:14 +09:30

opt_time.c

daemon: test restarting.

2016-08-18 14:25:14 +09:30

opt_time.h

daemon: test restarting.

2016-08-18 14:25:14 +09:30

output_to_htlc.c

channel: remove enum channel_side, rename htlc_side to side.

2016-08-31 16:06:32 +09:30

output_to_htlc.h

channel: remove enum channel_side, rename htlc_side to side.

2016-08-31 16:06:32 +09:30

packets.c

broadcast_tx: make sure callers free tx if necessary.

2016-11-07 23:03:02 +10:30

packets.h

accept_pkt_open_commit_sig: don't allocate sig.

2016-11-04 11:17:04 +10:30

pay.c

json_getroute: don't leak.

2016-11-04 11:17:04 +10:30

pay.h

db: save and restore "sendpay" commands.

2016-09-05 13:29:48 +09:30

peer.c

broadcast_tx: make sure callers free tx if necessary.

2016-11-07 23:03:02 +10:30

peer.h

broadcast_tx: make sure callers free tx if necessary.

2016-11-07 23:03:02 +10:30

pseudorand.c

daemon: use siphash for hashes.

2016-07-01 12:00:17 +09:30

pseudorand.h

daemon: use siphash for hashes.

2016-07-01 12:00:17 +09:30

routing.c

Merge remote-tracking branch 'origin/pr/65'

2016-11-05 13:48:16 +10:30

routing.h

Merge remote-tracking branch 'origin/pr/65'

2016-11-05 13:48:16 +10:30

secrets.c

db.c: database API.

2016-08-18 14:25:13 +09:30

secrets.h

db.c: database API.

2016-08-18 14:25:13 +09:30

sphinx.c

Merge remote-tracking branch 'origin/pr/66'

2016-11-05 13:48:38 +10:30

sphinx.h

sphinx: Implemented sphinx onion routing

2016-10-16 16:40:43 +02:00

timeout.c

tal_tmpctx: clear marker for temporary contexts.

2016-11-01 21:34:27 +10:30

timeout.h

timeout: make all timers one-shot.

2016-05-10 06:26:09 +09:30

wallet.c

lightningd: move testnet flag out of config.

2016-10-07 14:00:18 +10:30

wallet.h

db.c: database API.

2016-08-18 14:25:13 +09:30

watch.c

watch: make it easier for them to self-delete.

2016-07-01 12:00:17 +09:30

watch.h

watch: make it easier for them to self-delete.

2016-07-01 12:00:17 +09:30