ZmnSCPxj, ZmnSCPxj jxPCSmnZ 044705a547 peer_control: Fix a use-after-free bug. (#1237) ...

This bug is a classic case of being lazy:
1. peer_accept_channel() allocated its return off the input message,
   rather than taking an explicit allocation context.  This concealed the
   lifetime nature of the return.
2. The context for sanitize_error was the error itself, rather than the
   more obvious tmpctx (connect_failed does not take).

The global tmpctx removes the "efficiency" excuse for grabbing a random
object to use as context, and is also nice and explicit.

All-the-hard-work-by: @ZmnSCPxj

2018-03-19 09:27:09 +00:00

..

test

utils: remove tal_tmpctx altogether, use global.

2018-03-16 00:16:10 +00:00

.gitignore

handshaked: remove.

2017-10-20 18:31:32 +02:00

bitcoind.c

take: allocate temporary variables off NULL.

2018-03-16 00:16:10 +00:00

bitcoind.h

lightningd: add --bitcoin-cli arg for testing.

2018-02-24 10:37:28 +01:00

build_utxos.c

wallet: Use newindex primitive to generate change key index

2018-01-08 17:19:25 +01:00

build_utxos.h

build_utxos: fix weight calculation, and make more accurate.

2017-12-20 12:56:15 +01:00

chaintopology.c

chaintopology: Add missing block_map_del.

2018-03-16 01:45:08 +00:00

chaintopology.h

topology: Track blockchain changes in the DB

2018-03-06 18:59:27 +01:00

channel_control.c

utils: remove tal_tmpctx altogether, use global.

2018-03-16 00:16:10 +00:00

channel_control.h

lightningd/channel_control: routines to control channeld (move from peer_control.c)

2018-02-20 22:36:21 +01:00

channel_state.h

channel_states: fold all the ONCHAIND states into one.

2018-02-23 18:02:00 +01:00

channel.c

channel_fail_permanent: Use a channel-level error, not an all-channels error.

2018-03-17 13:26:58 +01:00

channel.h

channel: reserve a bip32 index as soon as channel is opened.

2018-03-07 18:55:51 +01:00

closing_control.c

Mark unused parameters as such (using "UNUSED")

2018-03-16 01:17:40 +00:00

closing_control.h

lightningd/closing_control: routines to control closingd (move from peer_control.c)

2018-02-20 22:36:21 +01:00

connect_control.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

connect_control.h

lightningd/peer_control: reorder, move more functions out.

2018-02-20 22:36:21 +01:00

dev_ping.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

gossip_control.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

gossip_control.h

gossipd: rewrite to do the handshake internally.

2017-10-20 18:31:32 +02:00

gossip_msg.c

jsonrpc: Return the channel capacity for listchannels

2018-03-12 22:34:51 +00:00

gossip_msg.h

jsonrpc: Return the channel capacity for listchannels

2018-03-12 22:34:51 +00:00

hsm_control.c

utils: remove tal_tmpctx altogether, use global.

2018-03-16 00:16:10 +00:00

hsm_control.h

lightningd/hsm_control: use a simple fd for HSM.

2017-06-27 10:25:53 +09:30

htlc_end.c

Remove unused parameter ptr in corrupt(const void *ptr, ...)

2018-02-22 10:46:30 +01:00

htlc_end.h

htlc: keep channel pointer, not peer pointer.

2018-02-14 11:31:58 +01:00

invoice.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

invoice.h

invoices: Extensive reorganization of invoice system.

2018-01-16 13:03:54 +01:00

json.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

json.h

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

jsonrpc_errors.h

payalgo: Implement retry_for for pay command.

2018-03-19 00:27:55 +00:00

jsonrpc.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

jsonrpc.h

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

lightningd.c

Fix misleading indentation (in the case of DEVELOPER)

2018-03-16 01:17:40 +00:00

lightningd.h

pay: Have sendpay wait for payment to be saved.

2018-03-14 05:33:09 +00:00

log_status.c

tools/generate-wire.py: remove length argument from fromwire_ routines.

2018-02-20 22:36:21 +01:00

log_status.h

status: add multiple levels of logging.

2018-02-07 00:46:49 +00:00

log.c

lightningd: remove ltmp context now we have tmpctx.

2018-03-16 00:16:10 +00:00

log.h

lightningd: remove ltmp context now we have tmpctx.

2018-03-16 00:16:10 +00:00

Makefile

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

memdump.c

memdump: fix overzealous assertions from b857b2e843

2018-03-16 00:16:10 +00:00

netaddress.c

lightningd: remove ltmp context now we have tmpctx.

2018-03-16 00:16:10 +00:00

netaddress.h

wireaddr: add ip[:port] parsing

2017-12-21 09:56:20 +00:00

onchain_control.c

Mark unused parameters as such (using "UNUSED")

2018-03-16 01:17:40 +00:00

onchain_control.h

txwatch: remove unused callback arg, hide struct definitions.

2018-02-20 22:36:21 +01:00

opening_control.c

peer_control: Fix a use-after-free bug. (#1237)

2018-03-19 09:27:09 +00:00

opening_control.h

peer_control: Fix a use-after-free bug. (#1237)

2018-03-19 09:27:09 +00:00

opt_time.c

Fix order of includes

2018-03-06 19:26:21 +01:00

opt_time.h

headers: fix up header idempotent lines.

2017-08-29 17:54:14 +02:00

options.c

Instead of passing the line number behind the '\0' of an artificial command-line argument, store it in a global variable.

2018-03-06 19:26:21 +01:00

options.h

lightningd: --deprecated-api option to turn off deprecated APIs.

2018-01-19 22:23:45 +00:00

pay.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

pay.h

pay: Make json_add_payment_fields accessible to other parts.

2018-03-19 00:27:55 +00:00

payalgo.c

lightningd/json: Move json helpers specific for lightningd to new module.

2018-03-19 00:27:55 +00:00

payalgo.h

payalgo: New file for pay command.

2018-02-16 13:08:29 +01:00

peer_control.c

peer_control: Fix a use-after-free bug. (#1237)

2018-03-19 09:27:09 +00:00

peer_control.h

lightning/peer_control.h: Minor cleanup of nonexistent functions.

2018-02-25 20:41:50 +00:00

peer_htlcs.c

utils: remove tal_tmpctx altogether, use global.

2018-03-16 00:16:10 +00:00

peer_htlcs.h

lightningd/peer_control: reorder, move more functions out.

2018-02-20 22:36:21 +01:00

subd.c

Make sure we never pass a negative value to dup2(...)

2018-03-19 09:25:39 +00:00

subd.h

subd: handle status_peer_billboard messages from subdaemons.

2018-02-23 18:02:00 +01:00

watch.c

lightningd: remove ltmp context now we have tmpctx.

2018-03-16 00:16:10 +00:00

watch.h

Remove unused parameter topo in txowatch_fire(struct chain_topology *topo, ...)

2018-02-22 10:46:30 +01:00