5 Commits

Author	SHA1	Message	Date
Rusty Russell	df9552bcc1	db: make db_exec_prepared_v2 return void. ... It calls db_fatal() if it fails anyway, so don't expect anyone to check. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2023-04-06 09:50:32 +09:30
Rusty Russell	9bcf28afb3	db: catch SQL errors unless we're expecting them. ... I couldn't figure out why my new SQL query was returning 0 rows, and it was because we were ignoring errors. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2023-04-06 09:50:32 +09:30
Rusty Russell	e853cdc3ff	db: fix sqlite3 code which manipulates columns. ... Because it used internal routines, it didn't pass operations through the db hook! So make it use the generic routines, with the twist that they are not translated. And when we use this in a migration hook, we're actually in a transaction. This, in turn, introduces an issue: we need to be outside a transaction to "PRAGMA foreign_keys = OFF", but completing the transaction when there is a db hook actually enters the io loop, freeing the tmpctx! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2022-09-12 14:00:41 +02:00
Rusty Russell	2971b2af79	bkpr: insert obscure 60s pop references. ... The initial snapshots on an already-running lightningd are expected to be unbalanced, but this shouldn't cause users to long for the green, green grass of home. This controls the Art of Noise. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2022-08-01 09:01:08 -07:00
niftynei	ce12d2b8a9	database: pull out database code into a new module ... We're going to reuse the database controllers for the accounting plugin	2022-03-05 15:03:34 +10:30