Rusty Russell
8975fc2ceb
libwally: use their secp context for all our daemons.
...
I didn't convert all tests: they can still use a standalone context.
It's just marginally more efficient to share the libwally one for all
our daemons which link against it anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-04-03 14:03:28 +02:00
practicalswift
7e9750ffee
Reduce variable scopes
2018-03-26 01:31:21 +00:00
Rusty Russell
7ae013202f
json: make json_add_string do partial escapes.
...
This is useful when we log a JSON-escaped string, so we don't double-escape.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-03-26 00:20:53 +00:00
Rusty Russell
d92579f627
common/json_escaped: new type which explicitly notes a string is already JSON.
...
Trivial to use as a string, but it still means you should be careful
around it.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-03-26 00:20:53 +00:00
Rusty Russell
0a6e3d1e13
utils: remove tal_tmpctx altogether, use global.
...
In particular, we now only free tmpctx at the end of main().
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-03-16 00:16:10 +00:00
Christian Decker
08bfb740f5
onion: Move cli onion tool to devtools/onion
...
Signed-off-by: Christian Decker <decker.christian@gmail.com >
2018-03-09 17:57:55 +01:00
ZmnSCPxj
f7f55edcdb
wireaddr: Do hostname resolution in parse_wireaddr.
...
Fixes : #834
2018-02-26 03:13:55 +00:00
practicalswift
91a9c2923f
Mark intentionally unused parameters as such (with "UNUSED")
2018-02-22 01:09:12 +00:00
Rusty Russell
eb0603bd13
wireaddr: rework port parsing for weird addresses.
...
We save wireaddr to databases as a string (which is pretty dumb) but
it turned out that my local node saved '[::ffff:127.0.0.1]:49150'
which our parser can't parse.
Thus I've reworked the parser to make fewer assumptions:
parse_ip_port() is renamed to separate_address_and_port() and is now
far more accepting of different forms, and returns failure only on
grossly malformed strings. Otherwise it overwrites its *port arg only
if there's a port specified. I also made it static.
Then fromwire_wireaddr() hands the resulting address to inet_pton to
figure out if it's actually valid.
Cc: William Casarin <jb55@jb55.com >
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-02-08 19:14:21 +01:00
Rusty Russell
7f03e15e03
json_add_string_escape: for escaping internally-generated strings.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2018-02-02 00:05:00 +01:00
Björge Dijkstra
648e4feee2
Extend json unit test with tests for json_tok_bitcoin_amount()
2018-01-13 00:15:03 +01:00
William Casarin
ce1d709d44
wireaddr: fix ipv6 formatting with ports in fmt_wireaddr
...
Correctly format ipv6 address with ports. This will also make it more compatible
with the new parse_wireaddr, which has been updated to parse ports. They are
inverses now.
Also add some tests that check this.
Signed-off-by: William Casarin <jb55@jb55.com >
2017-12-21 09:56:20 +00:00
William Casarin
3e7aabe256
test: add tests for parse_ip_port
...
This tests the basic functionality of parse_ip_port, which is used in
parse_wireaddr.
Signed-off-by: William Casarin <jb55@jb55.com >
2017-12-21 09:56:20 +00:00
Rusty Russell
0610f66c34
bolt11: handle r value fee spec change.
...
We don't use it yet, but now we'll decode correctly.
See: https://github.com/lightningnetwork/lightning-rfc/pull/317
lightning-rfc commit: ef053c09431442697ab46e83f9d3f86e3510a18e
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-12-12 11:45:44 +01:00
Christian Decker
9bcb01e710
fixup! common/test: add spec tests for bolt11.
2017-11-24 13:22:18 +01:00
Rusty Russell
ae6faf7f9c
common/test: add spec tests for bolt11.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-11-24 13:22:18 +01:00
Rusty Russell
112ae0d0f5
common/test/run-json: test JSON escaping.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-11-01 09:46:05 +01:00
Rusty Russell
ab634dfcdd
common/test_sphinx: change to standard run- format.
...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-11-01 09:46:05 +01:00
Rusty Russell
7200002773
tests: detect and close leaks in unit tests.
...
Fixes : #288
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-09-29 10:20:08 +09:30
Rusty Russell
4f6ae3209b
common/test/test_sphinx: build fixes.
...
It isn't currently included in make check, so fix it to build and do that.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-09-11 14:29:20 +02:00
Rusty Russell
739b163f8b
Makefiles: simplify dependencies.
...
Gather all binaries and objects and make the depend on external
requirements and common headers.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2017-08-29 17:54:14 +02:00