aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-22 08:34:20 +01:00
Code Issues Packages Projects Releases Wiki Activity
7,869 Commits 1 Branch 0 Tags
78d95b51aab0b34584e6a5144196893ee5b15034
Commit Graph

2651 Commits

Author SHA1 Message Date
ZmnSCPxj
551dfedc4a jsonrpc: Internal: Support changing the error code internally. 2018-01-27 14:32:06 +01:00
ZmnSCPxj
b2133e969f jsonrpc: Trivial compliance with JSON-RPC Error Object. 2018-01-27 14:32:06 +01:00
Christian Decker
a7a6b4646a json-rpc: Remove alarming debug statement 
People keep on stumbling over this, since it's rather alarming.

Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-27 02:27:35 +00:00
Ronald van der Meer
8e087c1d71 clarified lightning-cli help dev-setfees description 2018-01-26 03:00:29 +00:00
Christian Decker
6cfc0a6275 fixup! masterd: Disable a channel when channeld fails 2018-01-26 01:09:44 +00:00
Christian Decker
e463386d75 masterd: Disable a channel when channeld fails 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-26 01:09:44 +00:00
Christian Decker
c6ae4b521f gossip: Add message to enable and disable a channel 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-26 01:09:44 +00:00
Christian Decker
d14969ce77 masterd: Peer has to know which direction an eventual channel is 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-26 01:09:44 +00:00
Rusty Russell
9f9c34002e chain_topology: log block height, not just hash. 
Saves me a lookup.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-25 12:52:06 +01:00
Rusty Russell
e9328217ff peer_control: better logging when we don't tell peer about locked funding. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-25 12:52:06 +01:00
Rusty Russell
c42fa4404a connect: succeed if we connect to peer and it *doesn't* go back to gossipd. 
The JSON connect command wouldn't terminate if peer reconnected
in a state CHANNELD_AWAITING_LOCKIN or above.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-25 12:52:06 +01:00
practicalswift
b91556283b Onboarding: Adjust log level for common non-fatal peer state condition from info to debug 2018-01-25 00:28:47 +00:00
practicalswift
3a8220d630 Warn instead of crash when extract_feerate(...) fails 
Fixes: #722
 2018-01-25 00:16:14 +00:00
practicalswift
0557467dfa Adjust log level for feerate warnings 
This condition seems to be triggered quite common on testnet, so no
need for warning floods unless we're running in debug mode :-)
 2018-01-25 00:15:47 +00:00
Christian Decker
9588c961bb wallet: Forget channels that are irrevocably settled on-chain 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-25 00:14:23 +00:00
Rusty Russell
45665a994b htlc_end: allow htlc_out to have 0 msatoshi. 
Such an htlc is invalid, and will be failed cleanly by our channeld
(which also checks that it meets the minimum amount), but it's
not the master's job to check it, and in fact, it asserts if we were
to try to pay or forward such a thing.

Fixes: #686
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-24 19:34:46 +01:00
Rusty Russell
3ccf88d6c4 lightningd: check channeld isn't trying to add 0-satoshi incoming HTLCs. 
The peer shouldn't try, and channeld won't try to add it if it does,
but we shouldn't trust it.  And it would make our htlc_in_check() code
assert.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-24 19:34:46 +01:00
Carl Dong
8da65854f0 build: Add needed UNIX standard includes. 2018-01-23 16:10:19 +01:00
practicalswift
5631054152 Start all command descriptions with a verb ("Show", "Set", etc.). Remove unused help texts. 2018-01-23 13:32:44 +01:00
practicalswift
22087dad03 Adjust log level: Warn about ignored fee limits only in debug log 2018-01-22 19:23:23 +01:00
William Casarin
f8e5de1974 listpeers: print channel configs 
Signed-off-by: William Casarin <jb55@jb55.com>
 2018-01-21 23:03:07 +01:00
Ephraim Raj
041b641161 Added that peer id should be given to dev-sign-last-tx 2018-01-20 17:57:04 +01:00
practicalswift
2f179fb6cb Don't greet new users with an error message 
Before this patch:

```
$ lightningd/lightningd
lightningd(PID): Creating lightningd dir /root/.lightning (because chdir gave No such file or directory)
lightningd(PID): Creating database
```

After this patch:

```
$ lightningd/lightningd
lightningd(PID): Creating lightningd dir /root/.lightning
lightningd(PID): Creating database
```
 2018-01-20 01:32:59 +01:00
Christian Decker
97447dd4c4 options: Dropping default base_fee for mainnet to 1 satoshi 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-19 22:25:16 +00:00
Rusty Russell
8797159825 Use consistent names for timestamps. 
Old fields still there, just deprecated.

Invoice commands:
	paid_timestamp -> paid_at
	expiry_time -> expires_at

decodepay:
	timestamp -> created_at

getlog:
	creation_time -> created_at

listpayments:
	timestamp -> created_at

Suggested-by: @shesek
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
4f1dc91ba5 lightningd: rename --deprecated-apis to --allow-deprecated-apis. 
Suggested-byL practicalswift
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
5e0a5c9111 JSONRPC: delinvoice: have a status argument. 
delinvoice was orginally documented to only allow deletion of unpaid
invoices, but there might be reasons to delete paid ones or unexpired ones.

But we have to avoid the race where someone pays as it's deleted: the
easiest way is to have the caller tell us the status, and fail if
it's wrong.

Fixes: #477
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
2443d45b47 delinvoice: fixes. 
Error code is inverted (which makes sense: who returns 'true' on
error?), and anyway there's a leak if we do error.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
c8c68cfb7c JSONRPC: listpeers multiple channels, output improvements. 
We're going to have to support multiple channels per peer, even if only
when some are onchain.  This would break the current listpeers, so
change it to an array (single element for now).

Other cleanups:

1. Only set connected true if daemon is not onchaind.
2. Only show netaddr if connected; don't make it an array, call it `address`
   in comparison with `addresses` in listnodes.
3. Rename `channel` to `short_channel_id`
4. Add `funding_txid` field for voyeurism.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
bd010d4b96 listinvoices: deprecate 'complete' in favor of 'status' trinary. 
[ Manpage regen fixup by Christian Decker ]
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
8dfbfa2069 dev-ping: use id not peerid as argument name. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
2f2cacef0d JSONRPC: output from listpeers should be 'id' not 'peerid'. 
That's what we use everywhere else.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
cf54f23947 JSONRPC: add id argument to listpeers. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
5698a133c2 JSONRPC: rename getpeers to listpeers. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
34a994c7db JSONRPC: listpayments not return a naked array. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
361fdccfca JSONRPC: help returns an object. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
843ede78c6 JSONRPC: listinvoices: wrap array in 'invoices' field. 
This allows us to add other fields, such as version information,
warnings or invoiceless payments, later.

(Note: the deprecated listinvoice is unchanged)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
1a641c823c JSONRPC: Make listinvoice an deprecated alias for listinvoices. 
This matches the other names, and also the return value is about to change.

This will be removed before release!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
6e703ad977 JSONRPC: listpayments can list just a specific bolt11 or payment_hash. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
06c4f6ddca JSONRPC: add optional short_channel_id argument to listchannels 
In order to just list one (though it may return two entries, one for each
channel direction!).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
7fdb30cbda JSONRPC: rename getchannels to listchannels 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
8cf1870465 jsonrpc: add json_tok_short_channel_id helper. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
e1e7f289fb JSONRPC listnodes: return timestamp, alias and color. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
ced572b973 JSONRPC: getnodes: rename to listnodes. 
Like listinvoice, and add optional 'id' parameter to ask about a
specific node.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
e745572dfb JSONPRC: decodepay: print 'c' value. 
If they want to call getroute manually, they'll need this.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Rusty Russell
1f6392fa83 lightningd: --deprecated-api option to turn off deprecated APIs. 
This can be used for upgrades to make sure you're not using deprecated
options, JSON commands, JSON fields, etc.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-19 22:23:45 +00:00
Christian Decker
ced486e727 jsonrpc: Add the network name to the getinfo output 
Signed-off-by: Christian Decker <decker.christian@gmail.com>
 2018-01-18 23:34:51 +01:00
ZmnSCPxj
a88c73a41b invoices: Add paid_timestamp field. 
Fixes: #615
 2018-01-18 17:37:10 +01:00
ZmnSCPxj, ZmnSCPxj jxPCSmnZ
a06f0dfeb1 Make fundchannel return txid too 
For voyeurism.

Fixes: #402
 2018-01-18 02:03:28 +00:00
Rusty Russell
9ed7041c46 bitcoind: if callback says don't call on error, dont. 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2018-01-17 23:55:35 +01:00