4 Commits

Author	SHA1	Message	Date
Rusty Russell	02faadfb93	amount: make it work with gcc-4.8. ... ``` In file included from bitcoin/chainparams.h:7:0,from bitcoin/chainparams.c:1: ./common/amount.h:36:11: error: initializer element is not constant ((struct amount_sat){(constant) + AMOUNT_MUST_BE_CONST(constant)}) ^ bitcoin/chainparams.c:20:21: note: in expansion of macro ‘AMOUNT_SAT’ .max_funding = AMOUNT_SAT((1 << 24) - 1), ^ ./common/amount.h:36:11: error: (near initialization for ‘networks[0].max_funding’) ((struct amount_sat){(constant) + AMOUNT_MUST_BE_CONST(constant)}) ^ bitcoin/chainparams.c:20:21: note: in expansion of macro ‘AMOUNT_SAT’ .max_funding = AMOUNT_SAT((1 << 24) - 1), ``` Fixes: #2404 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2019-02-27 23:12:50 +00:00
Rusty Russell	f5dc8b9d52	JSON: allow any number of decimal points when parsing 'btc' suffix. ... I tried to fundchannel 0.01btc, and of course it wanted 8 decimals exactly. If I can't get this right, it's probably a bad idea. I still don't allow whole number of btc though, since that's probably a mistake and you're not supposed to put that much in c-lightning yet :) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2019-02-23 03:09:37 +00:00
Rusty Russell	023923e6a8	amount: minor comment and text improvements and remove unused function. ... Reported-by: @niftynei Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2019-02-21 00:44:57 +00:00
Rusty Russell	7fad7bccba	common/amount: new types struct amount_msat and struct amount_sat. ... They're generally used pass-by-copy (unusual for C structs, but convenient they're basically u64) and all possibly problematic operations return WARN_UNUSED_RESULT bool to make you handle the over/underflow cases. The new #include in json.h means we bolt11.c sees the amount.h definition of MSAT_PER_BTC, so delete its local version. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>	2019-02-21 00:44:57 +00:00