mirror of
https://github.com/aljazceru/lightning.git
synced 2025-12-19 07:04:22 +01:00
Update ccan/structeq.
structeq() is too dangerous: if a structure has padding, it can fail silently. The new ccan/structeq instead provides a macro to define foo_eq(), which does the right thing in case of padding (which none of our structures currently have anyway). Upgrade ccan, and use it everywhere. Except run-peer-wire.c, which is only testing code and can use raw memcmp(): valgrind will tell us if padding exists. Interestingly, we still declared short_channel_id_eq, even though we didn't define it any more! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
committed by
Christian Decker
parent
4a1ca0fb99
commit
fed5a117e7
@@ -1,7 +1,10 @@
|
||||
#ifndef LIGHTNING_COMMON_UTILS_H
|
||||
#define LIGHTNING_COMMON_UTILS_H
|
||||
#include "config.h"
|
||||
#include <ccan/crypto/ripemd160/ripemd160.h>
|
||||
#include <ccan/crypto/sha256/sha256.h>
|
||||
#include <ccan/short_types/short_types.h>
|
||||
#include <ccan/structeq/structeq.h>
|
||||
#include <ccan/tal/tal.h>
|
||||
#include <secp256k1.h>
|
||||
|
||||
@@ -28,4 +31,10 @@ void setup_tmpctx(void);
|
||||
/* Free any children of tmpctx. */
|
||||
void clean_tmpctx(void);
|
||||
|
||||
/* Define sha256_eq. */
|
||||
STRUCTEQ_DEF(sha256, 0, u);
|
||||
|
||||
/* Define ripemd160_eq. */
|
||||
STRUCTEQ_DEF(ripemd160, 0, u);
|
||||
|
||||
#endif /* LIGHTNING_COMMON_UTILS_H */
|
||||
|
||||
Reference in New Issue
Block a user