aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-02-23 15:04:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

libplugin: allow commands and options to mark themselves deprecated.

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2020-08-06 10:00:51 +09:30
parent 7a7a849fc2
commit fc097b8b48
4 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/test_plugin.py
View File

@@ -967,7 +967,8 @@ def test_rpc_command_hook(node_factory):
def test_libplugin(node_factory):
"""Sanity checks for plugins made with libplugin"""
plugin = os.path.join(os.getcwd(), "tests/plugins/test_libplugin")
l1 = node_factory.get_node(options={"plugin": plugin})
l1 = node_factory.get_node(options={"plugin": plugin,
'allow-deprecated-apis': False})
# Test startup
assert l1.daemon.is_in_log("test_libplugin initialised!")
@@ -996,6 +997,39 @@ def test_libplugin(node_factory):
# Test RPC calls FIXME: test concurrent ones ?
assert l1.rpc.call("testrpc") == l1.rpc.getinfo()
# Make sure deprecated options nor commands are mentioned.
with pytest.raises(RpcError, match=r'Command "testrpc-deprecated" is deprecated'):
l1.rpc.call('testrpc-deprecated')
assert not any([h['command'] == 'testrpc-deprecated'
for h in l1.rpc.help()['help']])
with pytest.raises(RpcError, match=r"Deprecated command.*testrpc-deprecated"):
l1.rpc.help('testrpc-deprecated')
assert 'name-deprecated' not in str(l1.rpc.listconfigs())
l1.stop()
l1.daemon.opts["name-deprecated"] = "test_opt"
# This actually dies while waiting for the logs.
with pytest.raises(ValueError):
l1.start()
del l1.daemon.opts["name-deprecated"]
l1.start()
def test_libplugin_deprecated(node_factory):
"""Sanity checks for plugins made with libplugin using deprecated args"""
plugin = os.path.join(os.getcwd(), "tests/plugins/test_libplugin")
l1 = node_factory.get_node(options={"plugin": plugin,
'name-deprecated': 'test_opt depr',
'allow-deprecated-apis': True})
assert l1.rpc.call("helloworld") == "hello test_opt depr"
l1.rpc.help('testrpc-deprecated')
assert l1.rpc.call("testrpc-deprecated") == l1.rpc.getinfo()
@unittest.skipIf(
not DEVELOPER or DEPRECATED_APIS, "needs LIGHTNINGD_DEV_LOG_IO and new API"