aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

pay: don't list dummy channel if error is from final hop.

Browse Source 
List the final one instead; if there's an error from the node it
may actually make sense to blame that channel (ie. previous node
did something wrong).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2019-01-18 17:07:08 +10:30
committed by Christian Decker
parent 4e6b8e13a4
commit f8ecd08721
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lightningd/pay.c
View File

@@ -297,7 +297,6 @@ remote_routing_failure(const tal_t *ctx,
const struct pubkey *erring_node; const struct pubkey *erring_node;
const struct short_channel_id *route_channels; const struct short_channel_id *route_channels;
const struct short_channel_id *erring_channel; const struct short_channel_id *erring_channel;
static const struct short_channel_id dummy_channel = { 0 };
int origin_index; int origin_index;
int dir; int dir;
@@ -310,9 +309,15 @@ remote_routing_failure(const tal_t *ctx,
/* Check if at destination. */ /* Check if at destination. */
if (origin_index == tal_count(route_nodes) - 1) { if (origin_index == tal_count(route_nodes) - 1) {
/* FIXME: Don't set erring_channel or dir in this case! */ /* If any channel is to blame, it's the last one. */
erring_channel = &dummy_channel; erring_channel = &route_channels[origin_index];
dir = 0; /* Single hop? */
if (origin_index == 0)
dir = pubkey_idx(&ld->id,
&route_nodes[origin_index]);
else
dir = pubkey_idx(&route_nodes[origin_index - 1],
&route_nodes[origin_index]);
/* BOLT #4: /* BOLT #4:
* *