aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2026-02-22 22:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

plugins/sql: fix foreign keys.

Browse Source 
I noticed that our subtables were not being cleaned, despite being "ON
DELETE CASCADE".  This is because foreign keys were not enabled, but
then I got foreign key errors: rowid cannot be a foreign key anyway!

So create a real "rowid" column.  We want "ON DELETE CASCADE" for
nodes and channels (and other tables in future) where we update
partially.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-02-01 12:28:32 +10:30
committed by Alex Myers
parent 3dde1ca399
commit f87c7ed439
3 changed files with 41 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/test_plugin.py
View File

@@ -3294,6 +3294,9 @@ def test_sql(node_factory, bitcoind):
ret = l2.rpc.sql("SELECT * FROM forwards;")
assert ret == {'rows': []}
# Test that we correctly clean up subtables!
assert len(l2.rpc.sql("SELECT * from peerchannels_features")['rows']) == len(l2.rpc.sql("SELECT * from peerchannels_features")['rows'])
# This should create a forward through l2
l1.rpc.pay(l3.rpc.invoice(amount_msat=12300, label='inv1', description='description')['bolt11'])
@@ -3798,12 +3801,13 @@ def test_sql(node_factory, bitcoind):
'number': 'REAL',
'short_channel_id': 'TEXT'}
# Check schemas match.
# Check schemas match (each one has rowid at start)
rowidcol = {'name': 'rowid', 'type': 'u64'}
for table, schema in expected_schemas.items():
res = only_one(l2.rpc.listsqlschemas(table)['schemas'])
assert res['tablename'] == table
assert res.get('indices') == schema.get('indices')
sqlcolumns = [{'name': c['name'], 'type': sqltypemap[c['type']]} for c in schema['columns']]
sqlcolumns = [{'name': c['name'], 'type': sqltypemap[c['type']]} for c in [rowidcol] + schema['columns']]
assert res['columns'] == sqlcolumns
# Make sure we didn't miss any
@@ -3827,7 +3831,11 @@ def test_sql(node_factory, bitcoind):
for table, schema in expected_schemas.items():
ret = l2.rpc.sql("SELECT * FROM {};".format(table))
assert len(ret['rows'][0]) == len(schema['columns'])
assert len(ret['rows'][0]) == 1 + len(schema['columns'])
# First column is always rowid!
for row in ret['rows']:
assert row[0] > 0
for col in schema['columns']:
val = only_one(l2.rpc.sql("SELECT {} FROM {};".format(col['name'], table))['rows'][0])