aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 15:14:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

JSON-RPC: don't allow any strings which aren't valid UTF-8.

Browse Source 
We already do some sanity checks, add this one.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: JSON-RPC: invalid UTF-8 strings now rejected.
This commit is contained in:
Rusty Russell
2020-11-25 10:47:44 +10:30
parent 5bdd282c2b
commit f0621cec0d
3 changed files with 54 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
common/test/run-json.c
View File

@@ -1,6 +1,7 @@
#include "../json_helpers.c"
#include <assert.h>
#include <ccan/mem/mem.h>
#include <ccan/tal/str/str.h>
#include <common/json.h>
#include <common/utils.h>
#include <inttypes.h>
@@ -258,6 +259,34 @@ static void test_json_delve(void)
assert(json_tok_streq(buf, t, "lightning-rpc"));
}
static void test_json_bad_utf8(void)
{
const jsmntok_t *toks;
char *buf;
buf = tal_strdup(tmpctx, "{\"1\":\"one\", \"2\":\"two\", \"3\":[\"three\", {\"deeper\": 17}]}");
toks = json_parse_simple(tmpctx, buf, strlen(buf));
assert(toks);
assert(toks->size == 3);
assert(json_tok_streq(buf, &toks[1], "1"));
buf[toks[1].start] = 0xC0;
assert(!json_parse_simple(tmpctx, buf, strlen(buf)));
buf[toks[1].start] = '1';
assert(json_tok_streq(buf, &toks[2], "one"));
buf[toks[2].start] = 0xC0;
assert(!json_parse_simple(tmpctx, buf, strlen(buf)));
buf[toks[2].start] = 'o';
assert(json_tok_streq(buf, &toks[7], "three"));
buf[toks[7].start] = 0xC0;
assert(!json_parse_simple(tmpctx, buf, strlen(buf)));
buf[toks[7].start] = 't';
assert(json_parse_simple(tmpctx, buf, strlen(buf)));
}
int main(void)
{
setup_locale();
@@ -267,6 +296,7 @@ int main(void)
test_json_tok_bitcoin_amount();
test_json_tok_millionths();
test_json_delve();
test_json_bad_utf8();
assert(!taken_any());
take_cleanup();
tal_free(tmpctx);