aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-22 00:24:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

peer: log unexpected packets properly.

Browse Source 
And only try to print the contents if they're PKT_ERR.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2016-08-09 13:11:10 +09:30
parent 4801f78aad
commit f00ee00fd8
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
daemon/peer.c
View File

@@ -2365,6 +2365,12 @@ void peer_unexpected_pkt(struct peer *peer, const Pkt *pkt)
{ {
const char *p; const char *p;
log_unusual(peer->log, "Received unexpected pkt %u (%s)",
pkt->pkt_case, pkt_name(pkt->pkt_case));
if (pkt->pkt_case != PKT__PKT_ERROR)
return;
/* Check packet for weird chars. */ /* Check packet for weird chars. */
for (p = pkt->error->problem; *p; p++) { for (p = pkt->error->problem; *p; p++) {
if (cisprint(*p)) if (cisprint(*p))
@@ -2372,11 +2378,11 @@ void peer_unexpected_pkt(struct peer *peer, const Pkt *pkt)
p = tal_hexstr(peer, pkt->error->problem, p = tal_hexstr(peer, pkt->error->problem,
strlen(pkt->error->problem)); strlen(pkt->error->problem));
log_unusual(peer->log, "Error pkt (hex) %s", p); log_add(peer->log, "hex: %s", p);
tal_free(p); tal_free(p);
return; return;
} }
log_unusual(peer->log, "Error pkt '%s'", pkt->error->problem); log_add(peer->log, "'%s'", pkt->error->problem);
} }
/* Create a bitcoin close tx, using last signature they sent. */ /* Create a bitcoin close tx, using last signature they sent. */