aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-19 23:24:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

dev-allowdustreserve: make this a DEVELOPER option.

Browse Source 
Otherwise, we should rename it?

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2023-06-01 16:12:43 +09:30
parent ea665d1851
commit ec8bba6b8a
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lightningd/options.c
View File

@@ -861,6 +861,10 @@ static void dev_register_opts(struct lightningd *ld)
"own. Small values will cause channels to be" "own. Small values will cause channels to be"
" closed more often due to fee fluctuations," " closed more often due to fee fluctuations,"
" large values may result in large fees."); " large values may result in large fees.");
opt_register_arg("--dev-allowdustreserve", opt_set_bool_arg, opt_show_bool,
&ld->config.allowdustreserve,
"If true, we allow the `fundchannel` RPC command and the `openchannel` plugin hook to set a reserve that is below the dust limit.");
} }
#endif /* DEVELOPER */ #endif /* DEVELOPER */
@@ -1354,11 +1358,6 @@ static void register_opts(struct lightningd *ld)
opt_register_arg("--autolisten", opt_set_bool_arg, opt_show_bool, opt_register_arg("--autolisten", opt_set_bool_arg, opt_show_bool,
&ld->autolisten, &ld->autolisten,
"If true, listen on default port and announce if it seems to be a public interface"); "If true, listen on default port and announce if it seems to be a public interface");
opt_register_arg("--dev-allowdustreserve", opt_set_bool_arg, opt_show_bool,
&ld->config.allowdustreserve,
"If true, we allow the `fundchannel` RPC command and the `openchannel` plugin hook to set a reserve that is below the dust limit.");
opt_register_arg("--proxy", opt_add_proxy_addr, NULL, opt_register_arg("--proxy", opt_add_proxy_addr, NULL,
ld,"Set a socks v5 proxy IP address and port"); ld,"Set a socks v5 proxy IP address and port");
opt_register_arg("--tor-service-password", opt_set_talstr, NULL, opt_register_arg("--tor-service-password", opt_set_talstr, NULL,

3
tests/test_opening.py
View File

@@ -1812,6 +1812,7 @@ def test_zeroconf_multichan_forward(node_factory):
.format(normal_scid, zeroconf_scid)) .format(normal_scid, zeroconf_scid))
@pytest.mark.developer("dev-allowdustreserve")
def test_zeroreserve(node_factory, bitcoind): def test_zeroreserve(node_factory, bitcoind):
"""Ensure we can set the reserves. """Ensure we can set the reserves.
@@ -1891,6 +1892,7 @@ def test_zeroreserve(node_factory, bitcoind):
assert len(decoded['vout']) == 1 if TEST_NETWORK == 'regtest' else 2 assert len(decoded['vout']) == 1 if TEST_NETWORK == 'regtest' else 2
@pytest.mark.developer("dev-allowdustreserve")
def test_zeroreserve_mixed(node_factory, bitcoind): def test_zeroreserve_mixed(node_factory, bitcoind):
"""l1 runs with zeroreserve, l2 and l3 without, should still work """l1 runs with zeroreserve, l2 and l3 without, should still work
@@ -1921,6 +1923,7 @@ def test_zeroreserve_mixed(node_factory, bitcoind):
l3.rpc.fundchannel(l1.info['id'], 10**6) l3.rpc.fundchannel(l1.info['id'], 10**6)
@pytest.mark.developer("dev-allowdustreserve")
def test_zeroreserve_alldust(node_factory): def test_zeroreserve_alldust(node_factory):
"""If we allow dust reserves we need larger fundings """If we allow dust reserves we need larger fundings