cleanup: remove unneeded includes in header files.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

common/addr.h

@@ -2,8 +2,6 @@
 #define LIGHTNING_COMMON_ADDR_H
 #include "config.h"
 #include <bitcoin/chainparams.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
 
 /* Given a scriptPubkey, return an encoded address */
 char *encode_scriptpubkey_to_addr(const tal_t *ctx,

common/amount.h

@@ -1,10 +1,8 @@
 #ifndef LIGHTNING_COMMON_AMOUNT_H
 #define LIGHTNING_COMMON_AMOUNT_H
 #include "config.h"
-#include <ccan/build_assert/build_assert.h>
 #include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
-#include <stdbool.h>
 
 #define MSAT_PER_SAT ((u64)1000)
 #define SAT_PER_BTC ((u64)100000000)

common/bech32_util.h

@@ -2,10 +2,8 @@
 #define LIGHTNING_COMMON_BECH32_UTIL_H
 #include "config.h"
 
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <common/hash_u5.h>
-#include <stdbool.h>
 
 /**
  * Push the bytes in src in 5 bit format onto the end of data.

common/bolt11.h

@@ -2,11 +2,8 @@
 #define LIGHTNING_COMMON_BOLT11_H
 #include "config.h"
 
-#include <bitcoin/pubkey.h>
 #include <bitcoin/short_channel_id.h>
 #include <ccan/list/list.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/take/take.h>
 #include <common/hash_u5.h>
 #include <common/node_id.h>
 #include <secp256k1_recovery.h>

common/bolt11_json.c

@@ -2,12 +2,14 @@
 #include <bitcoin/base58.h>
 #include <bitcoin/chainparams.h>
 #include <bitcoin/script.h>
+#include <ccan/tal/str/str.h>
 #include <common/bech32.h>
 #include <common/bolt11.h>
 #include <common/bolt11_json.h>
 #include <common/json.h>
 #include <common/json_helpers.h>
 #include <common/json_stream.h>
+#include <common/utils.h>
 
 static void json_add_fallback(struct json_stream *response,
 			      const char *fieldname,

common/bolt12.c

@@ -3,11 +3,13 @@
 #include <ccan/cast/cast.h>
 #include <ccan/crypto/sha256/sha256.h>
 #include <ccan/mem/mem.h>
+#include <ccan/tal/str/str.h>
 #include <common/bech32.h>
 #include <common/bech32_util.h>
 #include <common/bolt12.h>
 #include <common/bolt12_merkle.h>
 #include <common/features.h>
+#include <common/utils.h>
 #include <secp256k1_schnorrsig.h>
 #include <time.h>
 

common/bolt12_merkle.c

@@ -4,6 +4,7 @@
 #include <ccan/ilog/ilog.h>
 #include <ccan/mem/mem.h>
 #include <common/bolt12_merkle.h>
+#include <common/utils.h>
 
 #ifndef SUPERVERBOSE
 #define SUPERVERBOSE(...)

common/channel_config.h

@@ -1,8 +1,6 @@
 #ifndef LIGHTNING_COMMON_CHANNEL_CONFIG_H
 #define LIGHTNING_COMMON_CHANNEL_CONFIG_H
 #include "config.h"
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
 #include <common/amount.h>
 
 /* BOLT #2:

common/close_tx.h

@@ -1,11 +1,7 @@
 #ifndef LIGHTNING_COMMON_CLOSE_TX_H
 #define LIGHTNING_COMMON_CLOSE_TX_H
 #include "config.h"
-#include <bitcoin/chainparams.h>
 #include <bitcoin/tx.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
-#include <common/amount.h>
 
 struct pubkey;
 

common/coin_mvt.c

@@ -1,9 +1,11 @@
 #include "config.h"
 #include <assert.h>
+#include <bitcoin/tx.h>
 #include <ccan/ccan/cast/cast.h>
 #include <ccan/tal/str/str.h>
 #include <common/coin_mvt.h>
 #include <common/type_to_string.h>
+#include <wire/wire.h>
 
 static const char *mvt_types[] = { "chain_mvt", "channel_mvt" };
 const char *mvt_type_str(enum mvt_type type)

common/coin_mvt.h

@@ -2,14 +2,8 @@
 #define LIGHTNING_COMMON_COIN_MVT_H
 #include "config.h"
 
-#include <bitcoin/tx.h>
-#include <ccan/ccan/crypto/sha256/sha256.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
 #include <common/amount.h>
 #include <common/channel_id.h>
-#include <stdbool.h>
-#include <wire/wire.h>
 
 #define COIN_MVT_VERSION 1
 

common/configdir.h

@@ -1,7 +1,6 @@
 #ifndef LIGHTNING_COMMON_CONFIGDIR_H
 #define LIGHTNING_COMMON_CONFIGDIR_H
 #include "config.h"
-#include <ccan/ptrint/ptrint.h>
 #include <ccan/tal/tal.h>
 
 /* Put things we're going to get rid of behind this, so testers can catch

common/crypto_state.h

@@ -2,8 +2,6 @@
 #define LIGHTNING_COMMON_CRYPTO_STATE_H
 #include "config.h"
 #include <bitcoin/privkey.h>
-#include <ccan/short_types/short_types.h>
-#include <stddef.h>
 
 struct crypto_state {
 	/* Received and sent nonces. */

common/cryptomsg.h

@@ -1,7 +1,6 @@
 #ifndef LIGHTNING_COMMON_CRYPTOMSG_H
 #define LIGHTNING_COMMON_CRYPTOMSG_H
 #include "config.h"
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <common/crypto_state.h>
 

common/daemon_conn.h

@@ -2,8 +2,6 @@
 #define LIGHTNING_COMMON_DAEMON_CONN_H
 
 #include "config.h"
-#include <ccan/io/io.h>
-#include <ccan/short_types/short_types.h>
 #include <common/msg_queue.h>
 
 /**

common/decode_array.h

@@ -1,7 +1,6 @@
 #ifndef LIGHTNING_COMMON_DECODE_ARRAY_H
 #define LIGHTNING_COMMON_DECODE_ARRAY_H
 #include "config.h"
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <common/bigsize.h>
 

common/derive_basepoints.h

@@ -4,7 +4,6 @@
 #include <assert.h>
 #include <bitcoin/privkey.h>
 #include <bitcoin/pubkey.h>
-#include <ccan/build_assert/build_assert.h>
 #include <ccan/crypto/shachain/shachain.h>
 
 struct sha256;

common/dijkstra.c

@@ -6,6 +6,7 @@
 #include <ccan/time/time.h>
 #include <common/dijkstra.h>
 #include <common/gossmap.h>
+#include <common/utils.h>
 #include <gheap.h>
 #include <inttypes.h>
 #include <stdio.h>

common/dijkstra.h

@@ -1,8 +1,6 @@
 #ifndef LIGHTNING_COMMON_DIJKSTRA_H
 #define LIGHTNING_COMMON_DIJKSTRA_H
 #include "config.h"
-#include <ccan/tal/tal.h>
-#include <ccan/typesafe_cb/typesafe_cb.h>
 #include <common/amount.h>
 
 struct gossmap;

common/errcode.h

@@ -4,7 +4,6 @@
 #include "config.h"
 
 #include <ccan/short_types/short_types.h>
-#include <inttypes.h>
 
 typedef s32 errcode_t;
 

common/hsm_encryption.h

@@ -2,7 +2,6 @@
 #define LIGHTNING_COMMON_HSM_ENCRYPTION_H
 #include "config.h"
 #include <bitcoin/privkey.h>
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <sodium.h>
 

common/htlc.h

@@ -4,11 +4,7 @@
 #include "bitcoin/locktime.h"
 #include "htlc_state.h"
 #include <assert.h>
-#include <ccan/crypto/sha256/sha256.h>
-#include <ccan/crypto/siphash24/siphash24.h>
 #include <ccan/htable/htable_type.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/str/str.h>
 
 #define NUM_SIDES (REMOTE + 1)
 enum side {

common/htlc_tx.h

@@ -2,7 +2,6 @@
 #define LIGHTNING_COMMON_HTLC_TX_H
 #include "config.h"
 #include <bitcoin/chainparams.h>
-#include <common/amount.h>
 #include <common/htlc.h>
 #include <common/utils.h>
 

common/htlc_wire.h

@@ -2,11 +2,8 @@
 #define LIGHTNING_COMMON_HTLC_WIRE_H
 #include "config.h"
 #include <bitcoin/preimage.h>
-#include <ccan/short_types/short_types.h>
-#include <common/amount.h>
 #include <common/htlc.h>
 #include <common/sphinx.h>
-#include <wire/onion_wire.h>
 
 struct bitcoin_tx;
 struct shachain;

common/initial_channel.h

@@ -3,17 +3,11 @@
 #define LIGHTNING_COMMON_INITIAL_CHANNEL_H
 #include "config.h"
 
-#include <bitcoin/pubkey.h>
-#include <bitcoin/shadouble.h>
 #include <bitcoin/tx.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
-#include <common/amount.h>
 #include <common/channel_config.h>
 #include <common/channel_id.h>
 #include <common/derive_basepoints.h>
 #include <common/htlc.h>
-#include <stdbool.h>
 
 struct signature;
 struct added_htlc;

common/initial_commit_tx.h

@@ -4,7 +4,6 @@
 #include "config.h"
 #include <bitcoin/chainparams.h>
 #include <bitcoin/pubkey.h>
-#include <common/amount.h>
 #include <common/htlc.h>
 #include <common/utils.h>
 

common/io_lock.h

@@ -3,7 +3,6 @@
 
 #include "config.h"
 #include <ccan/io/io.h>
-#include <ccan/tal/tal.h>
 struct io_lock;
 
 /**

common/json.h

@@ -2,13 +2,8 @@
 #define LIGHTNING_COMMON_JSON_H
 #include "config.h"
 #include <ccan/crypto/sha256/sha256.h>
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <common/errcode.h>
-#include <stdarg.h>
-#include <stdbool.h>
-#include <stdint.h>
-#include <stdlib.h>
 
 #define JSMN_STRICT 1
 # include <external/jsmn/jsmn.h>

common/json_command.h

@@ -4,10 +4,8 @@
 #define LIGHTNING_COMMON_JSON_COMMAND_H
 #include "config.h"
 #include <ccan/compiler/compiler.h>
-#include <common/errcode.h>
 #include <common/json.h>
 #include <common/jsonrpc_errors.h>
-#include <stdbool.h>
 
 struct command;
 struct command_result;

common/json_helpers.h

@@ -2,7 +2,6 @@
 #ifndef LIGHTNING_COMMON_JSON_HELPERS_H
 #define LIGHTNING_COMMON_JSON_HELPERS_H
 #include "config.h"
-#include <bitcoin/short_channel_id.h>
 #include <bitcoin/tx.h>
 #include <common/json.h>
 #include <wire/wire.h>
@@ -18,6 +17,7 @@ struct pubkey;
 struct pubkey32;
 struct secret;
 struct short_channel_id;
+struct short_channel_id_dir;
 struct wireaddr;
 struct wireaddr_internal;
 struct wally_psbt;

common/json_stream.h

@@ -4,13 +4,7 @@
 #ifndef LIGHTNING_COMMON_JSON_STREAM_H
 #define LIGHTNING_COMMON_JSON_STREAM_H
 #include "config.h"
-#include <ccan/membuf/membuf.h>
-#include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
-#include <ccan/typesafe_cb/typesafe_cb.h>
-#include <stdbool.h>
-#include <stddef.h>
-#include <stdint.h>
 
 struct command;
 struct io_conn;

common/json_tok.c

@@ -16,6 +16,7 @@
 #include <common/json_tok.h>
 #include <common/jsonrpc_errors.h>
 #include <common/param.h>
+#include <common/utils.h>
 
 struct command_result *param_array(struct command *cmd, const char *name,
 				   const char *buffer, const jsmntok_t *tok,

common/keyset.h

@@ -2,7 +2,6 @@
 #define LIGHTNING_COMMON_KEYSET_H
 #include "config.h"
 #include <bitcoin/pubkey.h>
-#include <stdbool.h>
 
 struct basepoints;
 

common/memleak.c

@@ -22,6 +22,7 @@
 #include "config.h"
 #include <assert.h>
 #include <backtrace.h>
+#include <ccan/cast/cast.h>
 #include <ccan/crypto/siphash24/siphash24.h>
 #include <ccan/htable/htable.h>
 #include <ccan/intmap/intmap.h>

common/memleak.h

@@ -1,10 +1,8 @@
 #ifndef LIGHTNING_COMMON_MEMLEAK_H
 #define LIGHTNING_COMMON_MEMLEAK_H
 #include "config.h"
-#include <ccan/cast/cast.h>
 #include <ccan/strmap/strmap.h>
 #include <ccan/tal/tal.h>
-#include <ccan/typesafe_cb/typesafe_cb.h>
 #include <inttypes.h>
 
 struct htable;

common/msg_queue.h

@@ -4,7 +4,6 @@
 #include "config.h"
 #include <ccan/io/io.h>
 #include <ccan/short_types/short_types.h>
-#include <ccan/take/take.h>
 
 /* Reserved type used to indicate we're actually passing an fd. */
 #define MSG_PASS_FD 0xFFFF

common/onion.c

@@ -5,6 +5,7 @@
 #include <common/ecdh.h>
 #include <common/onion.h>
 #include <common/sphinx.h>
+#include <common/utils.h>
 #include <sodium/crypto_aead_chacha20poly1305.h>
 #include <wire/onion_wire.h>
 

common/onion.h

@@ -2,7 +2,6 @@
 #define LIGHTNING_COMMON_ONION_H
 #include "config.h"
 #include <bitcoin/privkey.h>
-#include <ccan/short_types/short_types.h>
 #include <common/amount.h>
 
 struct route_step;

common/param.c

@@ -1,6 +1,7 @@
 #include <ccan/asort/asort.h>
 #include <ccan/tal/str/str.h>
 #include <common/json_command.h>
+#include <common/json_tok.h>
 #include <common/jsonrpc_errors.h>
 #include <common/param.h>
 #include <common/utils.h>

common/param.h

@@ -2,8 +2,6 @@
 #define LIGHTNING_COMMON_PARAM_H
 #include "config.h"
 #include <common/json.h>
-#include <common/json_tok.h>
-#include <stdbool.h>
 
 /*~ Greetings adventurer!
  *

common/penalty_base.h

@@ -2,8 +2,6 @@
 #define LIGHTNING_COMMON_PENALTY_BASE_H
 #include "config.h"
 #include <bitcoin/tx.h>
-#include <ccan/short_types/short_types.h>
-#include <common/amount.h>
 
 /* To create a penalty, all we need are these. */
 struct penalty_base {

common/psbt_open.h

@@ -4,9 +4,7 @@
 #include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
 #include <common/tx_roles.h>
-#include <stdbool.h>
 #include <wally_psbt.h>
-#include <wally_transaction.h>
 
 struct channel_id;
 struct wally_tx_input;

common/sphinx.c

@@ -16,6 +16,7 @@
 #include <secp256k1_ecdh.h>
 
 #include <sodium/crypto_stream_chacha20.h>
+#include <sodium/randombytes.h>
 
 #include <wire/wire.h>
 

common/sphinx.h

@@ -5,11 +5,7 @@
 #include "bitcoin/privkey.h"
 #include "bitcoin/pubkey.h"
 
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
 #include <common/hmac.h>
-#include <secp256k1.h>
-#include <sodium/randombytes.h>
 #include <wire/onion_wire.h>
 
 struct node_id;

common/status.h

@@ -1,13 +1,8 @@
 #ifndef LIGHTNING_COMMON_STATUS_H
 #define LIGHTNING_COMMON_STATUS_H
 #include "config.h"
-#include <ccan/compiler/compiler.h>
 #include <ccan/short_types/short_types.h>
-#include <ccan/take/take.h>
 #include <common/status_levels.h>
-#include <stdarg.h>
-#include <stdbool.h>
-#include <stdlib.h>
 
 struct channel_id;
 struct daemon_conn;

common/status_wire.c

@@ -1,3 +1,4 @@
+#include <common/status_levels.h>
 #include <common/status_wire.h>
 #include <wire/wire.h>
 

common/status_wire.csv

@@ -1,6 +1,7 @@
 #include <common/per_peer_state.h>
 #include <common/node_id.h>
 #include <common/status_wire.h>
+#include <common/status_levels.h>
 
 msgtype,status_log,0xFFF0
 msgdata,status_log,level,enum log_level,

common/status_wiregen.c

@@ -214,4 +214,4 @@ bool fromwire_status_version(const tal_t *ctx, const void *p, wirestring **versi
  	*version = fromwire_wirestring(ctx, &cursor, &plen);
 	return cursor != NULL;
 }
-// SHA256STAMP:83a462b28754c5b0c5a496b7e719f15ef6f6c1560f0eea12f76fa4b114189caa
+// SHA256STAMP:6910f83360952ba00ee6a56e96a7402d9b973eb125a6c98bec4d52fa97740457

common/status_wiregen.h

@@ -10,6 +10,7 @@
 #include <common/per_peer_state.h>
 #include <common/node_id.h>
 #include <common/status_wire.h>
+#include <common/status_levels.h>
 
 enum status_wire {
         WIRE_STATUS_LOG = 0xFFF0,
@@ -58,4 +59,4 @@ bool fromwire_status_version(const tal_t *ctx, const void *p, wirestring **versi
 
 
 #endif /* LIGHTNING_COMMON_STATUS_WIREGEN_H */
-// SHA256STAMP:83a462b28754c5b0c5a496b7e719f15ef6f6c1560f0eea12f76fa4b114189caa
+// SHA256STAMP:6910f83360952ba00ee6a56e96a7402d9b973eb125a6c98bec4d52fa97740457

common/subdaemon.c

@@ -1,4 +1,5 @@
 #include <ccan/tal/str/str.h>
+#include <common/daemon.h>
 #include <common/dev_disconnect.h>
 #include <common/status.h>
 #include <common/subdaemon.h>

common/subdaemon.h

@@ -2,6 +2,7 @@
 #define LIGHTNING_COMMON_SUBDAEMON_H
 #include "config.h"
 #include <common/daemon.h>
+
 struct htable;
 
 /* daemon_setup, but for subdaemons */

common/timeout.h

@@ -3,9 +3,7 @@
 #include "config.h"
 
 #include <ccan/tal/tal.h>
-#include <ccan/time/time.h>
 #include <ccan/timer/timer.h>
-#include <ccan/typesafe_cb/typesafe_cb.h>
 
 /* tal_free this to disable timer. */
 struct oneshot *new_reltimer_(struct timers *timers,

common/type_to_string.h

@@ -3,8 +3,6 @@
 #include "config.h"
 #include "utils.h"
 #include <ccan/autodata/autodata.h>
-#include <secp256k1.h>
-#include <wally_psbt.h>
 
 /* This must match the type_to_string_ cases. */
 union printable_types {

common/utxo.h

@@ -2,15 +2,8 @@
 #define LIGHTNING_COMMON_UTXO_H
 #include "config.h"
 #include <assert.h>
-#include <bitcoin/chainparams.h>
-#include <bitcoin/pubkey.h>
-#include <bitcoin/shadouble.h>
 #include <bitcoin/tx.h>
-#include <ccan/short_types/short_types.h>
-#include <ccan/tal/tal.h>
-#include <common/amount.h>
 #include <common/node_id.h>
-#include <stdbool.h>
 
 struct ext_key;
 

common/version.c

@@ -1,5 +1,7 @@
 #include "version.h"
+#include <ccan/compiler/compiler.h>
 #include <stdio.h>
+#include <stdlib.h>
 
 /* Only common/version.c can safely include this.  */
 # include "version_gen.h"

common/version.h

@@ -1,7 +1,6 @@
 #ifndef LIGHTNING_COMMON_VERSION_H
 #define LIGHTNING_COMMON_VERSION_H
 #include "config.h"
-#include <ccan/opt/opt.h>
 
 char *version_and_exit(const void *unused);
 const char *version(void);

common/wire_error.h

@@ -1,10 +1,8 @@
 #ifndef LIGHTNING_COMMON_WIRE_ERROR_H
 #define LIGHTNING_COMMON_WIRE_ERROR_H
 #include "config.h"
-#include <ccan/compiler/compiler.h>
 #include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
-#include <stdarg.h>
 
 struct channel_id;
 

common/wireaddr.h

@@ -3,8 +3,6 @@
 #include "config.h"
 #include <ccan/short_types/short_types.h>
 #include <ccan/tal/tal.h>
-#include <stdbool.h>
-#include <stdlib.h>
 #include <sys/socket.h>
 #include <sys/un.h>