From e9e6f72d7c662b28b91551543198a1c19b66c363 Mon Sep 17 00:00:00 2001
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Thu, 3 Dec 2020 11:52:01 +1030
Subject: [PATCH] bitcoin_tx_check: don't rely on tmpctx.

We assert() this in onchaind while grinding fees; better to free newtx.

Before this we hit 530MB, after a mere 2.5MB.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: onchaind uses much less memory on unilateral closes for old channels.
---
 bitcoin/tx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bitcoin/tx.c b/bitcoin/tx.c
index 88aca4004..0d0c757cf 100644
--- a/bitcoin/tx.c
+++ b/bitcoin/tx.c
@@ -256,6 +256,7 @@ bool bitcoin_tx_check(const struct bitcoin_tx *tx)
 	if (written != tal_bytelen(newtx))
 		return false;
 
+	tal_free(newtx);
 	return true;
 }