aljaz/lightning
1
0
Fork 0
mirror of https://github.com/aljazceru/lightning.git synced 2025-12-23 17:14:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

pyln-client: fix mypy warnings, fix and test deletion of a channel.

Browse Source 
This only happens when a deletion is added by a running gossipd, so
we put a deletion at the end of the store to test it.

mypy noticed that this code was nonsensical, so clearly untested.

The testing noticed that making a nodeid from a string was also buggy.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2021-09-08 06:26:06 +09:30
parent 125752118a
commit e8e7c4719f
3 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
contrib/pyln-client/tests/test_gossmap.py
View File

@@ -28,6 +28,12 @@ def test_gossmap(tmp_path):
g.refresh()
# This actually deletes a channel, which deletes a node.
assert g.get_channel("686386x1093x1") is None
assert g.get_node('029deaf9d2fba868fe0a124050f0a13e021519a12f41bea34f391fe7533fb3166d') is None
# The other node is untouched
assert g.get_node('02e0af3c70bf42343316513e54683b10c01d906c04a05dfcd9479b90d7beed9129')
# It will notice the new ones.
assert chans < len(g.channels)
assert nodes < len(g.nodes)
@@ -38,9 +44,8 @@ def test_gossmap(tmp_path):
assert set(g.nodes.keys()) == set(g2.nodes.keys())
# Check some details
channel1 = g.get_channel("686386x1093x1")
channel2 = g.get_channel("686200x1137x0")
assert channel1.satoshis == 1000000
assert g.get_channel("686386x1093x1") is None
assert channel2.satoshis == 3000000